GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: capitalize non-primitive types by vsemozhetbyt · Pull Request #18111 · nodejs/node

Conversation

@vsemozhetbyt

@vsemozhetbyt vsemozhetbyt commented Jan 12, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsemozhetbyt
doc: capitalize non-primitive types
fdd8a82
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 12, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jan 12, 2018
@vsemozhetbyt

vsemozhetbyt commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/83/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR
ChALkeR approved these changes Jan 12, 2018
View reviewed changes
jasnell
jasnell approved these changes Jan 12, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Jan 12, 2018
View reviewed changes
@vsemozhetbyt

vsemozhetbyt commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

Landed in c3fde98
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt closed this Jan 12, 2018
@vsemozhetbyt
vsemozhetbyt deleted the doc-cap-obj-types branch January 12, 2018 00:52
vsemozhetbyt added a commit that referenced this pull request Jan 12, 2018
@vsemozhetbyt
doc: capitalize non-primitive types
c3fde98 
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas

evanlucas commented Jan 30, 2018

Copy link
Copy Markdown
Contributor

This is not landing cleanly on v9.x-staging. If you would like to see this land in v9.x, can you please submit a backport PR? Thanks!
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas evanlucas added the backport-requested-v9.x label Jan 30, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jan 30, 2018
[v9.x backport] doc: capitalize non-primitive types #18465
Closed
2 of 3 tasks
@vsemozhetbyt

vsemozhetbyt commented Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

v9.x backport: #18465
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
6b1a40e 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added backported-to-v9.x and removed backport-requested-v9.x labels Feb 20, 2018
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
v9.6.0 proposal #18902
Merged
@MylesBorins MylesBorins added dont-land-on-v6.x labels Mar 20, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
be1d3b8 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
325dc27 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
e84e9db 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
v8.11.2 proposal #20478
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes
@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@vsemozhetbyt @evanlucas @ChALkeR @jasnell @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.