GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v8.11.2 proposal by MylesBorins · Pull Request #20478 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented May 2, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

2018-05-15, Version 8.11.2 'Carbon' (LTS), @MylesBorins

Notable Changes

  • deps:
    • update node-inspect to 1.11.3 (Jan Krems) #18354
    • update nghttp2 to 1.29.0 (James M Snell) #17908
  • http2:
    • Sync with current release stream
  • n-api:
    • Sync with current release stream

Commits

  • [ce3866bdcc] - async_hooks: clean up comments (Ali Ijaz Sheikh) #18467
  • [86e3c89ea4] - benchmark: improve compare output (Ruben Bridgewater) #18597
  • [18be476116] - benchmark: fix punycode test for --without-intl (Timothy Gu) #16251
  • [88d3028e22] - build: no longer have v8-debug.h as dependency. (Yang Guo) #18677
  • [7b6d93c145] - build: add doc linting when runnning make lint (Camilo Gonzalez) #18472
  • [9bce14172a] - build: do not suppress output in make doc-only (Joyee Cheung) #18507
  • [333d7dda84] - build: make lint-js independent of local node (Joyee Cheung) #18272
  • [d537f45aaa] - build: make lint-md independent of local node (Joyee Cheung) #18272
  • [658dd409fd] - build: refine static and shared lib build (Yihong Wang) #17604
  • [659b2a1821] - build: allow x86_64 as a dest_cpu alias for x64 (Rod Vagg) #18052
  • [424703a556] - build: add cflags for OpenBSD, remove stray comma. (Aaron Bieber) #18448
  • [674e75d1e9] - build,win: restore vcbuild TAG functionality (Rod Vagg) #18031
  • [bf4d0743be] - cluster: fix inspector port assignment (Santiago Gimeno) #18696
  • [16bf5fed69] - crypto: reuse variable instead of reevaluation (Tobias Nießen) #17735
  • [9acc7f3fbb] - deps: update nghttp2 to 1.29.0 (James M Snell) #17908
  • [ab005592be] - deps: V8: backport 76c3ac5 from upstream (Ali Ijaz Sheikh) #18298
  • [f12db24947] - deps: cherry-pick a803fad from upstream V8 (Michaël Zasso) #19824
  • [09f5e252bf] - deps: cherry-pick 7abdadc from upstream V8 (Michaël Zasso) #19824
  • [c97237bc10] - deps: cherry-pick a4bddba from upstream V8 (Michaël Zasso) #19824
  • [d02b72e799] - deps: V8: backport 596d55a from upstream (Myles Borins) #19477
  • [79a7a17312] - deps: update node-inspect to 1.11.3 (Jan Krems) #18354
  • [1131241d3c] - deps,src: align ssize_t ABI between Node & nghttp2 (Anna Henningsen) #18565
  • [29643cc492] - doc: add Http2Session.connecting property (Pieter Mees) #19842
  • [5989321404] - doc: guard against md list parsing edge case (Vse Mozhet Byt) #19647
  • [35d35d70c7] - doc: rename HTTP2 to HTTP/2 (Timothy Gu) #19603
  • [1f420fc799] - doc: add note about browsers and HTTP/2 (Steven) #19476
  • [fe3c85f72f] - doc: fix typo in http2.md (Vse Mozhet Byt) #18872
  • [67f9d5df97] - doc: warn against concurrent http2stream.respondWithFD (Anna Henningsen) #18762
  • [39267e8bb0] - doc: fix typo in http2.md (Vse Mozhet Byt) #18602
  • [2da965c5b8] - doc: remove removed apis from http2 docs (Kelvin Jin) #18439
  • [9a4a8c127e] - doc: unify type linkification (Vse Mozhet Byt) #18407
  • [15023c7d28] - doc: fix documentation of http2Stream.pushstream() (Peter Dalgaard-Jensen) #18258
  • [fac76f9a6b] - doc: fix typo in http2stream.close param default (Moritz Peters) #18166
  • [88babd5a23] - doc: fix s/rstStream/close in example (James M Snell) #18088
  • [d9d0d0e98e] - doc: update pushStream docs to use err first (James M Snell) #18088
  • [940457394a] - doc: compact eslint directives in common/README (Vse Mozhet Byt) #17971
  • [e9de5a976b] - doc: re-alphabetise sections in common/README.md (Vse Mozhet Byt) #17971
  • [c924adf33d] - doc: fix code nits in common/README (Vse Mozhet Byt) #17971
  • [0205b3f0c1] - doc: correct spelling (sreepurnajasti) #17911
  • [591f78bb0a] - doc: grammar fixes in http2.md (Rich Trott) #17972
  • [35ee8943da] - doc: add docs for common/http2.js utility (James M Snell) #17942
  • [f0ba2c6ceb] - doc: Add a missing comma (jiangq) #19555
  • [7c6fa183cb] - doc: fix typos on n-api (Kyle Robinson Young) #19385
  • [1abb168838] - doc: fix n-api asynchronous threading docs (Eric Bickle) #19073
  • [87d0fd8212] - doc: mark NAPI_AUTO_LENGTH as code (Tobias Nießen) #18697
  • [58688d97dc] - doc: fix exporting a function example (Aonghus O Nia) #18661
  • [4d43607474] - doc: fix typo in n-api.md (Vse Mozhet Byt) #18590
  • [9729278007] - doc: small typo in n-api.md (iskore) #18555
  • [7ed1dfef28] - doc: remove usage of you in n-api doc (Michael Dawson) #18528
  • [84e0a03727] - doc: remove uannecessary Require (Michael Dawson) #18184
  • [51513fdf9e] - doc: napi: make header style consistent (Ali Ijaz Sheikh) #18122
  • [02ae3295d5] - doc: napi: fix unbalanced emphasis (Ali Ijaz Sheikh) #18122
  • [79ecc2c586] - doc: updates examples to use NULL (Michael Dawson) #18008
  • [b2213798a3] - doc: fix MDN links to avoid redirections (Vse Mozhet Byt) #18631
  • [f4ddaaec0e] - doc: move Fedor to TSC Emeritus (Myles Borins) #18752
  • [b8f2acd2e8] - doc: add mmarchini to collaborators (Matheus Marchini) #18740
  • [16f9631475] - doc: add history for url.parse (Steven) #18685
  • [d30c3533ff] - doc: fix links to Style Guide and CPP Style Guide (Justin Lee) #18683
  • [176ed1e9b1] - doc: add devsnek to collaborators (Gus Caplan) #18679
  • [25db460f03] - doc: expand on promises and async_hooks (Ali Ijaz Sheikh) #18540
  • [73adadd56a] - doc: add section for strategic initiatives (Michael Dawson) #17104
  • [8ca6d34801] - doc: add introduce about cli options (Weijia Wang) #18475
  • [1ea1970c37] - doc: modify the return value of request.write() (陈刚) #18526
  • [50bdf0ed78] - doc: be more explicit in the sypnosis (Tim O. Peters) #17977
  • [f8ad381e61] - doc: add missing meta for createCipheriv (Tobias Nießen) #18651
  • [0071560eb4] - doc: fix description of createDecipheriv (Tobias Nießen) #18651
  • [c89781583b] - doc: fix various nits (Vse Mozhet Byt) #19743
  • [1091dfc801] - doc: linkify missing types (Vse Mozhet Byt) #18444
  • [1107a494e4] - doc: shell option for the execFile and execFileSync functions (jvelezpo) #18237
  • [36ea472393] - doc: improve http.request documentation (Guangcong Luo) #18289
  • [e5d5137963] - doc: streamline README intro (Rich Trott) #18483
  • [eec9334a2e] - doc: move Brian White to TSC Emeriti list (Rich Trott) #18482
  • [ac41aacb05] - doc: improve stream documentation (陈刚) #18375
  • [7feeb1574e] - doc: add Gibson Fahnestock to TSC (Rich Trott) #18481
  • [142ad8d450] - doc: reorder section on updating PR branch (Ali Ijaz Sheikh) #18355
  • [39ea4f12c5] - doc: fix manpage warnings (Roman Reiss)
  • [5209f9e1e2] - doc: warn about GCM authenticity (Tobias Nießen) #18376
  • [e84e9db6fe] - doc: capitalize non-primitive types (Vse Mozhet Byt) #18111
  • [88d4794263] - doc, http2: add sections for server.close() (Chris Miller) #19802
  • [cbc8561949] - errors: remove ERR_OUTOFMEMORY (Tobias Nießen) #17877
  • [2995506bbf] - fs: fix stack overflow in fs.readdirSync (Joyee Cheung) #18647
  • [a653f23dfc] - fs: fix createReadStream(…, {end: n}) for non-seekable fds (Anna Henningsen) #19329
  • [6bfdba125f] - http: remove default 'drain' listener on upgrade (Luigi Pinca) #18866
  • [29c395d975] - http: allow _httpMessage to be GC'ed (Luigi Pinca) #18865
  • [d2a884edf9] - http: fix parsing of binary upgrade response body (Ben Noordhuis) #17806
  • [1d88266543] - http: free the parser before emitting 'upgrade' (Luigi Pinca) #18209
  • [b54452d19e] - http2: emit session connect on next tick (Pieter Mees) #19842
  • [82b56b631d] - http2: callback valid check before closing request (Trivikram) #19061
  • [58a7fd0720] - http2: destroy() stream, upon errnoException (Sarat Addepalli) #19389
  • [91b4167ca6] - http2: remove some unnecessary next ticks (James M Snell) #19451
  • [7321dd3094] - http2: no stream destroy while its data is on the wire (Anna Henningsen) #19002
  • [9d59aa84f9] - http2: fix flaky test-http2-https-fallback (Matteo Collina) #19093
  • [dc3f6c0859] - http2: fix endless loop when writing empty string (Anna Henningsen) #18924
  • [81c08a1824] - http2: use original error for cancelling pending streams (Anna Henningsen) #18988
  • [f137c1842e] - http2: send error text in case of ALPN mismatch (Anna Henningsen) #18986
  • [cd914cab71] - http2: fix condition where data is lost (Matteo Collina) #18895
  • [b895ca90d4] - http2: use \_final instead of on('finish') (Anna Henningsen) #18609
  • [0aa7698313] - http2: add req and res options to server creation (Peter Marton) #15560
  • [58478d8307] - http2: add http fallback options to .createServer (Peter Marton) #15752
  • [ac64b4f6a7] - http2: add checks for server close callback (James M Snell) #18182
  • [8b0a1b32de] - http2: refactor read mechanism (Anna Henningsen) #18030
  • [a4d910c644] - http2: remember sent headers (James M Snell) #18045
  • [3cd205431b] - http2: use aliased buffer for perf stats, add stats (James M Snell) #18020
  • [46d1b331e0] - http2: verify flood error and unsolicited frames (James M Snell) #17969
  • [a85518ed22] - http2: verify that a dependency cycle may exist (James M Snell) #17968
  • [9c85ada4e3] - http2: implement maxSessionMemory (James M Snell) #17967
  • [9a6ea7eb02] - http2: properly handle already closed stream error (James M Snell) #17942
  • [0078a97793] - http2: add aligned padding strategy (James M Snell) #17938
  • [1c313e09d6] - http2: add initial support for originSet (James M Snell) #17935
  • [1a24feccb5] - http2: add altsvc support (James M Snell) #17917
  • [c915bc54d4] - http2: strictly limit number on concurrent streams (James M Snell) #16766
  • [dcc7f4d84c] - http2: perf_hooks integration (James M Snell) #17906
  • [72b42de33a] - http2: implement ref() and unref() on client sessions (Kelvin Jin) #17620
  • [55f6bdb698] - http2: keep session objects alive during Http2Scope (Anna Henningsen) #17863
  • [c61a54ec3d] - http2: fix compiling with --debug-http2 (Anna Henningsen) #17863
  • [04632214c1] - http2: convert Http2Settings to an AsyncWrap (James M Snell) #17763
  • [ea98fd573e] - http2: refactor outgoing write mechanism (Anna Henningsen) #17718
  • [05b823d4ad] - http2: remove redundant write indirection (Anna Henningsen) #17718
  • [fc40b7de46] - http2: cleanup Http2Stream/Http2Session destroy (James M Snell) #17406
  • [1d65f2b879] - http2: be sure to destroy the Http2Stream (James M Snell) #17406
  • [8431b4297c] - http2: only schedule write when necessary (Anna Henningsen) #17183
  • [38cfb707bd] - http2: don't call into JS from GC (Anna Henningsen) #17183
  • [a1539e5731] - http2: simplify onSelectPadding (Anna Henningsen) #17717
  • [9a4bac2081] - http2,perf_hooks: perf state using AliasedBuffer (Kyle Farnung) #18300
  • [9129bc4fde] - lib: set process.execPath on OpenBSD (Aaron Bieber) #18543
  • [2019b023a7] - lib: refactor ES module loader for readability (Anna Henningsen) #16579
  • [3df0570c90] - lib: fix spelling in comments (Tobias Nießen) #18018
  • [20844d1716] - lib: remove debugger dead code (Qingyan Li) #18426
  • [07a6770614] - n-api: add more int64\_t tests (Kyle Farnung) #19402
  • [8b3ef4660a] - n-api: back up env before finalize (Gabriel Schulhof) #19718
  • [92f699e021] - n-api: ensure in-module exceptions are propagated (Gabriel Schulhof) #19537
  • [367113f5d7] - n-api: bump version of n-api supported (Michael Dawson) #19497
  • [24b8bb6708] - n-api: re-write test_make_callback (Gabriel Schulhof) #19448
  • [3a6b7e610d] - n-api: add napi_fatal_exception (Mathias Buus) #19337
  • [9949d55ae9] - n-api: separate out async_hooks test (Gabriel Schulhof) #19392
  • [f29d8e0e8d] - n-api: add missing exception checking (Michael Dawson) #19362
  • [faf94b1c49] - n-api: resolve promise in test (Gabriel Schulhof) #19245
  • [df63adf7aa] - n-api: update documentation (Gabriel Schulhof) #19078
  • [b26410e86f] - n-api: update reference test (Gabriel Schulhof) #19086
  • [cb3f90a1a9] - n-api: fix object test (Gabriel Schulhof) #19039
  • [9244e1d234] - n-api: remove extra reference from test (Gabriel Schulhof) #18542
  • [927fc0b19f] - n-api: add methods to open/close callback scope (Michael Dawson) #18089
  • [969a520990] - n-api: wrap control flow macro in do/while (Ben Noordhuis) #18532
  • [d89f5937eb] - n-api: implement wrapping using private properties (Gabriel Schulhof) #18311
  • [af655f586c] - n-api: change assert ok check to notStrictEqual. (Aaron Kau) #18414
  • [ca10fda064] - n-api: throw RangeError napi_create_typedarray() (Jinho Bang) #18037
  • [853b4d593c] - n-api: expose n-api version in process.versions (Michael Dawson) #18067
  • [48be8a4793] - n-api: throw RangeError in napi_create_dataview() with invalid range (Jinho Bang) #17869
  • [a744535f99] - n-api: fix memory leak in napi_async_destroy() (alnyan) #17714
  • [584fadc605] - n-api,test: add int64 bounds tests (Kyle Farnung) #19309
  • [4c1181dc02] - n-api,test: add a new.target test to addons-napi (Taylor Woll) #19236
  • [3225601ffc] - net: remove Socket.prototoype.read (Anna Henningsen) #18568
  • [35aaee1059] - net: remove redundant code from _writeGeneric() (Luigi Pinca) #18429
  • [54442efcd2] - perf_hooks: refactor internals (James M Snell) #17822
  • [6bdfb1f8f0] - perf_hooks,http2: add performance.clear() (James M Snell) #18046
  • [1faae90b74] - readline: use Date.now() and move test to parallel (Anatoli Papirovski) #18563
  • [965b56a34e] - readline: update references to archived repository (Tobias Nießen) #17924
  • [5dda33fda3] - src: add nullptr check for session in DEBUG macro (Daniel Bevenius) #18815
  • [4e807d648e] - src: introduce internal buffer slice constructor (Anna Henningsen) #18030
  • [0b828e5125] - src: remove declarations for missing functions (Anna Henningsen) #18134
  • [3766e04f31] - src: silence http2 -Wunused-result warnings (cjihrig) #17954
  • [2b7732788a] - src: add optional keep-alive object to SetImmediate (Anna Henningsen) #17183
  • [f3e082c4ea] - src: replace SetAccessor w/ SetAccessorProperty (Jure Triglav) #17665
  • [45e28a8628] - src: minor refactoring to StreamBase writes (Anna Henningsen) #17564
  • [42b4f3ce0b] - src: fix abort when taking a heap snapshot (Ben Noordhuis) #18898
  • [b48ca0a140] - src: fix crypto.pbkdf2 callback error argument (BufoViridis) #18458
  • [973488b77b] - src: replace var for let / const. (alejandro estrada) #18649
  • [9ac91b14de] - src: fix util abort (Ruben Bridgewater) #19224
  • [c0f40be23b] - src: free memory before re-setting URLHost value (Ivan Filenko) #18357
  • [5e4f9b37ba] - src,doc,test: Fix common misspellings (Roman Reiss) #18151
  • [10231a9e44] - stream: cleanup() when unpiping all streams. (陈刚) #18266
  • [bf523822ba] - stream: simplify src.\_readableState to state (陈刚) #18264
  • [37e594ed4a] - stream: remove unreachable code (Luigi Pinca) #18239
  • [f96b0bf494] - string_decoder: reset decoder on end (Justin Ridgewell) #18494
  • [42778c3791] - test: http2 errors on req.close() (Trivikram) #18854
  • [a77d3fad97] - test: http2 stream.respond() error checks (Trivikram) #18861
  • [bac93443d2] - test: check endless loop while writing empty string (XadillaX) #18924
  • [7eba62e028] - test: make test-tls-external-accessor agnostic (Rich Trott) #16272
  • [9e68947ff4] - test: add hasCrypto when using binding('crypto') (Daniel Bevenius) #17867
  • [6129ff4b99] - test: remove unnecessary timer (cjihrig) #18719
  • [2838f9b150] - test: convert new tests to use error types (Jack Horton) #18581
  • [5c0983e5a2] - test: improve error message output (Bhavani Shankar) #18498
  • [bebcdfe382] - test: show pending exception error in napi tests (Ben Wilcox) #18413
  • [5b1b74c5a5] - test: refactor addons-napi/test_exception/test.js (Rich Trott) #18340
  • [8cfa87832d] - test: fixed typos in napi test (furstenheim) #18148
  • [ad8c079af7] - test: remove ambiguous error messages from test_error (Nicholas Drane) #17812
  • [2e100c82be] - test: remove literals that obscure assert messages (Rich Trott) #17642
  • [077e1870ae] - test: add unhandled rejection guard (babygoat) #17275
  • [9236332cc3] - test: update a few tests to work on OpenBSD (Aaron Bieber) #18543
  • [cbd698a521] - test: refactor test-http-abort-before-end (cjihrig) #18508
  • [ab8edc9d48] - test: fix flaky timers-block-eventloop test (Anatoli Papirovski) #18567
  • [53b702fdba] - test: remove common.PORT from parallel tests (Rich Trott) #17410
  • [da162278de] - test: mock the lookup function in parallel tests (Joyee Cheung) #17296
  • [34af49401b] - test: add common.dns.errorLookupMock (Joyee Cheung) #17296
  • [bff7258535] - test: do not check TXT content in test-dns-any (Joyee Cheung) #18547
  • [daeb6de8ec] - test: use internet.addresses in internet tests (Joyee Cheung) #16390
  • [7813a0de0a] - test: introduce test/common/internet.addresses (Joyee Cheung) #16390
  • [745600a0b3] - test: remove orphaned entries from status (Kyle Farnung) #18092
  • [e42ab10957] - test: add assertions for TextEncoder/Decoder (Sho Miyamoto) #18132
  • [a1b0d5da07] - test: move tmpdir to submodule of common (Rich Trott) #17856
  • [5155d8e7c3] - test: update references to archived repository (Tobias Nießen) #17924
  • [1043b6fd7c] - test: fix spelling in test case comments (Tobias Nießen) #18018
  • [fdb4dbc04b] - test: remove destructor from node_test_fixture (Daniel Bevenius) #18524
  • [e55e08c80e] - test: verify the shell option works properly on execFile (jvelezpo) #18384
  • [0cf9d0483f] - test: add test for tls benchmarks (Anatoli Papirovski) #18489
  • [d630874250] - test: speed up parallel/test-tls-session-cache (Anna Henningsen) #18424
  • [a1fb263880] - test: fix flaky test-http-dns-error (Bryan English) #16534
  • [6f3fb46541] - test: use correct size in test-stream-buffer-list (Luigi Pinca) #18239
  • [be3c8aad59] - timers: fix a bug in error handling (Anatoli Papirovski) #20497
  • [e15f57745d] - timers: allow Immediates to be unrefed (Anatoli Papirovski) #18139
  • [95c1e2d606] - tls: set servername on client side too (James M Snell) #17935
  • [d4bccccf23] - tools: add fixer for prefer-assert-iferror.js (Shobhit Chittora) #16648
  • [016a28ac08] - tools: non-Ascii linter for /lib only (Sarat Addepalli) #18043
  • [a0a45fc3b6] - tools: add .mjs linting for Windows (Vse Mozhet Byt) #18569
  • [e0d2842b29] - tools: add check for using process.binding crypto (Daniel Bevenius) #17867
  • [a8b5a96d15] - tools: auto fix custom eslint rule (Shobhit Chittora) #16652
  • [5d03c8219a] - url: simplify loop in parser (Tobias Nießen) #18468
  • [e0e0ef7bab] - util: escaping object keys in util.inspect() (buji) #16986
  • [8ac69c457b] - v8: add missing ',' in OpenBSD's 'sources' section. (Aaron Bieber) #18448
  • [c61754fad9] - win, build: fix intl-none option (Birunthan Mohanathas) #18292

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

benjamn, appigram, sebakerckhof, and smeijer reacted with hooray emoji
All reactions
  • 🎉 4 reactions
TimothyGu and others added 30 commits March 29, 2018 23:28
@TimothyGu @MylesBorins
benchmark: fix punycode test for --without-intl
18be476
PR-URL: #16251
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax @MylesBorins
fs: fix createReadStream(…, {end: n}) for non-seekable fds
a653f23
82bdf8f fixed an issue by silently modifying the `start`
option for the case when only `end` is passed, in order to perform
reads from a specified range in the file.

However, that approach does not work for non-seekable files, since
a numeric `start` option means that positioned reads will be used
to read data from the file.

This patch fixes that, and instead ends reading after a specified
size by adjusting the read buffer size.

This way we avoid re-introducing the bug that 82bdf8f fixed,
and align behaviour with the native file stream mechanism
introduced in #18936 as well.

Backport-PR-URL: #19410
PR-URL: #19329
Fixes: #19240
Refs: #18121
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chen Gang <[email protected]>
@ah-yu @MylesBorins
util: escaping object keys in util.inspect()
e0e0ef7
PR-URL: #16986
Fixes: #16979
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@lpinca @MylesBorins
http: free the parser before emitting 'upgrade'
1d88266
Ensure that the parser is freed before emitting the 'connect' or
'upgrade' event.

PR-URL: #18209
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@lpinca @MylesBorins
stream: remove unreachable code
37e594e
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

PR-URL: #18239
Reviewed-By: Matteo Collina <[email protected]>
@lpinca @MylesBorins
test: use correct size in test-stream-buffer-list
6f3fb46
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

PR-URL: #18239
Reviewed-By: Matteo Collina <[email protected]>
陈刚 @MylesBorins
stream: simplify src._readableState to state
bf52382
PR-URL: #18264
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
e84e9db
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@tniessen @MylesBorins
doc: warn about GCM authenticity
5209f9e
PR-URL: #18376
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@silverwind @MylesBorins
doc: fix manpage warnings
39ea4f1
Fixes: #18434
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ofrobots @MylesBorins
doc: reorder section on updating PR branch
142ad8d
It makes more sense to provide instructions on how to update the PR
branch before instructions on pushing the commit.

PR-URL: #18355
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@tniessen @MylesBorins
url: simplify loop in parser
5d03c82
PR-URL: #18468
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott @MylesBorins
doc: add Gibson Fahnestock to TSC
7feeb15
Welcome Gibson to the TSC!

PR-URL: #18481
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@bengl @MylesBorins
test: fix flaky test-http-dns-error
a1fb263
Under some conditions, the error received from getaddrinfo might
actually be EAGAIN, meaning the request should be retried. Allowing for
5 retries before erroring out.

Also replace one-off function with common.mustNotCall().

PR-URL: #16534
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@prog1dev @MylesBorins
src: free memory before re-setting URLHost value
c0f40be
Fixes: #18302

PR-URL: #18357
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@shobhitchittora @MylesBorins
tools: auto fix custom eslint rule
a8b5a96
1. Extends tests
2. Refactors code
3. Adds fixer

Refs: #16636

PR-URL: #16652
Refs: #16636
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
陈刚 @MylesBorins
doc: improve stream documentation
ac41aac
PR-URL: #18375
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax @MylesBorins
test: speed up parallel/test-tls-session-cache
d630874
This test had some unnecessary timeouts that made it run for a
much longer time than necessary (about 9 s rather than 0.2 s).

PR-URL: #18424
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@liqyan @MylesBorins
lib: remove debugger dead code
20844d1
PR-URL: #18426
Refs: 719247f
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Jan Krems @MylesBorins
deps: update node-inspect to 1.11.3
79a7a17
Highlights:

* Using a random port works (`node inspect --port=0 script.js`)
* `takeHeapSnapshot()` creates valid snapshots again

PR-URL: #18354
Reviewed-By: Richard Lau <[email protected]>
@ofrobots @MylesBorins
async_hooks: clean up comments
ce3866b
With some of the recent work, some of the comments were no longer
representative of the code, or were otherwise unclear. This commit
fixes some obvious issues I found.

Ref: 83e5215
Ref: 0784b04
PR-URL: #18467
Reviewed-By: Andreas Madsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott @MylesBorins
doc: move Brian White to TSC Emeriti list
eec9334
PR-URL: #18482
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@qbit @MylesBorins
v8: add missing ',' in OpenBSD's 'sources' section.
8ac69c4
Add stack_trace_posix to 'sources' as well.

Fixes #15784
Fixes nodejs/help#992

add stack_trace_posix to OpenBSD's sources

PR-URL: #18448
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@qbit @MylesBorins
build: add cflags for OpenBSD, remove stray comma.
424703a
PR-URL: #18448
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott @MylesBorins
doc: streamline README intro
e5d5137
Shorten text that is duplicated from website and supply link.

PR-URL: #18483
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jridgewell @MylesBorins
string_decoder: reset decoder on end
f96b0bf
This resets the StringDecoder's state after calling `#end`. Further
writes to the decoder will act as if it were a brand new instance,
allowing simple reuse.

PR-URL: #18494
Fixes: #16564
Refs: #16594
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@apapirovski @MylesBorins
test: add test for tls benchmarks
0cf9d04
PR-URL: #18489
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jvelezpo @MylesBorins
test: verify the shell option works properly on execFile
e55e08c
Useful for executing in a shell because it accepts arguments as
an array instead of a string as exec does.
Depending on the circumstances,
that can prove to be useful if the arguments are already prepared.

PR-URL: #18384
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@poiru @MylesBorins
win, build: fix intl-none option
c61754f
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
@Zarel @MylesBorins
doc: improve http.request documentation
36ea472
PR-URL: #18289
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
trivikr and others added 10 commits May 15, 2018 14:01
@trivikr @MylesBorins
test: http2 stream.respond() error checks
83d8ad3
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18861
Reviewed-By: James M Snell <[email protected]>
Sarat Addepalli @MylesBorins
http2: destroy() stream, upon errnoException
eddf3a6
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@vsemozhetbyt @MylesBorins
doc: guard against md list parsing edge case
1ff3544
Backport-PR-URL: #20456
PR-URL: #19647
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Chen Gang <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@trivikr @MylesBorins
test: http2 errors on req.close()
4dbdb8a
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@trivikr @MylesBorins
http2: callback valid check before closing request
6d6e2e2
Do not close the request if callback is not a function, and
throw ERR_INVALID_CALLBACK TypeError

Backport-PR-URL: #19229
Backport-PR-URL: #20456
PR-URL: #19061
Fixes: #18855
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@chrismilleruk @MylesBorins
doc, http2: add sections for server.close()
84fa6eb
Clarify current behavior of http2server.close() and
http2secureServer.close() w.r.t. perceived differences
when compared with httpServer.close().

Fixes: #19711

Backport-PR-URL: #20456
PR-URL: #19802
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@pietermees @MylesBorins
doc: add Http2Session.connecting property
165d214
Backport-PR-URL: #20456
PR-URL: #19842
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@pietermees @MylesBorins
http2: emit session connect on next tick
1455b1d
Backport-PR-URL: #20456
PR-URL: #19842
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@apapirovski @MylesBorins
timers: fix a bug in error handling
a52f15e
When a timeout within a list of timeouts (that consists of only
that specific timeout) throws during its execution, it's possible
for the TimerWrap handle to become shared between both that list
and an unref'd timeout created in the future. This fixes the bug
by extending error handling in timeout execution to check for
whether the current list is empty and if so do cleanup on it.

PR-URL: #20497
Fixes: #19970
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
@rvagg @MylesBorins
build,win: restore vcbuild TAG functionality
ab4809f
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: #17299
Ref: nodejs/abi-stable-node#289

PR-URL: #18031
Ref: #17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
@benjamn

benjamn commented May 15, 2018

Copy link
Copy Markdown

@MylesBorins Great! If everything works out, is this version going to be 8.11.2-rc.2, or 8.11.2?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
2018-05-15, Version 8.11.2 'Carbon' (LTS)
faf417b
Notable Changes:

deps:
  - update node-inspect to 1.11.3 (Jan Krems)
    #18354
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
http2:
  - Sync with current release stream
n-api:
  - Sync with current release stream

PR-URL: #20478
@MylesBorins
MylesBorins force-pushed the v8.11.2-proposal branch from d747bc4 to faf417b Compare May 15, 2018 18:48
@MylesBorins

MylesBorins commented May 15, 2018

Copy link
Copy Markdown
Contributor Author

Broke a thing... fixed it... one more CI

CI: https://ci.nodejs.org/job/node-test-pull-request/14892/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1411/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins

MylesBorins commented May 15, 2018

Copy link
Copy Markdown
Contributor Author

@benjamn v8.11.2 will be going out later today

benjamn, Koslun, and smeijer reacted with hooray emoji
All reactions
  • 🎉 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
MylesBorins merged commit faf417b into v8.x May 15, 2018
MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
Working on v8.11.3
e00e36f
PR-URL: #20478
MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
2018-05-15, Version 8.11.2 'Carbon' (LTS)
2e7ea6e
Notable Changes:

deps:
  - update node-inspect to 1.11.3 (Jan Krems)
    #18354
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
http2:
  - Sync with current release stream
n-api:
  - Sync with current release stream

PR-URL: #20478
@MylesBorins MylesBorins mentioned this pull request May 15, 2018
blog: v8.11.2 release post nodejs/nodejs.org#1655
Merged
@MylesBorins
MylesBorins deleted the v8.11.2-proposal branch May 22, 2018 14:56
@apapirovski apapirovski mentioned this pull request Jun 1, 2018
parallel/test-benchmark-misc failure on v8.x-staging #19394
Closed
This was referenced Jun 14, 2018
[Atom-1.28.0-beta1][OSX] Mocha tests fail in headless mode, but not in headed mode atom/atom#17409
Closed
src: replace SetAccessor w/ SetAccessorProperty electron/node#38
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. http2 Issues and PRs related to the http2 subsystem. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

19 participants

@MylesBorins @addaleax @kjin @benjamn @joaocgreis @nodejs-github-bot @TimothyGu @ah-yu @lpinca @vsemozhetbyt @tniessen @silverwind @ofrobots @Trott @bengl @prog1dev @shobhitchittora @liqyan @qbit
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.