GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add devsnek to collaborators by devsnek · Pull Request #18679 · nodejs/node

Conversation

@devsnek

@devsnek devsnek commented Feb 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes: #18544

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt and ChALkeR reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@devsnek
doc: add devsnek to collaborators
b41261c
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 9, 2018
joyeecheung
joyeecheung approved these changes Feb 9, 2018
View reviewed changes
apapirovski
apapirovski approved these changes Feb 9, 2018
View reviewed changes

@apapirovski apapirovski left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Maybe add "Closes: #18544"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@devsnek

devsnek commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

ci: https://ci.nodejs.org/job/node-test-pull-request/13059/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek devsnek added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 9, 2018
BridgeAR
BridgeAR approved these changes Feb 9, 2018
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
addaleax
addaleax approved these changes Feb 9, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Feb 9, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt approved these changes Feb 9, 2018
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Feb 9, 2018
View reviewed changes
@devsnek

devsnek commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

landed in eacc88c
joyeecheung reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek devsnek closed this Feb 9, 2018
devsnek added a commit that referenced this pull request Feb 9, 2018
@devsnek
doc: add devsnek to collaborators
eacc88c 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@devsnek
devsnek deleted the meta/devsnek-collab branch February 9, 2018 15:26
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 9, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@devsnek @MylesBorins
doc: add devsnek to collaborators
557ec07 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@devsnek @MylesBorins
doc: add devsnek to collaborators
2369401 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@devsnek @MylesBorins
doc: add devsnek to collaborators
ec1e3b2 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
v9.6.0 proposal #18902
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@devsnek @MylesBorins
doc: add devsnek to collaborators
af977db 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@devsnek @gibfahn
doc: add devsnek to collaborators
29b0d3b 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@devsnek @gibfahn
doc: add devsnek to collaborators
176ed1e 
PR-URL: #18679
Fixes: #18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@gibfahn gibfahn added land-on-v6.x labels Apr 13, 2018
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
v6.14.2 proposal #19996
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
v8.11.2 proposal #20478
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@devsnek @MayaLekova
doc: add devsnek to collaborators
2f5ee32 
PR-URL: nodejs#18679
Fixes: nodejs#18544
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+2 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collaborator nomination: @devsnek

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@devsnek @apapirovski @addaleax @cjihrig @joyeecheung @gireeshpunathil @BridgeAR @vsemozhetbyt @Trott @gibfahn @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.