GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fully document --experimental-repl-await by TimothyGu · Pull Request #20133 · nodejs/node

Conversation

@TimothyGu

@TimothyGu TimothyGu commented Apr 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #19604 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TimothyGu
doc: fully document --experimental-repl-await
84e989b
@TimothyGu
TimothyGu requested a review from vsemozhetbyt April 18, 2018 15:52
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 18, 2018
@TimothyGu TimothyGu mentioned this pull request Apr 18, 2018
repl: hide top-level await feature behind a flag #19604
Closed
3 tasks done
@vsemozhetbyt vsemozhetbyt added the repl Issues and PRs related to the REPL subsystem. label Apr 18, 2018
richardlau
richardlau approved these changes Apr 18, 2018
View reviewed changes
@TimothyGu TimothyGu added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 18, 2018
@TimothyGu

TimothyGu commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

I'd like to fast track this. Please 👍-react if you agree!
vsemozhetbyt, richardlau, and devsnek reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt approved these changes Apr 18, 2018
View reviewed changes
@vsemozhetbyt

vsemozhetbyt commented Apr 18, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/547/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 18, 2018
@vsemozhetbyt

vsemozhetbyt commented Apr 18, 2018

Copy link
Copy Markdown
Contributor

This should be backported with #19604
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devsnek
devsnek approved these changes Apr 18, 2018
View reviewed changes
ryzokuken
ryzokuken approved these changes Apr 18, 2018
View reviewed changes
trivikr
trivikr approved these changes Apr 18, 2018
View reviewed changes
jasnell
jasnell approved these changes Apr 18, 2018
View reviewed changes
@TimothyGu

TimothyGu commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

Landed in ceab78f.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimothyGu TimothyGu closed this Apr 18, 2018
TimothyGu added a commit that referenced this pull request Apr 18, 2018
@TimothyGu
doc: fully document --experimental-repl-await
ceab78f 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@TimothyGu
TimothyGu deleted the repl-doc branch April 18, 2018 21:13
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@TimothyGu @jasnell
doc: fully document --experimental-repl-await
56d6e82 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes
+3 more reviewers
@devsnek devsnek devsnek approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
@ryzokuken ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@TimothyGu @vsemozhetbyt @jasnell @richardlau @devsnek @ryzokuken @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.