GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: reach res._dump after abort ClientRequest by tadhgcreedon · Pull Request #24191 · nodejs/node

Conversation

@tadhgcreedon

@tadhgcreedon tadhgcreedon commented Nov 6, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds test coverage to lib/_http_client.js by reaching a line of code inside a callback that gets registered on the 'response' event after aborting a client request, by emitting that event.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 6, 2018
@addaleax addaleax added http Issues and PRs related to the http subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2018
@tadhgcreedon
tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 73a1820 to 4359904 Compare November 7, 2018 10:33
@addaleax

addaleax commented Nov 10, 2018

Copy link
Copy Markdown
Member

@tadhgcreedon I’m not sure, but would it maybe make sense to test both cases here, e.g. by creating a new test file rather than modifying an existing one? I think this might be affecting the previous functionality of the test…

(/cc @nodejs/http)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Nov 10, 2018

Copy link
Copy Markdown
Member

Yeah, a separate new test file may be better
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tadhgcreedon

tadhgcreedon commented Nov 11, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Sure, makes sense. Will create a new test file then update.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tadhgcreedon
tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 3179181 to 1a544be Compare November 11, 2018 12:50
oyyd
oyyd approved these changes Nov 13, 2018
View reviewed changes
@oyyd

oyyd commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18572/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr

trivikr commented Nov 13, 2018

Copy link
Copy Markdown
Member

Hi @tadhgcreedon, the author of the commits in this PR is not registered on GitHub (steps defined here)

Either:

  • add the email ID associated with the commit to GitHub
  • change the author of the commit to current email ID registered with the GitHub by following these steps
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tadhgcreedon added 2 commits November 13, 2018 12:22
@tadhgcreedon
test: reach res._dump after abort ClientRequest
e3282ba
@tadhgcreedon
move changes to new test file
c37a91d
@tadhgcreedon
tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 1a544be to c37a91d Compare November 13, 2018 17:23
@Trott

Trott commented Nov 14, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18594/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oyyd

oyyd commented Nov 14, 2018

Copy link
Copy Markdown
Contributor

Resume: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22295/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 14, 2018

Copy link
Copy Markdown
Member

@addaleax LGTY?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thefourtheye
thefourtheye reviewed Nov 20, 2018
View reviewed changes
Comment thread test/parallel/test-http-client-abort-response-event.js Outdated

req.end();
req.abort();
req.abort();

@thefourtheye thefourtheye Nov 20, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havn't checked this completely, but two req.aborts are intentional?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Nov 22, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @tadhgcreedon Two abort() calls like that are intentional? If so, great. If not, can you remove one? Or I can totally remove one. Either way. I just want to see this get merged....

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
fixup! remove extra .abort() call
d8631d0
@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18987/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 28, 2018
View reviewed changes
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19013/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@tadhgcreedon @Trott
test: reach res._dump after abort ClientRequest
f5b8853 
PR-URL: nodejs#24191
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Landed in f5b8853.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 29, 2018
targos pushed a commit that referenced this pull request Nov 29, 2018
@tadhgcreedon @targos
test: reach res._dump after abort ClientRequest
e96c60e 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
This was referenced Dec 8, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@tadhgcreedon @refack
test: reach res._dump after abort ClientRequest
4e20fbf 
PR-URL: nodejs#24191
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@tadhgcreedon @BethGriggs
test: reach res._dump after abort ClientRequest
06208c8 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@tadhgcreedon @rvagg
test: reach res._dump after abort ClientRequest
a06d19f 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
+2 more reviewers
@thefourtheye thefourtheye thefourtheye left review comments
@oyyd oyyd oyyd approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues and PRs related to the http subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@tadhgcreedon @addaleax @jasnell @oyyd @trivikr @Trott @thefourtheye @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.