GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v10.15.3 proposal by BethGriggs · Pull Request #26063 · nodejs/node

Conversation

BethGriggs commented Feb 12, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

2019-03-05, Version 10.15.3 'Dubnium' (LTS), @BethGriggs

Notable Changes

doc
- add antsmartian to collaborators (Anto Aravinth) #24655
http
- fix error check in Execute() (Brian White) #25863
stream
- fix end-of-stream for HTTP/2 (Anna Henningsen) #24926

Commits

[732088dd44] - assert: fix loose deepEqual map comparison (Ruben Bridgewater) #24749
[5a81a4f6cd] - assert,util: fix sparse array comparison (Ruben Bridgewater) #24749
[bd08ede3ab] - buffer: remove checkNumberType() (cjihrig) #24815
[fde56fa748] - build: make lint-addon-docs run only if needed (Daniel Bevenius) #24993
[8d4d3963e0] - build: fix compiler version detection (Richard Lau) #24879
[552a5c080a] - build: add '.git' to 'make lint-py' exclude list (cclauss) #24802
[02e9a93d2c] - build: fix check-xz for platforms defaulting to sh (Rod Vagg) #24841
[920cab76cf] - build: make tar.xz creation opt-out, fail if no xz (Rod Vagg) #24551
[b72bc11a93] - build: fix line length off by one error (Ruben Bridgewater) #24748
[18d81c94a6] - build: add line break as soon tests are done (Ruben Bridgewater) #24748
[c57008e549] - build: fix c++ code coverage on macOS (Refael Ackermann) #24520
[95a3b3e142] - build: replace -not with ! in find (Rich Trott) #24635
[32d93cde01] - build, tools, win: add .S files support to GYP (Bartosz Sosnowski) #24553
[a2155e1010] - crypto: harden bignum-to-binary conversions (Ben Noordhuis) #24719
[6f4e30d029] - crypto: convert to arrow function (yosuke ota) #24597
[3b9fd0881a] - deps: V8: cherry-pick 3cc6919 (milad) #25872
[70322ea2ca] - deps: V8: cherry-pick d0468de (Milad Farazmand) #25827
[c9a3e401da] - deps: cherry-pick d9fbfeb from upstream V8 (Alexey Kozyatinskiy) #25330
[e20e3472a4] - deps: V8: backport 442977e (Ali Ijaz Sheikh) #25242
[8af4f44130] - dns: simplify dns.promises warning logic (cjihrig) #24788
[cfd5773f8d] - doc: document fs.write limitation with TTY (Matteo Collina) #24571
[89ba5f41c8] - doc: revise "Breaking Changes" section of Collaborator Guide (Rich Trott) #25071
[7382e8f648] - doc: fix node.1 --http-parser sort order (cjihrig) #25045
[66e6c2a88b] - doc: add EventTarget link to worker_threads (Azard) #25058
[d1f19a033c] - doc: make README formatting more consistent (wenjun ye) #25003
[1880f23ed2] - doc: add codebytere's info to release team (Shelley Vohr) #25022
[8f434414a4] - doc: revise internal vs. public API in Collaborator Guide (Rich Trott) #24975
[8ae649d105] - doc: update a link of npm repository (Daijiro Wachi) #24969
[9ffa8270b1] - doc: fix author-ready conflict (Ruben Bridgewater) #25015
[bdf21c1f10] - doc: update Useful CI Jobs section of Collaborator Guide (Rich Trott) #24916
[f8ac170608] - doc: add class worker documentation (yoshimoto koki) #24849
[f68ff0619c] - doc: remove bad link to irc info (Richard Lau) #24967
[0701559336] - doc: simplify author ready (Ruben Bridgewater) #24893
[e7e8a25bb8] - doc: update "Testing and CI" in Collaborator Guide (Rich Trott) #24884
[a7f36dde00] - doc: update http doc for new Agent()/support options in socket.connect() (Beni von Cheni) #24846
[e9ad526297] - doc: fix order of events when request is aborted (Luigi Pinca) #24779
[189d2e2ab2] - doc: revise Waiting for Approvals documentation (Rich Trott) #24845
[f2df92cfc0] - doc: list all versions WHATWG URL api was added (Thomas Watson) #24847
[2b03878de3] - doc: add authority and scheme psuedo headers (Kenigbolo Meya Stephen) #24777
[23cd76e9ef] - doc: add triaging section to releases.md (Beth Griggs) #20165
[f52ff588e2] - doc: use author's titles for linked resources (Rich Trott) #24837
[0a3c88551a] - doc: revise code review guidelines (Rich Trott) #24790
[7bd7328f0d] - doc: add a note on usage scope of AliasedBuffer (Gireesh Punathil) #24724
[184425e7e8] - doc: hide undocumented object artifacts in async_hooks (Gireesh Punathil) #24741
[ad40e781af] - doc: fix added version of randomFill+randomFillSync (Thomas Watson) #24812
[56916c8430] - doc: streamline Accepting Modifications in Collaborator Guide (Rich Trott) #24807
[7ae17573e6] - doc: make release README link be consistent with text (ZYSzys) #24783
[1c593c8192] - doc: cookie is joined using '; ' (Gerhard Stoebich) #24740
[3e4b93ac8e] - doc: add antsmartian to collaborators (Anto Aravinth) #24655
[fe698d8ca0] - doc: revise accepting-modifications in guide (Rich Trott) #24650
[546f9419d7] - doc: clarify symlink resolution for __filename (Rich Trott) #24587
[a1a393bfbf] - doc: use arrow function for anonymous callbacks (koki-oshima) #24606
[6788d856d5] - doc: revise handling-own-pull-requests text (Rich Trott) #24583
[bda73542be] - doc: fix duplicate "this" and "the" on http2.md (Yusuke Kawasaki) #24611
[73b99c7013] - doc: replace anonymous function with arrow function (ka2jun8) #24617
[1eeb37c39c] - doc: use arrow function (sadness_ojisan) #24590
[283172771e] - doc: replace anonymous function with arrow function (yuriettys) #24627
[dd5bfd7f74] - doc: mark napi_add_finalizer experimental (Michael Dawson) #24572
[dacdd0113f] - esm: refactor dynamic modules (Myles Borins) #24560
[576d9c513a] - fs: simplify fs.promises warning logic (cjihrig) #24788
[741c5ef6cd] - http: fix error check in Execute() (Brian White) #25863
[f4aed8c3df] - http2: make compat writeHead not crash if the stream is destroyed (Matteo Collina) #24723
[d12c5a7a75] - http2: add compat support for nested array headers (Sebastiaan Deckers) #24665
[c7f876be38] - http2: fix session[kSession] undefined issue (leeight) #24547
[e8dfdc063d] - lib: ensure readable stream flows to end (Mikko Rantanen) #24918
[d5d8670783] - lib: remove some useless assignments (Gus Caplan) #23199
[96036ef798] - lib: do not register DOMException in a module (Joyee Cheung) #24708
[ef68349617] - lib: move setupAllowedFlags() into per_thread.js (Joyee Cheung) #24704
[1b48c9d9e3] - lib: convert to arrow function in fs.js (exoego) #24604
[eaa5e3efa4] - lib: change callbacks to arrow function (/Jesse) #24625
[4eec736a5e] - lib: chenged anonymous function to arrow function (nakashima) #24605
[8c93bd4d17] - lib: rearm pre-existing signal event registrations (Gireesh Punathil) #24651
[8f427eb987] - lib: convert to arrow function (horihiro) #24623
[e5abfe191e] - lib: convert to Arrow Function (Daiki Arai) #24615
[ccefef2d45] - lib: suppress crypto related env vars in help msg (Daniel Bevenius) #24556
[1c2ce239a1] - lib: convert to arrow function (Naojirou Hisada) #24596
[c87af34886] - lib: change anonymous function to arrow function (takato) #24589
[ce2aa807f5] - lib: simplify own keys retrieval (Vse Mozhet Byt) #24582
[9daf175483] - lib: fix nits in lib/internal/bootstrap/cache.js (Vse Mozhet Byt) #24581
[f2287c61e1] - module: use validateString in modules/esm (ZYSzys) #24868
[229f901a0f] - module: use validateString in modules/cjs (ZYSzys) #24863
[fe0e119f55] - n-api: handle reference delete before finalize (Michael Dawson) #24494
[760277e490] - n-api,test: remove last argument in assert.strictEqual() (susantruong) #24584
[f6e07fd809] - net: use strict comparisons for fd (cjihrig) #25014
[7eda47e5c9] - path: replace assertPath() with validator (cjihrig) #24840
[33a907de20] - perf_hooks: make GC tracking state per-Environment (Anna Henningsen) #25053
[931a04e37e] - process: fix omitting -- from process.execArgv (Anna Henningsen) #24654
[a4068d9827] - process: properly close file descriptor on exit (Ruben Bridgewater) #24972
[fd8a481a12] - process: simplify check in previousValueIsValid() (cjihrig) #24836
[5bca4c7cc0] - process: emit unhandled warning immediately (Anatoli Papirovski) #24632
[944e75d10b] - src: emit 'params' instead of 'data' for NodeTracing.dataCollected (Kelvin Jin) #24949
[1cc5834180] - src: add GetLoadedLibraries routine (Gireesh Punathil) #24825
[fa84e91813] - src: create env->inspector_console_api_object earlier (Joyee Cheung) #24906
[12f0485c8c] - src: remove use of CallOnForegroundThread() (cjihrig) #24925
[16a1f96d6e] - src: do not alias new and old signal masks (Sam Roberts) #24810
[f0e7b2f509] - src: fix warning for potential snprintf truncation (Sam Roberts) #24810
[7455597815] - src: remove finalized_ member from Hash class (Daniel Bevenius) #24822
[37047fc70a] - src: use arraysize instead of hardcode number (leeight) #24473
[eb20e3d23e] - src: set HAS_USERNAME/PASSWORD more strictly (Timothy Gu) #24495
[4444cdb6cd] - src: elevate v8 namespaces referenced (Juan José Arboleda) #24657
[28a1cc1377] - src: simplify uptime and ppid return values (cjihrig) #24562
[8c48302a50] - src: elevate v8 namespaces for node_url.cc (Jayasankar) #24573
[863d1987a3] - src: elevate v8 namespaces of node_trace_events.cc (Jayasankar) #24469
[26f7edbf71] - src: re-sort the symbol macros (Sam Roberts) #24382
[450bcde462] - src: use v8:: for consistency in util (ZYSzys) #23934
[3f969d61ff] - stream: re-use existing once() implementation (Anna Henningsen) #24991
[bb8a65dd84] - stream: fix end-of-stream for HTTP/2 (Anna Henningsen) #24926
[e356ce851f] - stream: make async iterator .next() always resolve (Matteo Collina) #24668
[e338e50213] - stream: use arrow function for callback (DoiChris) #24609
[6be2d6187c] - test: improve comparison coverage to 100% (Ruben Bridgewater) #24749
[1d083e29e5] - test: test internal/util/types in vm (ZYSzys) #25056
[56c6686fe5] - test: merge test with unnecessary child process (Sam Roberts) #25025
[ee054110b5] - test: remove unnecessary linter comment (cjihrig) #25013
[c9b0a36989] - test: use global.gc() instead of gc() (cjihrig) #25012
[bcfc1d1a7d] - test: run eslint on test file and fix errors (Ruben Bridgewater) #25009
[17527981d0] - test: remove dead code (Ruben Bridgewater) #25009
[48c54137d4] - test: use blocks instead of async IIFE (Anna Henningsen) #24989
[54d7e82530] - test: adding history regression test case (Anto Aravinth) #24843
[dd2b553874] - test: mark test-child-process-execfile flaky (Rich Trott) #25051
[bfa396a81e] - test: mark test-child-process-exit-code flaky (Rich Trott) #25050
[55680e3ecb] - test: mark test-worker-memory flaky on Windows CI (Rich Trott) #25042
[89b6d1b1fa] - test: mark test-child-process-execsync flaky on AIX (Rich Trott) #25031
[11d5c07c7d] - test: refactor test-enable-in-init (Mitch Hankins) #24976
[0658424227] - test: from functools import reduce in test/testpy/__init__.py (cclauss) #24954
[3bdff05cdb] - test: improve internet/test-dns (Ilarion Halushka) #24927
[3f2c6ce9aa] - test: replace callback with arrows (Shubham Urkade) #24866
[2869b7810d] - test: mark test-cli-syntax as flaky/unreliable (Rich Trott) #24957
[83c6f0a86e] - test: do not lint macros files (again) (cclauss) #24886
[a67d37d226] - test: prepare test/pseudo-tty/testcfg.py Python 3 (cclauss) #24887
[4e51e3d550] - test: move test-cli-syntax to sequential (Rich Trott) #24907
[e20ad2e446] - test: move http2 test to parallel (Rich Trott) #24877
[1a1811d1e0] - test: make http2 timeout test robust (Rich Trott) #24877
[a2dd3a62a7] - test: fix wrong parameter (zhmushan) #24844
[1dff257280] - test: improve test-net-socket-timeout (Rich Trott) #24859
[5e29865375] - test: prepare test/pseudo-tty/testcfg.py for Python 3 (cclauss) #24791
[520d041afb] - test: refactor test-fs-write-file-sync.js (cjihrig) #24834
[b1bbac726e] - test: prepare test/message/testcfg.py for Python 3 (cclauss) #24793
[ff90d17eb3] - test: remove unused addons-napi directory (Rich Trott) #24839
[d08b5e94f5] - test: add .gitignore file for node-api (Rich Trott) #24839
[546fc68ae4] - test: fix common.mustNotCall() usage in HTTP test (Anna Henningsen) #24750
[1c746c7524] - test: use ES2017 syntax in test-fs-open-* (jy95) #23031
[e17dbd22c3] - test: add flag scenario in test-fs-write-file-sync (Gireesh Punathil) #24766
[fd5af6bfa9] - test: check invalid argument error for option (timothy searcy) #24736
[46e37adf59] - test: show stdout and stderr in test-cli-syntax when it fails (Joyee Cheung) #24720
[31c1ee405e] - test: minor refactoring of onticketkeycallback (Daniel Bevenius) #24718
[a7c72d7d5e] - test: mark test_threadsafe_function/test as flaky (Gireesh Punathil) #24714
[e74345b2f5] - test: verify order of error in h2 server stream (Myles Borins) #24685
[288a421dcc] - test: cover path empty string case (lakatostamas) #24569
[d4b1666686] - test: use arrow syntax for anonymous callbacks (Shubham Urkade) #24691
[af582096ad] - test: fix the arguments order in assert.strictEqual (pastak) #24620
[e89f5e59ea] - test: mark test-vm-timeout-escape-nexttick flaky (Gireesh Punathil) #24712
[288d60c2f6] - test: fix the arguments order in assert.strictEqual (sigwyg) #24624
[9f66105e29] - test: fix the arguments order in assert.strictEqual (rt33) #24626
[06208c8313] - test: reach res._dump after abort ClientRequest (Tadhg Creedon) #24191
[85e948753b] - test: validate fs.rename() when NODE_TEST_DIR on separate mount (Drew Folta) #24707
[5966dbed05] - test: test and docs for detached fork process (timothy searcy) #24524
[1c609bf6e2] - test: fix arguments order in assert.strictEqual (sota1235) #24607
[dc7ed30437] - test: fix arguments order in assert.strictEqual (grimrose) #24608
[be17cc59c7] - test: make test-uv-binding-constant JS engine neutral (Rich Trott) #24666
[2318c7fea3] - test: use arrow function (sagirk) #24482
[43bfb136f9] - test: fix arguments order in assert.strictEqual (Takahiro Nakamura) #24621
[3811817290] - test: update strictEqual argument order (VeysonD) #24622
[ec7bd18146] - test: fix argument order in assert.strictEqual (feng jianmei) #24594
[4cc91ff2b5] - test: use arrow functions in callbacks (apoorvanand) #24441
[4093572c4d] - test: add test for socket.end callback (ajido) #24087
[7dee5e5d16] - test: replace anonymous closure functions with arrow functions (tpanthera) #24443
[82d9ffc6a6] - test: fix arguments order in assert.strictEqual (tottokotkd) #24612
[372073e8da] - test: convert callback to arrow function (jamesgeorge007) #24513
[82376015ab] - test: change anonymous function to arrow function (Gagandeep Singh) #24528
[5e3b34fbfd] - test: split out http2 from test-stream-pipeline (Rich Trott) #24631
[b6cceae96f] - test: cover path.basename when path and ext are the same (Laszlo.Moczo) #24570
[7f0fb163a0] - test: fix assert.strictEqual (mki-skt) #24619
[e464a1dca5] - test: fix arguments order in assert.strictEqual (teppeis) #24591
[ec70330dab] - test: fix http2-binding strictEqual order (dominikeinkemmer) #24616
[7b096026d8] - test: fix the arguments order in assert.strictEqual (sota1235) #24595
[1658924d90] - test: replace callback with arrow functions (prodroy1) #24434
[0e63d0abd5] - test: confirm tls server suite default is its own (Sam Roberts) #24374
[3c2b40ba04] - test: rename agent1-pfx.pem to agent1.pfx (Sam Roberts) #24374
[43dcbbedb9] - test: add independent multi-alg crypto identities (Sam Roberts) #24374
[83145ec3a6] - test: cover tls multi-identity option mixtures (Sam Roberts) #24374
[77cf877ea2] - tls: re-define max supported version as 1.2 (Sam Roberts) #25024
[027ca95b46] - tools: make apilinks building more robust (Joyee Cheung) #25019
[694ea008d1] - tools: enable no-useless-constructor lint rule (cjihrig) #25055
[5cbc0dbeaf] - tools: prepare ./tools/compress_json.py for Python 3 (cclauss) #24889
[87f20822c1] - tools: prepare tools/testp.py for Python 3 (cclauss) #24890
[91a96e446a] - tools: prepare tools/icu/icutrim.py for Python 3 (cclauss) #24888
[34212b531f] - tools: update ESLint to 5.10.0 (cjihrig) #24903
[229c0e0cc9] - tools: do not lint tools/inspector_protocol or tools/markupsafe (cclauss) #24882
[bece371639] - tools: prepare tools/js2c.py for Python 3 (cclauss) #24798
[e6afaa350b] - tools: prepare tools/specialize_node_d.py for Python 3 (cclauss) #24797
[544a20f37c] - tools: prepare tools/test.py for Python 3 (cclauss) #24799
[388ec8d77c] - tools: prepare tools/genv8constants.py for Python 3 (cclauss) #24801
[039097e276] - tools: prepare tools/install.py for Python 3 (cclauss) #24800
[f21137976e] - tools: fix eslint usage for Node.js 8 and before (Ruben Bridgewater) #24753
[691e1a69ff] - tools: don't use GH API for commit message checks (Rod Vagg) #24574
[f5f1266326] - tools: only sign release if promotion successful (Rod Vagg) #24669
[cc880fbeeb] - tools: check for git tag before promoting release (Rod Vagg) #24670
[8a5b5e1fd0] - tools: use print() function on both Python 2 and 3 (cclauss) #24486
[f9933ff2c8] - tools,doc: fix version picker bug in html.js (Rich Trott) #24638
[b3932ef8e3] - url: remove an eslint-disable comment (cjihrig) #24995
[c0423cf34c] - url: simplify native URL object construction (Timothy Gu) #24495
[d06ea3e505] - url: reuse existing context in href setter (Timothy Gu) #24495
[4e111ce050] - Revert "url: make the context non-enumerable" (Timothy Gu) #24495
[7048cba388] - url: use SafeSet to filter known special protocols (Mike Samuel) #24703
[8d953b7d26] - vm: simplify Script constructor options validation (cjihrig) #25054
[134d1e9526] - vm: add dynamic import support (Gus Caplan) #22381
[595bdc7603] - win, build: skip building cctest by default (Bartosz Sosnowski) #21408
[483ff7bcc7] - worker: drain messages from internal message port (Yael Hermon) #24932

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Feb 12, 2019

Copy link

Copy Markdown

Collaborator

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2584/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

BethGriggs commented Feb 12, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20746/ [PASSED]
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2090/ [PASSED]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins commented Feb 13, 2019

Copy link

Copy Markdown

Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1735/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs force-pushed the v10.15.2-proposal branch from 7a2f782 to c103ae2 Compare

February 13, 2019 20:30

BethGriggs added a commit that referenced this pull request

Feb 13, 2019


          2019-02-26, Version 10.15.2 'Dubnium' (LTS)

c103ae2

Notable Changes

PR-URL: #26063

BethGriggs commented Feb 13, 2019

Copy link

Copy Markdown

Member Author

Pushed an extra two bug fixes.

CI2: https://ci.nodejs.org/job/node-test-pull-request/20764/
CITGM2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1737/

Kicked off an RC build.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Feb 13, 2019

Copy link

Copy Markdown

Member Author

rc0: https://nodejs.org/download/rc/v10.15.2-rc.0/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau approved these changes

Feb 13, 2019

View reviewed changes

BethGriggs force-pushed the v10.15.2-proposal branch from c103ae2 to 441a321 Compare

February 19, 2019 16:53

BethGriggs added a commit that referenced this pull request

Feb 19, 2019


          2019-02-26, Version 10.15.2 'Dubnium' (LTS)

441a321

Notable Changes

PR-URL: #26063

avaly commented Feb 20, 2019

Copy link

Copy Markdown

Is it possible to also include #25993 in this release?

nikolaik, chenna-reddy, adriaanmeuris, kunal15595, and alexeevg reacted with thumbs up emoji

All reactions

👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR reviewed

Feb 20, 2019

View reviewed changes

Comment thread

doc/api/tls.md Outdated

		added: v0.11.13
		changes:
		- version: REPLACEME
		- version: v10.15.2

BridgeAR Feb 20, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this feature has never landed in v10.x (there is a backport for 10.x open. See #24979). I guess we should remove the changes entry until it actually lands?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

BethGriggs Feb 20, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, i'll back that one out

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

BethGriggs force-pushed the v10.15.2-proposal branch from 441a321 to ac4c04b Compare

February 20, 2019 16:36

BethGriggs added a commit that referenced this pull request

Feb 20, 2019


          2019-02-26, Version 10.15.2 'Dubnium' (LTS)

ac4c04b

Notable Changes

PR-URL: #26063

BethGriggs commented Feb 21, 2019

Copy link

Copy Markdown

Member Author

CI3: https://ci.nodejs.org/job/node-test-pull-request/20931/
V8-CI3: https://ci.nodejs.org/job/node-test-commit-v8-linux/2109/
CITGM3: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1745/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR approved these changes

Feb 21, 2019

View reviewed changes

mhdawson approved these changes

Feb 22, 2019

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rvagg commented Feb 26, 2019

Copy link

Copy Markdown

Member

We discussed postponing this by a week at the last TSC meeting due to the security releases. I'm not sure if that got spread around further than that meeting. So this is going to have to be 10.15.3.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau mentioned this pull request

Feb 26, 2019

v11.11.0 proposal #26322

Merged

ZYSzys and others added 3 commits

February 28, 2019 23:37


          src: use v8:: for consistency in util

f9fc1ea

Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>


          deps: V8: backport 442977e

fa12b24

Original commit message:

  Merged: [wasm] Fix dispatch table instance update

  This CL fixes a bug where the receiving instance was updated improperly
  in the dispatch table(s) of an imported table.

  BUG=chromium:875322
  R=[email protected]
  [email protected]

  Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2
  Originally-reviewed-on: https://chromium-review.googlesource.com/1196886
  No-Try: true
  No-Presubmit: true
  No-Treechecks: true
  Reviewed-on: https://chromium-review.googlesource.com/1212922
  Reviewed-by: Michael Starzinger <[email protected]>
  Commit-Queue: Clemens Hammacher <[email protected]>
  Cr-Commit-Position: refs/branch-heads/6.9@{#45}
  Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
  Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}

Refs: v8/v8@442977e

PR-URL: #25242
Reviewed-By: Michaël Zasso <[email protected]>


          deps: cherry-pick d9fbfeb from upstream V8

67239ab

Original commit message:

    inspector: return [[StableObjectId]] as internal property

    This property might be useful for fast '===' check.

    [email protected],[email protected]

    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
    Reviewed-on: https://chromium-review.googlesource.com/1226411
    Reviewed-by: Dmitry Gozman <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#56095}

PR-URL: #25330

Azard and others added 15 commits

February 28, 2019 23:37


          doc: add EventTarget link to worker_threads

f38469e

PR-URL: #25058
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>


          doc: fix node.1 --http-parser sort order

2d54629

For consistency with the API docs, switch the order of
--http-parser and --force-fips in node.1.

PR-URL: #25045
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          perf_hooks: make GC tracking state per-Environment

7f48299

Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

PR-URL: #25053
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          vm: simplify Script constructor options validation

5f2acc0

This commit combines two related if statements into an
if-else statement.

PR-URL: #25054
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          tools: enable no-useless-constructor lint rule

5c3a739

This commit enables ESLint's no-useless-constructor rule. Note
that the documentation examples that only include constructor
calls were left in tact.

PR-URL: #25055
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: merge test with unnecessary child process

d3c4cab

Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

PR-URL: #25025
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          tls: re-define max supported version as 1.2

161dca7

Several secureProtocol strings allow any supported TLS version as the
maximum, but our maximum supported protocol version is TLSv1.2 even if
someone configures a build against an OpenSSL that supports TLSv1.3.

Fixes: #24658

PR-URL: #25024
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          doc: revise "Breaking Changes" section of Collaborator Guide

801fb66

Simplify material about TSC approval for breaking changes. Omit
extraneous material explaining that purely additive changes are not
breaking changes.

PR-URL: #25071
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          tools: make apilinks building more robust

ef07faa

1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: test internal/util/types in vm

078a2ba

PR-URL: #25056
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          doc: document fs.write limitation with TTY

4bc212d

Fixes: #24550

PR-URL: #24571
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>


          process: fix omitting -- from process.execArgv

3d6266a

This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>


          assert: fix loose deepEqual map comparison

9da4af7

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          assert,util: fix sparse array comparison

30aa8b2

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          build: set -blibpath: for AIX

156e4c8

#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

BethGriggs force-pushed the v10.15.2-proposal branch from ac4c04b to 9f70f19 Compare

February 28, 2019 14:52

BethGriggs added a commit that referenced this pull request

Feb 28, 2019


          2019-03-05, Version 10.15.3 'Dubnium' (LTS)

9f70f19

Notable Changes

PR-URL: #26063

BethGriggs changed the title ~~v10.15.2 proposal~~ v10.15.3 proposal

Feb 28, 2019

BethGriggs commented Feb 28, 2019 •

edited by MylesBorins

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Rebased, new CIs

CI: https://ci.nodejs.org/job/node-test-pull-request/21050/ [Green]
V8CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2120/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1759/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR approved these changes

Feb 28, 2019

View reviewed changes

BridgeAR left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Just the notable changes should still be filled in (if we have any).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

doc/changelogs/CHANGELOG_V10.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rvagg reviewed

Mar 1, 2019

View reviewed changes

Comment thread

doc/changelogs/CHANGELOG_V10.md


		* Coming soon

		### Commits

This comment was marked as outdated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          2019-03-05, Version 10.15.3 'Dubnium' (LTS)

1a96d83

Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063

BethGriggs force-pushed the v10.15.2-proposal branch from 9f70f19 to 1a96d83 Compare

March 4, 2019 13:20

BethGriggs merged commit 1a96d83 into v10.x

Mar 5, 2019

BethGriggs added a commit that referenced this pull request

Mar 5, 2019


          Working on v10.15.4

f612a71

PR-URL: #26063

BethGriggs added a commit that referenced this pull request

Mar 5, 2019


          2019-03-05, Version 10.15.3 'Dubnium' (LTS)

a52c1ea

Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request

Mar 5, 2019


          Blog: v10.15.3 release post

577a30b

Refs: nodejs/node#26063

BethGriggs mentioned this pull request

Mar 5, 2019

Blog: v10.15.3 release post nodejs/nodejs.org#2140

Merged

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request

Mar 5, 2019


          Blog: v10.15.3 release post (#2140)

bb8be74

Refs: nodejs/node#26063

BethGriggs deleted the v10.15.2-proposal branch

March 5, 2019 17:38

Reviewers

richardlau

richardlau approved these changes

BridgeAR

BridgeAR approved these changes

+2 more reviewers

rvagg

rvagg left review comments

mhdawson

mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

BethGriggs commented Feb 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2019-03-05, Version 10.15.3 'Dubnium' (LTS), @BethGriggs

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Feb 12, 2019

Uh oh!

BethGriggs commented Feb 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Feb 13, 2019

Uh oh!

BethGriggs commented Feb 13, 2019

Uh oh!

BethGriggs commented Feb 13, 2019

Uh oh!

avaly commented Feb 20, 2019

Uh oh!

BridgeAR Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

BethGriggs Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

BethGriggs commented Feb 21, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

rvagg commented Feb 26, 2019

Uh oh!

BethGriggs commented Feb 28, 2019 • edited by MylesBorins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

BethGriggs commented Feb 12, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Feb 12, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Feb 28, 2019 •

edited by MylesBorins

Loading

Uh oh!

There was an error while loading. Please reload this page.