GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Jsarrow7 by apoorvanand · Pull Request #24441 · nodejs/node

Conversation

@apoorvanand

@apoorvanand apoorvanand commented Nov 17, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
apoorvanand reacted with hooray emoji
All reactions
  • 🎉 1 reaction
apoorvanand added 2 commits November 17, 2018 18:09
@apoorvanand
test: fixed the arguments order in assert.strictEqual
e8e1ea0
@apoorvanand
test: replace anonymous closure functions
d705e13
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 17, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

First commit message should start with test: fix ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 17, 2018
trivikr
trivikr approved these changes Nov 18, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Nov 18, 2018
View reviewed changes
@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18734/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Nov 19, 2018
View reviewed changes
Trott
Trott reviewed Nov 19, 2018
View reviewed changes
Comment thread test/parallel/test-stream-pipe-await-drain.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott previously requested changes Nov 19, 2018
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one breaks tests. Please change back to a non-arrow function or fix the use of this to use another identifier for the expected object. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 20, 2018
@gireeshpunathil

gireeshpunathil commented Nov 21, 2018

Copy link
Copy Markdown
Member

ping @apoorvanand
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
apoorvanand
apoorvanand commented Nov 22, 2018
View reviewed changes
Comment thread test/parallel/test-stream-pipe-await-drain.js Outdated
reader._read = () => {};

writer1._write = common.mustCall(function(chunk, encoding, cb) {
writer1._write = common.mustCall((chunk, encoding, cb) => {

@apoorvanand apoorvanand Nov 22, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey what I have to change in it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@apoorvanand apoorvanand Nov 22, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed back to non arrow function

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@apoorvanand
Update test-stream-pipe-await-drain.js
4041623 
Changed back to non arrow function to fix it
gireeshpunathil
gireeshpunathil approved these changes Nov 23, 2018
View reviewed changes
@gireeshpunathil

gireeshpunathil commented Nov 23, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18892/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil

gireeshpunathil commented Nov 24, 2018

Copy link
Copy Markdown
Member

@Trott - PTAL; code is good, and the tests are good too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott dismissed their stale review November 25, 2018 04:55

Tests pass.

@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Landed in b5c5d20
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@apoorvanand @Trott
test: use arrow functions in callbacks
b5c5d20 
PR-URL: nodejs#24441
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 28, 2018
@apoorvanand @targos
test: use arrow functions in callbacks
9d54555 
PR-URL: #24441
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
@beevelop beevelop mentioned this pull request Dec 8, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@apoorvanand @refack
test: use arrow functions in callbacks
8853195 
PR-URL: nodejs#24441
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@apoorvanand @BethGriggs
test: use arrow functions in callbacks
4cc91ff 
PR-URL: #24441
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@apoorvanand @rvagg
test: use arrow functions in callbacks
967363d 
PR-URL: #24441
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes
@Trott Trott Trott left review comments
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@apoorvanand @targos @Trott @gireeshpunathil @jasnell @cjihrig @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.