GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: cover path.basename when path and ext are the same by moczolaszlo · Pull Request #24570 · nodejs/node

Conversation

@moczolaszlo

@moczolaszlo moczolaszlo commented Nov 22, 2018

Copy link
Copy Markdown

In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Laszlo.Moczo
test: cover path.basename when path and ext are the same
3f5d512 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 22, 2018
lpinca
lpinca approved these changes Nov 22, 2018
View reviewed changes
@lpinca

lpinca commented Nov 22, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18887/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@moczolaszlo

moczolaszlo commented Nov 23, 2018

Copy link
Copy Markdown
Author

@lpinca Thanks forthe approve!
Can I do anything with that broken check?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Nov 23, 2018 •
edited by refack
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Failure was unrelated, I've resumed the build:

CI: https://ci.nodejs.org/job/node-test-pull-request/18900/ ✔️
moczolaszlo reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack
refack approved these changes Nov 23, 2018
View reviewed changes
@refack refack added path Issues and PRs related to the path subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Nov 23, 2018
cjihrig
cjihrig approved these changes Nov 24, 2018
View reviewed changes
trivikr
trivikr approved these changes Nov 24, 2018
View reviewed changes
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
Laszlo.Moczo @Trott
test: cover path.basename when path and ext are the same
824f16c 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: nodejs#24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott

Trott commented Nov 25, 2018

Copy link
Copy Markdown
Member

Landed in 824f16c.

Thanks for the contribution! 🎉
moczolaszlo reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 25, 2018
targos pushed a commit that referenced this pull request Nov 25, 2018
Laszlo.Moczo @targos
test: cover path.basename when path and ext are the same
c10b805 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: #24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Laszlo.Moczo @rvagg
test: cover path.basename when path and ext are the same
8849d80 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: #24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Laszlo.Moczo @refack
test: cover path.basename when path and ext are the same
da7951e 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: nodejs#24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
Laszlo.Moczo @BethGriggs
test: cover path.basename when path and ext are the same
b6cceae 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: #24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Laszlo.Moczo @rvagg
test: cover path.basename when path and ext are the same
f371321 
In path.basename was a case when the path
and the extension is the same and this wasn't
covered with tests.

I covered this case both in Windows and Unix environments.

PR-URL: #24570
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@refack refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. path Issues and PRs related to the path subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@moczolaszlo @lpinca @Trott @refack @cjihrig @trivikr @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.