GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: only check REPLACEME & DEP...X for releases by rvagg · Pull Request #24575 · nodejs/node

Conversation

@rvagg

@rvagg rvagg commented Nov 23, 2018

Copy link
Copy Markdown
Member

A rehash of #12958.

Summary: the introduction of the checks for REPLACEME and later DEP...X in the release-only Makefile target screwed up "test" and "rc" builds. There are exclusions for "nightly" and "next-nightly" because those are automatic and IIRC we noticed those builds stopped working shortly after the REPLACEME check was instituted. However, "test" and "rc" builds are manual and don't work with this check. Now we also have "v8-canary" in the mix too. These extras make use of the "custom" DISTTYPE.

This got held up because there was disagreement about how exclusive to be. The original change proposed in #8325 was similar to this one but it was then made exclusive by switching to the "nightly" and "next-nightly" builds.

For the last ~18 months we've had this in ci-release:

if [[ "X${disttype}" != "Xrelease" ]]; then
  perl -pi -e "s/: release-only/:/g" Makefile
fi

i.e. overriding the release-only target in Makefile for everything but "release" builds.

This PR aims to put that logic into Makefile so we can remove that check.

Ref: #24551
Ref: #12958
Ref: #12957
Ref: #8325

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rvagg
build: only check REPLACEME & DEP...X for releases
6759a2e 
Ref: nodejs#24551
Ref: nodejs#12958
Ref: nodejs#12957
Ref: nodejs#8325
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2018

Copy link
Copy Markdown
Collaborator

@rvagg build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1682/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Nov 23, 2018
@rvagg rvagg mentioned this pull request Nov 23, 2018
build: make .tar.xz creation opt-out, fail if no xz #24551
Closed
refack
refack approved these changes Nov 23, 2018
View reviewed changes
refack
refack reviewed Nov 23, 2018
View reviewed changes
Comment thread Makefile Resolved

Uh oh!

There was an error while loading. Please reload this page.
danbev
danbev approved these changes Nov 23, 2018
View reviewed changes
richardlau
richardlau approved these changes Nov 23, 2018
View reviewed changes
@rvagg

rvagg commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

Landed in 89e8fc4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg rvagg closed this Nov 28, 2018
@rvagg
rvagg deleted the rvagg/replaceme-doc-make-abort branch November 28, 2018 12:39
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
89e8fc4 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@rvagg

rvagg commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

I've removed this from all over iojs+release:

if [[ "X${disttype}" != "Xrelease" ]]; then
  perl -pi -e "s/: release-only/:/g" Makefile
fi

So @nodejs/build & @nodejs/releasers need to keep an eye out for funny behaviour, it's been in place for a long time.

I've kicked off a test build and a rerun of the last nightly build, just to test. Tomorrow I might try a re-do of one of today's releases and then clean it up from staging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
955819e 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
eaec87b 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
a8402fe 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
25103af 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
d9e10fb 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
aa88483 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
v8.14.1 proposal #24832
Merged
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269
Closed
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271
Closed
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
97d8bc8 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@rvagg @refack
build: only check REPLACEME & DEP...X for releases
51272a9 
PR-URL: nodejs#24575
Refs: nodejs#24551
Refs: nodejs#12958
Refs: nodejs#12957
Refs: nodejs#8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Feb 28, 2019
@rvagg
build: only check REPLACEME & DEP...X for releases
3e4a0ff 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 7, 2019
@rvagg @BethGriggs
build: only check REPLACEME & DEP...X for releases
9ba5fd6 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 15, 2019
v6.17.1 proposal #26684
Merged
@beevelop beevelop mentioned this pull request Apr 3, 2019
2019-04-03 Version 6.17.1 'Boron' (LTS) @BethGriggs beevelop/docker-android-nodejs#299
Closed
@aduh95 aduh95 mentioned this pull request Mar 24, 2025
build, doc: use new api doc tooling #57343
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+2 more reviewers
@refack refack refack approved these changes
@danbev danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rvagg @nodejs-github-bot @refack @danbev @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.