GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: don't require processing docs for nightlies by jbergstroem · Pull Request #8325 · nodejs/node

Conversation

@jbergstroem

@jbergstroem jbergstroem commented Aug 29, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Our nightlies were experiencing issues since we didn't properly replace version info in documentation (#6864). Skip that check unless we're actually doing release builds.

/cc @mhdawson, @williamkapke (reporter), @bnoordhuis, @addaleax

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
williamkapke reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Aug 29, 2016
@jbergstroem

jbergstroem commented Aug 29, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/4817/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Aug 29, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbergstroem jbergstroem mentioned this pull request Aug 29, 2016
Linux builds missing from nightly folders nodejs/build#478
Closed
@jasnell

jasnell commented Aug 29, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@mhdawson

mhdawson commented Aug 29, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis reviewed Aug 30, 2016
View reviewed changes
Comment thread Makefile Outdated

@bnoordhuis bnoordhuis Aug 30, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to check that DISTTYPE is not nightly or next-nightly. If it's set to "custom", you presumably still want this check.

(Also, opting out is arguably better than opting in when it comes to quality checks.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jbergstroem jbergstroem Aug 30, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to change -- I agree with opt-out but please elaborate on a use case when custom would benefit from the check!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bnoordhuis bnoordhuis Aug 30, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on the assumption that people use it for internal releases. We do that at IBM although I don't know if we use this particular mechanism.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jbergstroem jbergstroem Aug 30, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll make a note in the commit msg.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jbergstroem

jbergstroem commented Aug 30, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/4843/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbergstroem

jbergstroem commented Aug 31, 2016

Copy link
Copy Markdown
Member Author

Failures unrelated. I've tested with DISTTYPE=release and DISTTYPE=custom locally. Will rebase and squash/merge today unless there are any new feedback.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Sep 1, 2016

Copy link
Copy Markdown
Member

LGTM if you add a line or two to the commit log. Right now it's just a one-liner.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbergstroem
build: don't require processing docs for nightlies
2168432 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: nodejs#8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jbergstroem
jbergstroem force-pushed the fix/nightly-skip-apidoc branch from a186944 to 2168432 Compare September 1, 2016 11:59
@jbergstroem

jbergstroem commented Sep 1, 2016

Copy link
Copy Markdown
Member Author

Commit message validation: https://ci.nodejs.org/job/node-test-commitmsg/16/tapResults/
evanlucas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbergstroem
jbergstroem merged commit 2168432 into nodejs:master Sep 1, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
v6.6.0 pre-proposal #8428
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
@jbergstroem @Fishrock123
build: don't require processing docs for nightlies
e30622b 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: nodejs#8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
@jbergstroem @Fishrock123
build: don't require processing docs for nightlies
a830e37 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: #8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins added the land-on-v4.x label Sep 30, 2016
@MylesBorins

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@jbergstroem I've backported to v4.x-staging. Let me know if it shouldn't have been
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@jbergstroem Myles Borins
build: don't require processing docs for nightlies
fcf325e 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: #8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jbergstroem

jbergstroem commented Oct 2, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd sgtm.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@jbergstroem Myles Borins
build: don't require processing docs for nightlies
99df574 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: #8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@jbergstroem @rvagg
build: don't require processing docs for nightlies
a35930c 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: #8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@jbergstroem @MylesBorins
build: don't require processing docs for nightlies
e64063c 
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.

This fixes our nightly jobs in CI.

PR-URL: #8325
Fixes: nodejs/build#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
V4.6.2 proposal #9298
Closed
@joaocgreis joaocgreis mentioned this pull request May 11, 2017
build: only require docs 'Added' fixes for release #12958
Closed
rvagg added a commit to rvagg/io.js that referenced this pull request Nov 23, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
6759a2e 
Ref: nodejs#24551
Ref: nodejs#12958
Ref: nodejs#12957
Ref: nodejs#8325
@rvagg rvagg mentioned this pull request Nov 23, 2018
build: only check REPLACEME & DEP...X for releases #24575
Closed
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
89e8fc4 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
955819e 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
eaec87b 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
a8402fe 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Nov 28, 2018
@rvagg
build: only check REPLACEME & DEP...X for releases
25103af 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
d9e10fb 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
aa88483 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@rvagg @MylesBorins
build: only check REPLACEME & DEP...X for releases
97d8bc8 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@rvagg @refack
build: only check REPLACEME & DEP...X for releases
51272a9 
PR-URL: nodejs#24575
Refs: nodejs#24551
Refs: nodejs#12958
Refs: nodejs#12957
Refs: nodejs#8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Feb 28, 2019
@rvagg
build: only check REPLACEME & DEP...X for releases
3e4a0ff 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 7, 2019
@rvagg @BethGriggs
build: only check REPLACEME & DEP...X for releases
9ba5fd6 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jbergstroem @addaleax @jasnell @mhdawson @bnoordhuis @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.