GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: replace `-not` with `!` in `find` by Trott · Pull Request #24635 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 25, 2018

Copy link
Copy Markdown
Member

Replace find -not usage with find ! as -not is not universally
supported.

Fixes: #24634

@nodejs/build-files @rvagg @nodejs/platform-aix

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
build: replace -not with ! in find
5b91604 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
@Trott Trott added build Issues and PRs related to Node.js builds or CI infrastructure. aix Issues and PRs related to the AIX platform. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Nov 25, 2018
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1698/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 25, 2018

Copy link
Copy Markdown
Member Author

👍 here to fast-track
gireeshpunathil and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request Nov 25, 2018
AIX bug in Makefile - find with -not #24634
Closed
@Trott

Trott commented Nov 25, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18957/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Nov 25, 2018
View reviewed changes
lpinca
lpinca approved these changes Nov 25, 2018
View reviewed changes
@Trott

Trott commented Nov 25, 2018

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18959/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 25, 2018
richardlau
richardlau approved these changes Nov 25, 2018
View reviewed changes
@gireeshpunathil

gireeshpunathil commented Nov 25, 2018

Copy link
Copy Markdown
Member

landed as e20be47
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Nov 25, 2018
gireeshpunathil pushed a commit that referenced this pull request Nov 25, 2018
@Trott @gireeshpunathil
build: replace -not with ! in find
e20be47 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2018
@Trott @targos
build: replace -not with ! in find
059d9c7 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
build: replace -not with ! in find
3fa4def 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
build: replace -not with ! in find
edcc4e6 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
PR-URL: nodejs#24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@Trott @BethGriggs
build: replace -not with ! in find
95a3b3e 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
build: replace -not with ! in find
748de6b 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Trott deleted the notnotnot branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIX bug in Makefile - find with -not

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nodejs-github-bot @gireeshpunathil @lpinca @richardlau @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.