GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: elevate v8 namespaces referenced by juanarbol · Pull Request #24657 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Nov 26, 2018

Copy link
Copy Markdown
Member

I saw non elevated v8 namespaces, and v8::HandleScope already elevated but invocated as v8::HandleScope not just HandleScope

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 26, 2018
refack
refack reviewed Nov 26, 2018
View reviewed changes
Comment thread src/async_wrap.cc Outdated

@refack refack Nov 26, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can now unwrap this into a single line.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@juanarbol juanarbol Nov 27, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what is the max width of line? Linter could break this, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@danbev danbev Nov 28, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max length is 80 and if you exceed that the linter will pick it up. You can run make lint-cpp to check any changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@juanarbol juanarbol Nov 28, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and wrapped!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjihrig
cjihrig approved these changes Nov 26, 2018
View reviewed changes
lpinca
lpinca approved these changes Nov 26, 2018
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Nov 27, 2018
View reviewed changes
itskumaradarsh
itskumaradarsh approved these changes Nov 27, 2018
View reviewed changes
JungMinu
JungMinu approved these changes Nov 27, 2018
View reviewed changes
fhinkel
fhinkel approved these changes Nov 27, 2018
View reviewed changes
@danbev

danbev commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18995/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol

juanarbol commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

@rvagg 🤦‍♂️ My bad, at this hour I still thinking why I rebase, what a mess...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol added 2 commits November 28, 2018 23:57
@juanarbol @Trott
src: elevate v8 namespaces referenced
3eebb4b
@juanarbol @Trott
src: wrap line
4996605
@Trott
Trott force-pushed the src-v8-namespaces branch from 7d404f1 to 4996605 Compare November 29, 2018 07:58
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

@juanarbol I checked out your branch and ran git fetch upstream && git rebase upstream/master. The result looked good and I force-pushed it to your branch. So this PR should be back in shape. Can you double-check that it looks good to you and maybe we can get one or two reviewers to confirm their approval? Meanwhile, I'll run CI. If all those things check out, we can land this.
juanarbol reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19033/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol

juanarbol commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

@Trott I think it's ok! Thank you!!!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19077/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 30, 2018
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Optimistic Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19091/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19105/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

Landed in d4273c4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 1, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 1, 2018
@juanarbol @Trott
src: elevate v8 namespaces referenced
d4273c4 
PR-URL: nodejs#24657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@juanarbol @BridgeAR
src: elevate v8 namespaces referenced
0148c1d 
PR-URL: #24657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@juanarbol @refack
src: elevate v8 namespaces referenced
55cfcee 
PR-URL: nodejs#24657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@juanarbol @BethGriggs
src: elevate v8 namespaces referenced
4444cdb 
PR-URL: #24657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@juanarbol @rvagg
src: elevate v8 namespaces referenced
ed0ced3 
PR-URL: #24657
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@juanarbol
juanarbol deleted the src-v8-namespaces branch January 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@JungMinu JungMinu JungMinu approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+4 more reviewers
@refack refack refack left review comments
@danbev danbev danbev left review comments
@fhinkel fhinkel fhinkel approved these changes
@itskumaradarsh itskumaradarsh itskumaradarsh approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@juanarbol @danbev @Trott @refack @fhinkel @lpinca @cjihrig @JungMinu @gireeshpunathil @itskumaradarsh @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.