GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: move setupAllowedFlags() into per_thread.js by joyeecheung · Pull Request #24704 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Nov 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
joyeecheung requested review from addaleax and boneskull November 28, 2018 20:02
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1712/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 28, 2018
@joyeecheung
lib: move setupAllowedFlags() into per_thread.js
e48df20 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.
@joyeecheung
joyeecheung force-pushed the move-flags branch from 50d48a8 to e48df20 Compare November 28, 2018 20:08
@joyeecheung

joyeecheung commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19009/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the dont-land-on-v8.x label Nov 28, 2018
@joyeecheung

joyeecheung commented Nov 29, 2018 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19064/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

@addaleax @boneskull @nodejs/process Can I have some review please? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Nov 30, 2018
View reviewed changes
@joyeecheung joyeecheung added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 30, 2018
boneskull
boneskull approved these changes Nov 30, 2018
View reviewed changes

@boneskull boneskull left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung

joyeecheung commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

Landed in 36f483b, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung closed this Nov 30, 2018
joyeecheung added a commit that referenced this pull request Nov 30, 2018
@joyeecheung
lib: move setupAllowedFlags() into per_thread.js
36f483b 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

PR-URL: #24704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Christopher Hiller <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@joyeecheung @BridgeAR
lib: move setupAllowedFlags() into per_thread.js
d77cf92 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

PR-URL: #24704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Christopher Hiller <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
lib: move setupAllowedFlags() into per_thread.js
552c49f 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

PR-URL: nodejs#24704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Christopher Hiller <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@joyeecheung @BethGriggs
lib: move setupAllowedFlags() into per_thread.js
ef68349 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

PR-URL: #24704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Christopher Hiller <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung @rvagg
lib: move setupAllowedFlags() into per_thread.js
f6b3cf0 
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.

PR-URL: #24704
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Christopher Hiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
+1 more reviewer
@boneskull boneskull boneskull approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@joyeecheung @nodejs-github-bot @addaleax @boneskull
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.