GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http2: make compat writeHead not crash if the stream is destroyed by mcollina · Pull Request #24723 · nodejs/node

Conversation

@mcollina

@mcollina mcollina commented Nov 29, 2018

Copy link
Copy Markdown
Member

Fixes: #24470

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mcollina
http2: make compat writeHead not crash if the stream is destroyed
69e283e 
Fixes: nodejs#24470
@mcollina
mcollina requested review from addaleax, apapirovski and jasnell November 29, 2018 13:35
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1724/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues and PRs related to the http2 subsystem. labels Nov 29, 2018
@mcollina

mcollina commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19045/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

cc @StephenLynx
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Nov 29, 2018
View reviewed changes
Comment thread test/parallel/test-http2-compat-write-head-destroyed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@richardlau @mcollina
Update test/parallel/test-http2-compat-write-head-destroyed.js
c54500b 
Co-Authored-By: mcollina <[email protected]>
@mcollina mcollina mentioned this pull request Nov 29, 2018
ERR_HTTP2_INVALID_STREAM #24470
Closed
jasnell
jasnell approved these changes Nov 29, 2018
View reviewed changes
lpinca
lpinca approved these changes Nov 29, 2018
View reviewed changes
@Trott

Trott commented Dec 2, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19130/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 2, 2018
@Trott

Trott commented Dec 3, 2018

Copy link
Copy Markdown
Member

Landed in 32fed93
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 3, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 3, 2018
@mcollina @Trott
http2: make compat writeHead not crash if the stream is destroyed
32fed93 
Fixes: nodejs#24470

PR-URL: nodejs#24723
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mcollina
mcollina deleted the http2-write-head-do-not-crash branch December 3, 2018 08:54
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@mcollina @BridgeAR
http2: make compat writeHead not crash if the stream is destroyed
798504a 
Fixes: #24470

PR-URL: #24723
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mcollina @refack
http2: make compat writeHead not crash if the stream is destroyed
b287426 
Fixes: nodejs#24470

PR-URL: nodejs#24723
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@mcollina @BethGriggs
http2: make compat writeHead not crash if the stream is destroyed
f4aed8c 
Fixes: #24470

PR-URL: #24723
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs added the dont-land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@mcollina @rvagg
http2: make compat writeHead not crash if the stream is destroyed
d56a5e8 
Fixes: #24470

PR-URL: #24723
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mcollina mcollina mentioned this pull request Apr 19, 2019
HTTP2 Proxy always falls fastify/fastify-http-proxy#51
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@apapirovski apapirovski Awaiting requested review from apapirovski
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ERR_HTTP2_INVALID_STREAM

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mcollina @nodejs-github-bot @Trott @jasnell @lpinca @richardlau @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.