GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: check invalid argument error for option by nanomosfet · Pull Request #24736 · nodejs/node

Conversation

@nanomosfet

@nanomosfet nanomosfet commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

this adds a test for the validateArguments function in TextDecoder

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

As another note I would like to test the function makeTextDecoderJS in encoding.js but I do not know how to force hasIntl to be false without rebuilding node with the option --without-intl. Is there a way to do this at runtime? (Maybe it could be providing a icu-data-dir that has it disabled? I just don't know what that file would look like if that is the case)

If anyone knows a way to set hasIntl to off let me know because I can just include those tests and get the coverage of encoding.js up even more!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nanomosfet
test: check invalid argument error for option
3cf063d 
this adds a test for the validateArguments function in TextDecoder
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 30, 2018
Trott
Trott approved these changes Nov 30, 2018
View reviewed changes
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19075/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Nov 30, 2018
View reviewed changes
@Trott

Trott commented Dec 2, 2018 •
edited by danbev
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19127/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev

danbev commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

Landed in f8f9601.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev danbev closed this Dec 3, 2018
danbev pushed a commit that referenced this pull request Dec 3, 2018
@nanomosfet @danbev
test: check invalid argument error for option
f8f9601 
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@nanomosfet @BridgeAR
test: check invalid argument error for option
7577e75 
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@nanomosfet @refack
test: check invalid argument error for option
dd6cd9c 
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: nodejs#24736
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@nanomosfet @BethGriggs
test: check invalid argument error for option
fd5af6b 
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@nanomosfet @rvagg
test: check invalid argument error for option
c0205e8 
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nanomosfet @Trott @danbev @cjihrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.