GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: hide undocumented object artifacts in async_hooks examples by gireeshpunathil · Pull Request #24741 · nodejs/node

Conversation

@gireeshpunathil

@gireeshpunathil gireeshpunathil commented Nov 30, 2018

Copy link
Copy Markdown
Member

The examples show process.stdout.fd as a means to use synchronous writes
in async_hooks context. However this is an undocumented field, so showcase
a file write example instead.

Fixes: #22873

/cc @vsemozhetbyt @bnoordhuis @nodejs/documentation

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gireeshpunathil
doc: hide undocumented object artifacts in async_hooks
3ac17a6 
The examples show `process.stdout.fd` as a means to use synchronous writes
in async_hooks context. However this is an undocumented field, so showcase
a file write example instead.

Fixes: nodejs#22873
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1737/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 30, 2018
Trott
Trott approved these changes Nov 30, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt approved these changes Nov 30, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 30, 2018
@Trott

Trott commented Dec 4, 2018

Copy link
Copy Markdown
Member

Landed in 9159fb7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2018
@gireeshpunathil @Trott
doc: hide undocumented object artifacts in async_hooks
9159fb7 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: nodejs#22873

PR-URL: nodejs#24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@Trott Trott closed this Dec 4, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@gireeshpunathil @BridgeAR
doc: hide undocumented object artifacts in async_hooks
997c0e0 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: #22873

PR-URL: #24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@gireeshpunathil @refack
doc: hide undocumented object artifacts in async_hooks
ad26bb5 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: nodejs#22873

PR-URL: nodejs#24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@gireeshpunathil @BethGriggs
doc: hide undocumented object artifacts in async_hooks
184425e 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: #22873

PR-URL: #24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@gireeshpunathil @BethGriggs
doc: hide undocumented object artifacts in async_hooks
7e5166a 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: #22873

PR-URL: #24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gireeshpunathil @rvagg
doc: hide undocumented object artifacts in async_hooks
65bac1b 
The examples show `process.stdout.fd` as a means to use synchronous
writes in async_hooks context. However this is an undocumented field,
so showcase a file write example instead.

Fixes: #22873

PR-URL: #24741
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
+1 more reviewer
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: process.stdout.fd is mentioned but undocumented

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gireeshpunathil @nodejs-github-bot @Trott @vsemozhetbyt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.