GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: add '.git' to 'make lint-py' exclude list by cclauss · Pull Request #24802 · nodejs/node

Conversation

@cclauss

@cclauss cclauss commented Dec 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When run locally flake8 is currently creating false positives by scanning the .git directory. This PR prevents that behavior.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cclauss
build: add '.git' to 'make lint-py' exclude list
5cfef48 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Dec 3, 2018
richardlau
richardlau approved these changes Dec 3, 2018
View reviewed changes
@cclauss cclauss mentioned this pull request Dec 3, 2018
Python 3 compatibility issues #23659
Closed
BridgeAR
BridgeAR approved these changes Dec 3, 2018
View reviewed changes
lpinca
lpinca approved these changes Dec 3, 2018
View reviewed changes
@cclauss

cclauss commented Dec 4, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Is there a specific number of Reviewers that need to ✅a pull request before it gets accepted? I am trying to make my PRs as simple as possible to review but progress remains slow. Any advise?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Is there a specific number of Reviewers that need to ✅a pull request before it gets accepted? I am trying to make my PRs as simple as possible to review but progress remains slow. Any advise?

@cclauss Either of the following are the requirements. (There's also a fast-tracking process, but I don't think it's relevant here.)

2 reviewers + 48 hours + green CI
1 reviewer + 7 days + green CI
cclauss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1849/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 6, 2018
@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Landed in 7bcbf04
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 6, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2018
cclauss @Trott
build: add '.git' to 'make lint-py' exclude list
7bcbf04 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: nodejs#24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cclauss
cclauss deleted the patch-1 branch December 6, 2018 04:11
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
cclauss @BridgeAR
build: add '.git' to 'make lint-py' exclude list
d117961 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
cclauss @BridgeAR
build: add '.git' to 'make lint-py' exclude list
a22ac0b 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
cclauss @BridgeAR
build: add '.git' to 'make lint-py' exclude list
b7a6014 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
cclauss @refack
build: add '.git' to 'make lint-py' exclude list
2069e07 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: nodejs#24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
cclauss @BethGriggs
build: add '.git' to 'make lint-py' exclude list
552a5c0 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
cclauss @BethGriggs
build: add '.git' to 'make lint-py' exclude list
d882e59 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
cclauss @rvagg
build: add '.git' to 'make lint-py' exclude list
dc728b7 
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory.  This PR prevents that behavior.

PR-URL: #24802
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cclauss @Trott @lpinca @richardlau @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.