GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix added version of randomFill+randomFillSync by watson · Pull Request #24812 · nodejs/node

Conversation

@watson

@watson watson commented Dec 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

crypto.randomFill and crypto.randomFillSync was backported to Node.js 6.13.0 but the documentation wasn't updated. So the documentation still says that this was added in v7.10.0.

This PR updates that to say v6.13.0, but I'm honestly not really sure if that's the best solution. Because it of course means that it wasn't there between version 7.0.0 and 7.9.0.

Possible solutions:

  • Don't care because 7.x isn't EoL
  • Add a row to the changes: section saying that it wasn't there between 7.0.0 and 7.9.0
  • Update the yaml parser to support that a function be added in more than one different major

@nodejs/documentation What do you think?

Update: Changed the PR according to #24812 (comment)

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2018

Copy link
Copy Markdown
Collaborator

@watson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1808/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Dec 3, 2018
@vsemozhetbyt

vsemozhetbyt commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

It seems we already support multiple versions here. See code changes and test examples in 00ffa33, in particular test/fixtures/doc_with_yaml.md.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watson
doc: fix added version of randomFill+randomFillSync
48f9eb0
@watson
watson force-pushed the random-fill branch from fcb3b04 to 48f9eb0 Compare December 3, 2018 18:05
@watson

watson commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

@vsemozhetbyt updated with both versions in the added: section
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Dec 3, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt approved these changes Dec 3, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 3, 2018
@vsemozhetbyt

vsemozhetbyt commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
vsemozhetbyt, cjihrig, Fishrock123, watson, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 3, 2018
View reviewed changes
Fishrock123
Fishrock123 approved these changes Dec 3, 2018
View reviewed changes
@watson watson self-assigned this Dec 3, 2018
lpinca
lpinca approved these changes Dec 3, 2018
View reviewed changes
@devsnek devsnek added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 3, 2018
thefourtheye
thefourtheye approved these changes Dec 3, 2018
View reviewed changes
@watson

watson commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

Landed in fa19ce9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watson watson closed this Dec 3, 2018
@watson
watson deleted the random-fill branch December 3, 2018 19:59
watson added a commit that referenced this pull request Dec 3, 2018
@watson
doc: fix added version of randomFill+randomFillSync
fa19ce9 
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@watson @BridgeAR
doc: fix added version of randomFill+randomFillSync
58e5c00 
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@watson @refack
doc: fix added version of randomFill+randomFillSync
0aabc83 
PR-URL: nodejs#24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@watson @BethGriggs
doc: fix added version of randomFill+randomFillSync
ad40e78 
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@watson @BethGriggs
doc: fix added version of randomFill+randomFillSync
f93f284 
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@watson @rvagg
doc: fix added version of randomFill+randomFillSync
9a0924c 
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+3 more reviewers
@thefourtheye thefourtheye thefourtheye approved these changes
@Fishrock123 Fishrock123 Fishrock123 approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@watson watson

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@watson @nodejs-github-bot @vsemozhetbyt @thefourtheye @addaleax @Fishrock123 @lpinca @cjihrig @devsnek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.