GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: list all versions WHATWG URL api was added by watson · Pull Request #24847 · nodejs/node

Conversation

@watson

@watson watson commented Dec 5, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Originally WHATWG URL api support was added in v7.x but was later backported to v6.13.0. This PR updates the docs to show support for the WHATWG URL api in that version + adds missing added: info to a few functions that were missing it which were added in in v10.12.0.

Question: Should I remove v7.0.0 from the added: list, or does it give historical context to see that it was added to v7.0.0 first and then later backported to v6.13.0? Update: After I've seen it rendered, I think it makes sense to show both.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@watson watson self-assigned this Dec 5, 2018
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2018

Copy link
Copy Markdown
Collaborator

@watson sadly an error occured when I tried to trigger a build :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module. labels Dec 5, 2018
@watson

watson commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

Just discovered a few other places in the URL docs where the added: field needs to be updated. I'll push a new commit soon
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@watson
doc: list all versions WHATWG URL api was added
016d26b
@watson
watson force-pushed the url-docs branch from 8b64e1b to 016d26b Compare December 5, 2018 10:49
@watson watson changed the title doc: show WHATWG URL api support in v6.13.0 doc: list all versions WHATWG URL api was added Dec 5, 2018
@watson

watson commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

I updated the PR to be a complete makeover of the added: attribute for all the WHATWG URL functions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Dec 5, 2018
View reviewed changes
@sam-github sam-github mentioned this pull request Dec 5, 2018
are the YAML "added" annotations ambiguous? and are they rewritten on backport? #24850
Closed
sam-github
sam-github approved these changes Dec 5, 2018
View reviewed changes

@sam-github sam-github left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I think its a general problem in the YAML annotations, I added a issue to track it: #24850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@watson watson added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Dec 5, 2018
@watson

watson commented Dec 5, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
lpinca and vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt approved these changes Dec 5, 2018
View reviewed changes
@watson

watson commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

@sam-github forgot to mention you in the above comment, so here it goes ^
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Landed in 7868b6a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 5, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2018
@watson @Trott
doc: list all versions WHATWG URL api was added
7868b6a 
PR-URL: nodejs#24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@watson
watson deleted the url-docs branch December 5, 2018 23:14
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
@watson @BridgeAR
doc: list all versions WHATWG URL api was added
6884f5a 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@watson @BridgeAR
doc: list all versions WHATWG URL api was added
d800998 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@watson @BridgeAR
doc: list all versions WHATWG URL api was added
1feb6e4 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@watson @refack
doc: list all versions WHATWG URL api was added
bd7af44 
PR-URL: nodejs#24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@watson @BethGriggs
doc: list all versions WHATWG URL api was added
f2df92c 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@watson @BethGriggs
doc: list all versions WHATWG URL api was added
19b9045 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@watson @rvagg
doc: list all versions WHATWG URL api was added
1a25e54 
PR-URL: #24847
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+2 more reviewers
@sam-github sam-github sam-github approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@watson watson

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@watson @nodejs-github-bot @Trott @sam-github @lpinca @vsemozhetbyt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.