GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update a link of npm repository by watilde · Pull Request #24969 · nodejs/node

Conversation

@watilde

@watilde watilde commented Dec 11, 2018

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2018

Copy link
Copy Markdown
Collaborator

@watilde build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1899/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Dec 11, 2018
addaleax
addaleax approved these changes Dec 11, 2018
View reviewed changes
@watilde
doc: update a link of npm repository
edcdcdd
addaleax
addaleax reviewed Dec 11, 2018
View reviewed changes
Comment thread doc/guides/maintaining-npm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@watilde
watilde force-pushed the docs-npm branch from b93bcd7 to edcdcdd Compare December 11, 2018 20:30
lpinca
lpinca approved these changes Dec 11, 2018
View reviewed changes
@watilde

watilde commented Dec 11, 2018

Copy link
Copy Markdown
Member Author

Error on ci: https://ci.nodejs.org/job/node-linter/1870/console

+ git status
HEAD detached at edcdcdd002
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	tools/remark-cli/
	tools/remark-preset-lint-node/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Dec 11, 2018
View reviewed changes
@watilde

watilde commented Dec 11, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

linter ci: https://ci.nodejs.org/job/node-test-linter/24271/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 11, 2018
View reviewed changes
BridgeAR
BridgeAR approved these changes Dec 12, 2018
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 12, 2018
@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Landed in 450ab14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@watilde @Trott
doc: update a link of npm repository
450ab14 
PR-URL: nodejs#24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@watilde
watilde deleted the docs-npm branch December 14, 2018 13:59
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@watilde @BethGriggs
doc: update a link of npm repository
f0bcacd 
PR-URL: #24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
V11.5.0 proposal #25102
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@watilde @refack
doc: update a link of npm repository
b69b6a7 
PR-URL: nodejs#24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@watilde @BethGriggs
doc: update a link of npm repository
8ae649d 
PR-URL: #24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@watilde @BethGriggs
doc: update a link of npm repository
b3c3478 
PR-URL: #24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@watilde @rvagg
doc: update a link of npm repository
96b57fe 
PR-URL: #24969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@watilde @nodejs-github-bot @Trott @addaleax @lpinca @cjihrig @richardlau @BridgeAR @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.