GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: removing unused arguments, and conversion ES6 arrow function common.mustCall by mitchhankins01 · Pull Request #24976 · nodejs/node

Conversation

@mitchhankins01

@mitchhankins01 mitchhankins01 commented Dec 12, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

test: removing unused arguments, and conversion ES6 arrow function common.mustCall

  • Removed unused arguments to common.mustCall callback
  • Converted callback in common.mustCall to ES6 arrow function syntax
Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mitch Hankins
Removing unused function arguments, and converting it to ES6 arrow sy…
10c5b0c 
…ntax in test/async-hooks/test-enable-in-init.js
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Dec 12, 2018
@mitchhankins01 mitchhankins01 changed the title Removing unused function arguments, and converting it to ES6 arrow sy… test: removing unused arguments, and conversion ES6 arrow function common.mustCall Dec 12, 2018
Trott
Trott approved these changes Dec 12, 2018
View reviewed changes
@Trott

Trott commented Dec 12, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19438/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danbev
danbev approved these changes Dec 12, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Dec 12, 2018
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 12, 2018
@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Landed in 848ae89
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
Mitch Hankins @Trott
test: refactor test-enable-in-init
848ae89 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: nodejs#24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
Mitch Hankins @BethGriggs
test: refactor test-enable-in-init
d5b0ce1 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
V11.5.0 proposal #25102
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Mitch Hankins @refack
test: refactor test-enable-in-init
47cbb05 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: nodejs#24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Mitch Hankins @BethGriggs
test: refactor test-enable-in-init
11d5c07 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Mitch Hankins @BethGriggs
test: refactor test-enable-in-init
bb067d1 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Mitch Hankins @rvagg
test: refactor test-enable-in-init
196b021 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@danbev danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mitchhankins01 @Trott @danbev @cjihrig @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.