GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v10.x backport] src: promote v8 name spaces with using by ZYSzys · Pull Request #25005 · nodejs/node

Conversation

@ZYSzys

@ZYSzys ZYSzys commented Dec 13, 2018

Copy link
Copy Markdown
Member

Refs: #23934

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZYSzys
src: use v8:: for consistency in util
9588267
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. v10.x labels Dec 13, 2018
@MylesBorins
MylesBorins force-pushed the v10.x-staging branch from 17f4208 to d04c3c2 Compare December 26, 2018 16:20
bnoordhuis
bnoordhuis approved these changes Jan 6, 2019
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Overly cautious CI: https://ci.nodejs.org/job/node-test-pull-request/19958/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins
MylesBorins force-pushed the v10.x-staging branch from c1ee936 to c6cffad Compare January 29, 2019 05:06
@codebytere
codebytere force-pushed the v10.x-staging branch 3 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12
@BethGriggs

BethGriggs commented Feb 4, 2019

Copy link
Copy Markdown
Member

Another CI before landing - https://ci.nodejs.org/job/node-test-commit/25585/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BethGriggs

BethGriggs commented Feb 4, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Landed in 450bcde
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BethGriggs BethGriggs closed this Feb 4, 2019
BethGriggs pushed a commit that referenced this pull request Feb 4, 2019
@ZYSzys @BethGriggs
src: use v8:: for consistency in util
450bcde 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys
ZYSzys deleted the backport-23934-to-v10.x branch February 5, 2019 08:36
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
src: use v8:: for consistency in util
f9fc1ea 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ZYSzys @BethGriggs @bnoordhuis @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.