GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: promote v8 name spaces with using by ZYSzys · Pull Request #23934 · nodejs/node

Conversation

@ZYSzys

@ZYSzys ZYSzys commented Oct 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Promote v8 name spaces with using for consistent in util related codebase.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and danbev reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Oct 28, 2018
addaleax
addaleax approved these changes Oct 28, 2018
View reviewed changes
targos
targos approved these changes Oct 28, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Oct 28, 2018
View reviewed changes
lpinca
lpinca approved these changes Oct 28, 2018
View reviewed changes
jasnell
jasnell approved these changes Oct 29, 2018
View reviewed changes
fhinkel
fhinkel suggested changes Oct 30, 2018
View reviewed changes

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you change the commit message please. I think it should be "for consistency".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZYSzys
src: use v8:: for consistency in util
b1595d4
@ZYSzys

ZYSzys commented Oct 30, 2018

Copy link
Copy Markdown
Member Author

@fhinkel Aha, sorry for the commit message typo😅. Fixed now.
fhinkel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fhinkel
fhinkel approved these changes Oct 30, 2018
View reviewed changes
@danbev

danbev commented Oct 31, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18254/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev

danbev commented Nov 2, 2018

Copy link
Copy Markdown
Contributor

Landed in 9e31a72.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev danbev closed this Nov 2, 2018
danbev pushed a commit that referenced this pull request Nov 2, 2018
@ZYSzys @danbev
src: use v8:: for consistency in util
9e31a72 
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys
ZYSzys deleted the src/util branch November 2, 2018 10:25
targos pushed a commit that referenced this pull request Nov 2, 2018
@ZYSzys @targos
src: use v8:: for consistency in util
38b0525 
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@ZYSzys ZYSzys mentioned this pull request Nov 5, 2018
Bangalore, November 17th nodejs/code-and-learn#88
Closed
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Release proposal: v11.2 #24350
Merged
This was referenced Nov 15, 2018
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232
Closed
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249
Closed
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233
Closed
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234
Closed
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235
Closed
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236
Closed
@MylesBorins MylesBorins added dont-land-on-v8.x labels Nov 27, 2018
@MylesBorins

MylesBorins commented Nov 27, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This does not land cleanly in v10.x LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZYSzys ZYSzys mentioned this pull request Nov 27, 2018
[v10.x backport] src: use v8:: for consistency in util #24671
Closed
2 tasks done
@ZYSzys ZYSzys mentioned this pull request Dec 13, 2018
[v10.x backport] src: promote v8 name spaces with using #25005
Closed
2 tasks done
BethGriggs pushed a commit that referenced this pull request Feb 4, 2019
@ZYSzys @BethGriggs
src: use v8:: for consistency in util
450bcde 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs added backported-to-v10.x and removed backport-requested-v10.x labels Feb 4, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
src: use v8:: for consistency in util
f9fc1ea 
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@ZYSzys @danbev @MylesBorins @fhinkel @jasnell @addaleax @lpinca @targos @cjihrig @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.