GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix author-ready conflict by BridgeAR · Pull Request #25015 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Dec 13, 2018

Copy link
Copy Markdown
Member

The onboarding docs still contained an outdated description of the
author-ready label. Now it references the main description to
prevent any future conflicts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@BridgeAR
doc: fix author-ready conflict
c916d9d 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.
@BridgeAR BridgeAR added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 13, 2018
@BridgeAR
BridgeAR requested review from Trott and vsemozhetbyt December 13, 2018 14:38
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1927/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Dec 13, 2018
@BridgeAR

BridgeAR commented Dec 13, 2018

Copy link
Copy Markdown
Member Author

Please 👍 in case you agree to fast-track this.
watilde, lpinca, and Trott reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
watilde
watilde approved these changes Dec 13, 2018
View reviewed changes
lpinca
lpinca approved these changes Dec 13, 2018
View reviewed changes
Trott
Trott approved these changes Dec 13, 2018
View reviewed changes
@Trott

Trott commented Dec 13, 2018

Copy link
Copy Markdown
Member

Landed in afeb56a
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 13, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 13, 2018
@BridgeAR @Trott
doc: fix author-ready conflict
afeb56a 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: nodejs#25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BridgeAR @BethGriggs
doc: fix author-ready conflict
1e09629 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: #25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
V11.5.0 proposal #25102
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
doc: fix author-ready conflict
7f5d714 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: nodejs#25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BridgeAR @BethGriggs
doc: fix author-ready conflict
9ffa827 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: #25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BridgeAR @BethGriggs
doc: fix author-ready conflict
057a22a 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: #25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @rvagg
doc: fix author-ready conflict
9c8cc31 
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: #25015
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
BridgeAR deleted the fix-author-ready-conflict branch January 20, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@watilde watilde watilde approved these changes
@vsemozhetbyt vsemozhetbyt Awaiting requested review from vsemozhetbyt

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@BridgeAR @nodejs-github-bot @Trott @lpinca @watilde @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.