GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: make apilinks building more robust by joyeecheung · Pull Request #25019 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Dec 13, 2018

Copy link
Copy Markdown
Member
  1. Move the apilinks.json file into out/doc so it gets cleaned when
    running make docclean
  2. When the apilinks.json generated is empty, throw a specific error
    so it's easier to understand what's wrong
  3. Write to a file passed through CLI arguments instead writing to
    stdout in apilinks.js so the build process is more robust in
    the case of a bad binary
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
tools: make apilinks building more robust
1cbc5e7 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1930/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Dec 13, 2018
@joyeecheung joyeecheung mentioned this pull request Dec 16, 2018
tools: better error message for failed tools/doc/generate #25064
Closed
2 tasks done
addaleax
addaleax approved these changes Dec 16, 2018
View reviewed changes
jasnell
jasnell approved these changes Dec 17, 2018
View reviewed changes
@Trott

Trott commented Dec 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19596/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 17, 2018
@danbev

danbev commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

Landed in 9190e4e.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danbev danbev closed this Dec 18, 2018
danbev pushed a commit that referenced this pull request Dec 18, 2018
@joyeecheung @danbev
tools: make apilinks building more robust
9190e4e 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@joyeecheung @MylesBorins
tools: make apilinks building more robust
a5bccc2 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
v11.6.0 proposal #25175
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
tools: make apilinks building more robust
b2e771d 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: nodejs#25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit to MylesBorins/build that referenced this pull request Jan 29, 2019
@MylesBorins
assets: additional asset for v11.x
c8119db 
Refs: nodejs/node#22405
Refs: nodejs/node#25019
@MylesBorins MylesBorins mentioned this pull request Jan 29, 2019
assets: additional asset for v11.x nodejs/build#1673
Merged
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@joyeecheung @BethGriggs
tools: make apilinks building more robust
027ca95 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@joyeecheung @BethGriggs
tools: make apilinks building more robust
71fad31 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit to nodejs/build that referenced this pull request Feb 28, 2019
@MylesBorins @rvagg
assets: additional asset for v11.x
6098487 
Refs: nodejs/node#22405
Refs: nodejs/node#25019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung @rvagg
tools: make apilinks building more robust
ef07faa 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau added a commit to richardlau/build that referenced this pull request Apr 9, 2020
@richardlau
promote: add additional asset for v10.x
1f5e87b 
`docs/apilinks.json` was added in v10.15.3.

Refs: nodejs/node#25019
Refs: nodejs#1673

Signed-off-by: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Apr 9, 2020
Update expected assets for v10.x and add v14.x nodejs/build#2278
Merged
rvagg pushed a commit to nodejs/build that referenced this pull request Apr 13, 2020
@richardlau @rvagg
promote: add additional asset for v10.x
8c2444d 
`docs/apilinks.json` was added in v10.15.3.

Refs: nodejs/node#25019
Refs: #1673

Signed-off-by: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@joyeecheung @nodejs-github-bot @Trott @danbev @jasnell @addaleax @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.