GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — util: Remove exec, has been deprecated for years by geek · Pull Request #2530 · nodejs/node

Conversation

@geek

@geek geek commented Aug 24, 2015

Copy link
Copy Markdown
Member

This has been deprecated for years: https://github.com/joyent/node/blob/v0.8.28-release/lib/util.js#L480-L482

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@geek
util: Remove exec, has been deprecated for years
df1a19f
@brendanashworth brendanashworth added util Issues and PRs related to the built-in util module. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 24, 2015
@chrisdickinson

chrisdickinson commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

Adding this to the list of things to check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Aug 25, 2015

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geek

geek commented Sep 1, 2015

Copy link
Copy Markdown
Member Author

@chrisdickinson do you have a tool that runs a check? If so, can you share the code?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg
rvagg force-pushed the master branch from 11c25c2 to ba02bd0 Compare September 6, 2015 11:55
@targos

targos commented Oct 9, 2015

Copy link
Copy Markdown
Member

@chrisdickinson could you check this one ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Nov 5, 2015

Copy link
Copy Markdown
Member

@chrisdickinson ... ping. were you ever able to get around to this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. ctc-agenda labels Nov 16, 2015
@jasnell

jasnell commented Nov 18, 2015

Copy link
Copy Markdown
Member

Putting this on the ctc-agenda tomorrow for a quick sanity check. Don't believe it's controversial at all but worth a double check
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell mentioned this pull request Nov 18, 2015
Node Foundation CTC Meeting 2015-11-18 #3894
Closed
@cjihrig

cjihrig commented Nov 18, 2015

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@jasnell

jasnell commented Nov 18, 2015

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
geek added a commit that referenced this pull request Nov 18, 2015
@geek @jasnell
util: Remove exec, has been deprecated for years
4cf19ad 
PR-URL: #2530
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell removed ctc-agenda stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. labels Nov 18, 2015
@jasnell

jasnell commented Nov 18, 2015

Copy link
Copy Markdown
Member

Landed in 4cf19ad.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Nov 18, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
deps: upgrade npm to 3.5.0 #4032
Closed
@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
v5.3.0 Release Proposal (Stable) #4281
Closed
@jasnell jasnell mentioned this pull request Mar 17, 2016
Planning for v6 #5766
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@geek @chrisdickinson @mscdex @targos @jasnell @cjihrig @brendanashworth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.