GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: allow clang 10+ in configure.py by krytarowski · Pull Request #29541 · nodejs/node

Conversation

@krytarowski

@krytarowski krytarowski commented Sep 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Detected on NetBSD/amd64.

Fixes: #29536

Checklist
  • make -j4 test (NetBSD), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@krytarowski
build: allow clang 10+ in configure.py
a467bcc 
Detected on NetBSD/amd64.

Fixes: nodejs#29536
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Sep 13, 2019
bnoordhuis
bnoordhuis approved these changes Sep 13, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25462/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 13, 2019
View reviewed changes
devnexen
devnexen approved these changes Sep 13, 2019
View reviewed changes
gengjiawen
gengjiawen approved these changes Sep 13, 2019
View reviewed changes
cjihrig
cjihrig approved these changes Sep 13, 2019
View reviewed changes
richardlau
richardlau approved these changes Sep 13, 2019
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25472/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pstef
pstef approved these changes Sep 13, 2019
View reviewed changes
@Trott

Trott commented Sep 15, 2019

Copy link
Copy Markdown
Member

Landed in 233cdb6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Sep 15, 2019
Trott pushed a commit that referenced this pull request Sep 15, 2019
@krytarowski @Trott
build: allow clang 10+ in configure.py
233cdb6 
Detected on NetBSD/amd64.

Fixes: #29536

PR-URL: #29541
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2019
@krytarowski @targos
build: allow clang 10+ in configure.py
6317ff4 
Detected on NetBSD/amd64.

Fixes: #29536

PR-URL: #29541
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
v12.11.0 proposal #29695
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@krytarowski @BridgeAR
build: allow clang 10+ in configure.py
f90740d 
Detected on NetBSD/amd64.

Fixes: #29536

PR-URL: #29541
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This was referenced Sep 25, 2019
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#301
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#333
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#302
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#334
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#303
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#335
Closed
@sam-github sam-github added the lts-watch-v10.x label Apr 13, 2020
@sam-github

sam-github commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

@nodejs/lts Please cherry-pick this onto v10.x so it can build with clang 10 and later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Apr 17, 2020
@krytarowski @richardlau
build: allow clang 10+ in configure.py
1b5adbc 
Detected on NetBSD/amd64.

Fixes: nodejs#29536

PR-URL: nodejs#29541
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau added land-on-v10.x and removed lts-watch-v10.x labels Apr 17, 2020
@richardlau

richardlau commented Apr 17, 2020

Copy link
Copy Markdown
Member

@nodejs/lts Please cherry-pick this onto v10.x so it can build with clang 10 and later.

I've cherry-picked it across to v10.x-staging.
sam-github and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs pushed a commit that referenced this pull request Jun 2, 2020
@krytarowski @BethGriggs
build: allow clang 10+ in configure.py
24b927a 
Detected on NetBSD/amd64.

Fixes: #29536

PR-URL: #29541
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Jul 2, 2020
v10.22.0 proposal #34170
Merged
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
+2 more reviewers
@pstef pstef pstef approved these changes
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clang10 is unsupported

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@krytarowski @nodejs-github-bot @Trott @sam-github @richardlau @bnoordhuis @lpinca @cjihrig @pstef @gengjiawen @devnexen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.