GeezerVison is showing github.com — v10.22.0 proposal by richardlau · Pull Request #34170 · nodejs/node
Conversation
richardlau
commented
Jul 2, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
2020-07-21, Version 10.22.0 'Dubnium' (LTS), @BethGriggs prepared by @richardlau
Notable changes
- deps:
- upgrade npm to 6.14.6 (claudiahdz) #34246
- upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32982
- n-api:
- add
napi_detach_arraybuffer (legendecas) #29768
Commits
- [
9915774d18] - build: log detected compilers in --verbose mode (Richard Lau) #32715
- [
145dcc2c1c] - build: move doc versions JSON file out of out/doc (Richard Lau) #32728
- [
24b927ab66] - build: allow clang 10+ in configure.py (Kamil Rytarowski) #29541
- [
97b59527c7] - deps: upgrade npm to 6.14.6 (claudiahdz) #34246
- [
84fca3c691] - deps: upgrade npm to 6.14.5 (Ruy Adorno) #33239
- [
745b329260] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #32982
- [
94702c1560] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32982
- [
ef9413be1a] - deps: upgrade openssl sources to 1.1.1f (Hassaan Pasha) #32583
- [
3acc89f8f2] - deps: V8: backport cd21f71f9cb5 (Michaël Zasso) #33862
- [
89a306bca9] - deps: fix V8 compiler error with clang++-11 (Sam Roberts) #33094
- [
00f04e3b79] - doc: fix quotes in tls.md (Sparsh Garg) #33641
- [
193d1d0e84] - doc: document fs.watchFile() bigint option (cjihrig) #32128
- [
5dab101b03] - doc,n-api: mark napi_detach_arraybuffer as experimental (legendecas) #30703
- [
069b6e14a4] - http: disable headersTimeout check when set to zero (Paolo Insogna) #33307
- [
aaf2f827c6] - inspector: more conservative minimum stack size (Ben Noordhuis) #27855
- [
b744ffd586] - (SEMVER-MINOR) n-api: implement napi_is_detached_arraybuffer (Denys Otrishko) #30613
- [
961598b9be] - (SEMVER-MINOR) n-api: add napi_detach_arraybuffer (legendecas) #29768
- [
7a109febc4] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #32870
- [
3dbd8cd3a9] - Revert "test: mark empty udp tests flaky on OS X" (Luigi Pinca) #32489
- [
543656928c] - test: flaky test-stdout-close-catch on freebsd (Sam Roberts) #32849
- [
74b00cca64] - tls: allow empty subject even with altNames defined (Jason Macgowan) #22906
cc @nodejs/releasers
Checklist
-
make -j4 test (UNIX), or vcbuild test (Windows) passes
- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fixes: #33040
error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to
'bool' in initializer list [-Wc++11-narrowing]
ParameterList result{{}, {}, context->VARARGS(), {}};
Occurs twice:
../../deps/v8/src/torque/ast-generator.cc:123:32:
../../deps/v8/src/torque/ast-generator.cc:144:32:
PR-URL: #33094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
[parser] Validate destructuring assignment pattern in correct classifier
Previously we'd first accumulate errors to the parent and validate the
destructuring pattern in the parent. In the case of ParseArguments this
will invalidly propagate binding pattern errors from one argument to the
next. The reason why ParseArguments keeps track of binding pattern errors
is because it could also be used to parse async arrow function parameters.
If we see async(a,b) we don't yet know whether this is the head of an
async arrow function, or a call to async with arguments a and b.
Bug: v8:8241
Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1296229
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56887}
Refs: v8/v8@cd21f71
Fixes: #23142
PR-URL: #33862
Reviewed-By: Richard Lau <[email protected]>
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.
Backport-PR-URL: #33720
PR-URL: #27855
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
$ mv openssl-1.1.0h openssl
$ git add --all openssl
$ git commit openssl
Backport-PR-URL: #32982
PR-URL: #32583
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
$ mv openssl-1.1.1g openssl
$ git add --all openssl
$ git commit openssl
PR-URL: #32982
Reviewed-By: Richard Lau <[email protected]>
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ cd deps/openssl/config
$ make
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: #32982
Reviewed-By: Richard Lau <[email protected]>
Behavior described in #11771
is still true even though the issue is closed.
This PR is to allow DNS and URI names, even when there is not a subject.
Refs: #11771
PR-URL: #22906
Reviewed-By: James M Snell <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
codebytere
commented
Jul 3, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@richardlau in the release commit we want plaintext, so i think we may want to change to :
Notable changes:
deps:
* upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982
n-api:
* add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768
(no idea why gh is highlighting the pull link, if you hit edit on this comment you'll see the correct formatting)
|
richardlau reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 4, 2020
This was referenced Jul 10, 2020
|
I'm waiting for the CI to complete for #34246 before landing it on master, but since the npm update fixes a low severity security advisory (GHSA-93f3-23rq-pjfp) I'm proposing we pull it into the v10.22.0 release as we don't have another 10.x release planned in the near future. This would be ahead of our usual policy of a change being released in current for two weeks before going into an LTS release. We're proposing releasing Node.js v10.22.0 on 21 July by which time the npm release will have been out in the wild (not in a Node.js release but for anything out there using the latest npm version) for two weeks.
Thoughts/objections? @nodejs/lts
|
BethGriggs reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
richardlau
added a commit
that referenced
this pull request
Jul 13, 2020
Notable changes:
- deps:
- upgrade npm to 6.14.6 (claudiahdz)
#34246
- upgrade openssl sources to 1.1.1g (Hassaan Pasha)
#32982
- n-api:
- add `napi_detach_arraybuffer` (legendecas)
#29768
PR-URL: #34170
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
If the bug this test is intented to catch is reintroduced, or if
5aac4c4 is effectively reverted, many
(50+) tests time out, rendering this test redundant and unnecessary.
in particular, the following timer tests catch an effective revert of
5aac4c4:
not ok 21 parallel/test-timers-api-refs
not ok 22 parallel/test-timers-args
not ok 23 parallel/test-timers-destroyed
not ok 25 parallel/test-timers-nested
not ok 26 parallel/test-timers-interval-throw
not ok 28 parallel/test-timers-non-integer-delay
not ok 32 parallel/test-timers-ordering
not ok 33 parallel/test-timers-refresh
not ok 34 parallel/test-timers-refresh-in-callback
not ok 35 parallel/test-timers-reset-process-domain-on-throw
not ok 40 parallel/test-timers-timeout-to-interval
not ok 41 parallel/test-timers-uncaught-exception
not ok 42 parallel/test-timers-timeout-with-non-integer
not ok 43 parallel/test-timers-unenroll-unref-interval
not ok 44 parallel/test-timers-unref
not ok 45 parallel/test-timers-unref-active
not ok 46 parallel/test-timers-unrefd-interval-still-fires
not ok 47 parallel/test-timers-unrefed-in-callback
not ok 48 parallel/test-timers-user-call
not ok 49 parallel/test-timers-zero-timeout
Refs: #21781
PR-URL: #32870
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Notable changes:
- deps:
- upgrade npm to 6.14.6 (claudiahdz)
#34246
- upgrade openssl sources to 1.1.1g (Hassaan Pasha)
#32982
- n-api:
- add `napi_detach_arraybuffer` (legendecas)
#29768
PR-URL: #34170
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
CITGM analysis
Using nodejs/node-core-utils#455 to highlight modules that failed in the CITGM run for this PR vs a CITGM run for the current v10.x:
-bash-4.2$ npx -p codebytere/node-core-utils#allow-citgm-comparison ncu-ci citgm 2421 2417
npx: installed 348 in 18.855s
--------------------------------------------------------------------------------
[1/1] Running CITGM: 2421
--------------------------------------------------------------------------------
✔ Summary data downloaded
✔ Results data downloaded
✔ Summary data downloaded
✔ Results data downloaded
----------------------------------- Summary ------------------------------------
Result FAILURE
URL https://ci.nodejs.org/job/citgm-smoker/2421/
Source https://api.github.com/repos/nodejs/node/git/refs/heads/v10.x
Commit [0bd44b4a88b7] Working on v10.21.1
Date 2020-06-02 18:57:33 +0100
Author Bethany.Griggs <[email protected]>
----------------------------------- Summary ------------------------------------
Result FAILURE
URL https://ci.nodejs.org/job/citgm-smoker/2417/
Source https://api.github.com/repos/nodejs/node/git/refs/heads/v10.22.0-proposal
Commit [c5215d0b3da0] 2020-07-21, Version 10.22.0 'Dubnium' (LTS)
Date 2020-07-15 11:27:18 -0400
Author Richard Lau <[email protected]>
----------------------------------- Results ------------------------------------
FAILURE: 9 failures in 2417 not present in 2421
┌────────────────────────┬─────────────────────┬──────────────────┐
│ (index) │ 0 │ 1 │
├────────────────────────┼─────────────────────┼──────────────────┤
│ aix71-ppc64 │ 'ember-cli-v3.19.0' │ │
│ ubuntu1804-64 │ │ │
│ fedora-last-latest-x64 │ 'spawn-wrap-v2.0.0' │ 'winston-v3.3.3' │
│ osx1014 │ 'fastify-v3.0.3' │ │
│ ubuntu1404-64 │ │ │
│ rhel7-s390x │ 'uglify-js-v3.10.0' │ │
│ osx1015 │ │ │
│ centos7-ppcle │ 'ember-cli-v3.19.0' │ 'multer-v1.4.2' │
│ ubuntu1604-64 │ 'clinic-v6.0.2' │ 'yargs-v15.4.1' │
│ debian9-64 │ │ │
│ fedora-latest-x64 │ │ │
└────────────────────────┴─────────────────────┴──────────────────┘
-bash-4.2$
The clinic-v6.0.2, ember-cli-v3.19.0, fastify-v3.0.3, spawn-wrap-v2.0.0 and yargs-v15.4.1 failures also occurred on other platforms in the CITGM run for v10.x.
Which leaves multer-v1.4.2, uglify-js-v3.10.0 and winston-v3.3.3.
multer-v1.4.2 failures were also seen in a nobuild CITGM job with v10.21.0: https://ci.nodejs.org/job/citgm-smoker-nobuild/870/.
uglify-js-v3.10.0 and winston-v3.3.3 didn't reoccur in a CITGM rerun on the same commit (c5215d0) for this PR: https://ci.nodejs.org/job/citgm-smoker/2427
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
BethGriggs
pushed a commit
that referenced
this pull request
Jul 21, 2020
Notable changes:
- deps:
- upgrade npm to 6.14.6 (claudiahdz)
#34246
- upgrade openssl sources to 1.1.1g (Hassaan Pasha)
#32982
- n-api:
- add `napi_detach_arraybuffer` (legendecas)
#29768
PR-URL: #34170
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Notable changes:
- deps:
- upgrade npm to 6.14.6 (claudiahdz)
#34246
- upgrade openssl sources to 1.1.1g (Hassaan Pasha)
#32982
- n-api:
- add `napi_detach_arraybuffer` (legendecas)
#29768
PR-URL: #34170
Reviewers
+1 more reviewer
mhdawson
mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Labels
meta
Issues and PRs related to the general management of the project.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|