GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add an indicator `isIBMi` by dmabupt · Pull Request #30714 · nodejs/node

Conversation

@dmabupt

@dmabupt dmabupt commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 29, 2019
targos
targos reviewed Nov 29, 2019
View reviewed changes
Comment thread test/common/index.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The function/property/whatever-it-ends-up-being should be added to test/common/index.mjs too, I think.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig reviewed Nov 29, 2019
View reviewed changes
Comment thread test/common/index.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/common/index.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 29, 2019

Copy link
Copy Markdown
Member

The property added here would also need to be documented in test/common/README.md.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thinking about this more, I wonder if the thing to do for now is don't even add it to common. It's only used in one test, so just put the check in the test itself. If we find we need to do this in more places, it can be extracted into common at that time.
lundibundi and sam-github reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sam-github
sam-github reviewed Nov 29, 2019
View reviewed changes
Comment thread test/parallel/test-cluster-bind-privileged-port.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

I agree, just testing os.type() in the single affected test is the thing to do here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Nov 29, 2019

Copy link
Copy Markdown
Member

@sam-github thanks for checking that out and I agree with:

I agree, just testing os.type() in the single affected test is the thing to do here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dmabupt

dmabupt commented Nov 30, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There will be more test cases to be skipped in future since some APIs are not supported by IBM i yet, like fs.watch(). And I am working on the list right now. So this is just an initial commit to add this flag to be used in future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sam-github
sam-github reviewed Nov 30, 2019
View reviewed changes
Comment thread test/common/index.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
sam-github
sam-github approved these changes Nov 30, 2019
View reviewed changes

@sam-github sam-github left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the inconsistent spelling of IBMi this looks OK to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott previously requested changes Nov 30, 2019
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to index.mjs too. (Feel free to clear this request for changes once that's done.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dmabupt
test: add an indicator isIBMi
1cf3c57 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.
@dmabupt
dmabupt requested a review from Trott December 1, 2019 13:28
@nodejs-github-bot

nodejs-github-bot commented Dec 1, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27253/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Dec 1, 2019
View reviewed changes
@targos
targos dismissed Trott’s stale review December 1, 2019 17:23

addressed

jasnell
jasnell approved these changes Dec 1, 2019
View reviewed changes
richardlau
richardlau approved these changes Dec 1, 2019
View reviewed changes
cjihrig
cjihrig approved these changes Dec 1, 2019
View reviewed changes
richardlau pushed a commit that referenced this pull request Dec 2, 2019
@dmabupt @richardlau
test: add an indicator isIBMi
f0a31e5 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@richardlau

richardlau commented Dec 2, 2019

Copy link
Copy Markdown
Member

Landed in f0a31e5.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Dec 2, 2019
@dmabupt
dmabupt deleted the ibmi_test branch December 3, 2019 04:34
targos pushed a commit that referenced this pull request Dec 3, 2019
@dmabupt @targos
test: add an indicator isIBMi
81d81a5 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
v13.3.0 proposal #30774
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@dmabupt @targos
test: add an indicator isIBMi
8204a74 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@dmabupt dmabupt mentioned this pull request Dec 6, 2019
test: skip the unsupported test cases for IBM i #30819
Closed
2 tasks
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
v12.13.2 proposal #30865
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@dmabupt @MylesBorins
test: add an indicator isIBMi
197b616 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
v12.14.1 proposal #31069
Merged
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
@dmabupt @BridgeAR
test: skip the unsupported test cases for IBM i
262c66a 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@dmabupt @BethGriggs
test: add an indicator isIBMi
6105a41 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@dmabupt @BridgeAR
test: skip the unsupported test cases for IBM i
e28e873 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@dmabupt @targos
test: skip the unsupported test cases for IBM i
9c9138f 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@dmabupt @BethGriggs
test: skip the unsupported test cases for IBM i
c7dafd8 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments
@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@Trott Trott Awaiting requested review from Trott
+3 more reviewers
@mhdawson mhdawson mhdawson left review comments
@sam-github sam-github sam-github approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@dmabupt @Trott @sam-github @mhdawson @nodejs-github-bot @richardlau @jasnell @addaleax @targos @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.