GeezerVison

@dmabupt This is a Draft, so you should say what needs to be done to make it complete.

I assume that all the // TODO comments for example you intend to investigate and resolve them before requesting merge?

@dmabupt This is a Draft, so you should say what needs to be done to make it complete.

I assume that all the // TODO comments for example you intend to investigate and resolve them before requesting merge?

Yes, I am investigating the // TODO cases. And I just added the descriptions of what needs to be done.

A suggestion regarding all of the common.skip()'s with TODO's -- If these are temporary with the intention to be investiagted and fixed later then another way might be to use the status files, e.g. (example with AIX)

A suggestion regarding all of the common.skip()'s with TODO's -- If these are temporary with the intention to be investiagted and fixed later then another way might be to use the status files, e.g. (example with AIX)

node/test/sequential/sequential.status

Lines 21 to 23 in 4ec02d5

	[$system==aix]
	# https://github.com/nodejs/node/pull/29054
	test-buffer-creation-regression: SKIP

This would list all of them in one place (for each test bucket) and would mean the affected test files wouldn't need to be changed here. Would need IBMi detection to be added to

node/tools/utils.py

Lines 46 to 69 in 4ec02d5

	def GuessOS():
	id = platform.system()
	if id == 'Linux':
	return 'linux'
	elif id == 'Darwin':
	return 'macos'
	elif id.find('CYGWIN') >= 0:
	return 'cygwin'
	elif id == 'Windows' or id == 'Microsoft':
	# On Windows Vista platform.system() can return 'Microsoft' with some
	# versions of Python, see http://bugs.python.org/issue1082
	return 'win32'
	elif id == 'FreeBSD':
	return 'freebsd'
	elif id == 'OpenBSD':
	return 'openbsd'
	elif id == 'SunOS':
	return 'solaris'
	elif id == 'NetBSD':
	return 'netbsd'
	elif id == 'AIX':
	return 'aix'
	else:
	return None

GuessOS()

That is great.
The only concern is that GuessOS() returns either aix or os400. If let it return the real OS name, will it affect other modules reusing the aix code?

GuessOS()

That is great.
The only concern is that GuessOS() returns either aix or os400. If let it return the real OS name, will it affect other modules reusing the aix code?

GuessOS() in tools/utils.py is only used to match things in the test *.status files. I think for IBMi it should return os400 (or ibmi, your choice). If there are existing tests that have entries in the status file for [$system==aix] that should also apply to IBMi we should just duplicate them for [$system==os400] (or [$system==ibmi]).

Seems this test case failed?

=== release test-process-env-allowed-flags-are-documented ===
Path: parallel/test-process-env-allowed-flags-are-documented
--- stderr ---
assert.js:99
  throw new AssertionError(obj);
  ^
AssertionError [ERR_ASSERTION]: The following options are documented as allowed in NODE_OPTIONS in /home/travis/build/nodejs/node/doc/api/cli.md: --insecure-http-parser but are not in process.allowedNodeEnvironmentFlags

Seems this test case failed?

=== release test-process-env-allowed-flags-are-documented ===
Path: parallel/test-process-env-allowed-flags-are-documented
--- stderr ---
assert.js:99
  throw new AssertionError(obj);
  ^
AssertionError [ERR_ASSERTION]: The following options are documented as allowed in NODE_OPTIONS in /home/travis/build/nodejs/node/doc/api/cli.md: --insecure-http-parser but are not in process.allowedNodeEnvironmentFlags

I think that's a race condition between 02a0c74 landing on master and the last update to the commits in this PR. I've restarted the Travis CI.

CI: https://ci.nodejs.org/job/node-test-pull-request/27915/

CI: https://ci.nodejs.org/job/node-test-pull-request/27933/

Landed in 262c66a, bbc032d 🎉