GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add an example for util.types.isExternal by HarshithaKP · Pull Request #31173 · nodejs/node

Conversation

@HarshithaKP

@HarshithaKP HarshithaKP commented Jan 3, 2020

Copy link
Copy Markdown
Member

added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

Fixes: #20604

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module. labels Jan 3, 2020
jasnell
jasnell reviewed Jan 3, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR reviewed Jan 3, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax reviewed Jan 4, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
HarshithaKP added a commit to HarshithaKP/node that referenced this pull request Jan 6, 2020
@HarshithaKP
doc: explain native external types
3da691b 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: nodejs#31173 (comment)
@HarshithaKP HarshithaKP mentioned this pull request Jan 6, 2020
doc: explain native external types #31214
Closed
2 of 4 tasks
addaleax
addaleax reviewed Jan 6, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Jan 6, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 6, 2020
Trott
Trott reviewed Jan 6, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil pushed a commit that referenced this pull request Jan 8, 2020
@HarshithaKP @gireeshpunathil
doc: explain native external types
95871a1 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
antsmartian
antsmartian approved these changes Jan 8, 2020
View reviewed changes
@HarshithaKP
doc: add an example for util.types.isExternal
aa6096d 
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

Fixes: nodejs#20604
@HarshithaKP
HarshithaKP force-pushed the utils.types.isExternal_example branch from 3051444 to aa6096d Compare January 10, 2020 12:55
@HarshithaKP

HarshithaKP commented Jan 10, 2020

Copy link
Copy Markdown
Member Author

Ping @addaleax @Trott @jasnell, please take a look. I just rebased.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Jan 10, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 10, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @addaleax's nits

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 11, 2020
@HarshithaKP
fixup: address review comments
a4648ee
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 13, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
@HarshithaKP @BridgeAR
doc: add an example for util.types.isExternal
f4a4a1a 
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

PR-URL: #31173
Fixes: #20604
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR

BridgeAR commented Jan 13, 2020

Copy link
Copy Markdown
Member

Landed in f4a4a1a 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@HarshithaKP @MylesBorins
doc: explain native external types
c1333ea 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@HarshithaKP @MylesBorins
doc: add an example for util.types.isExternal
bb9622b 
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

PR-URL: #31173
Fixes: #20604
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@HarshithaKP @codebytere
doc: explain native external types
6cfc4dc 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@HarshithaKP @codebytere
doc: add an example for util.types.isExternal
c2b0929 
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

PR-URL: #31173
Fixes: #20604
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@HarshithaKP @codebytere
doc: add an example for util.types.isExternal
6598a08 
added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

PR-URL: #31173
Fixes: #20604
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@antsmartian antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify util.types.isExternal

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@HarshithaKP @BridgeAR @jasnell @Trott @addaleax @antsmartian @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.