GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: explain native external types by HarshithaKP · Pull Request #31214 · nodejs/node

Conversation

@HarshithaKP

@HarshithaKP HarshithaKP commented Jan 6, 2020

Copy link
Copy Markdown
Member

There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@HarshithaKP
doc: explain native external types
3da691b 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: nodejs#31173 (comment)
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module. labels Jan 6, 2020
@HarshithaKP HarshithaKP mentioned this pull request Jan 6, 2020
doc: add an example for util.types.isExternal #31173
Closed
2 of 4 tasks
jasnell
jasnell reviewed Jan 6, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the wip Issues and PRs that are still a work in progress. label Jan 6, 2020
@HarshithaKP
fixup: address review comment
ccb8109
@BridgeAR BridgeAR removed the wip Issues and PRs that are still a work in progress. label Jan 7, 2020
BridgeAR
BridgeAR approved these changes Jan 7, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 7, 2020
Trott
Trott reviewed Jan 7, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Jan 7, 2020
View reviewed changes
Comment thread doc/api/util.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 7, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Jan 8, 2020
View reviewed changes
@HarshithaKP
fixup: address review comments
c9a6bea
gireeshpunathil
gireeshpunathil approved these changes Jan 8, 2020
View reviewed changes
@gireeshpunathil

gireeshpunathil commented Jan 8, 2020

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4121/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@HarshithaKP
fixup: add back removed line.
454be73
@gireeshpunathil

gireeshpunathil commented Jan 8, 2020

Copy link
Copy Markdown
Member

rebuild Ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4122
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil pushed a commit that referenced this pull request Jan 8, 2020
@HarshithaKP @gireeshpunathil
doc: explain native external types
95871a1 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@mscdex

mscdex commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

@gireeshpunathil These commits just got pushed to master as-is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil

gireeshpunathil commented Jan 8, 2020

Copy link
Copy Markdown
Member

@mscdex - saw the mistake, corrected it now. thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil

gireeshpunathil commented Jan 8, 2020

Copy link
Copy Markdown
Member

landed in 95871a1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Jan 8, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@HarshithaKP @MylesBorins
doc: explain native external types
c1333ea 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@HarshithaKP @codebytere
doc: explain native external types
6cfc4dc 
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@HarshithaKP @gireeshpunathil @mscdex @jasnell @Trott @cjihrig @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.