GeezerVison

CI: https://ci.nodejs.org/job/node-test-pull-request/28552/

https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/32389/consoleFull (Thanks @BethGriggs for kicking it off) failed the PR test job due to the failure shown below with test-http2-reset-fllood. Since this PR only changes tests it seems likely that this is a machine specific issue, or I was just unlucky on an intermittent test (It's known flakey on FreeBSD as per #29802 - perhaps #30534 will assist with this - although if it's already been backported - it's called out in #31368 - then perhaps that hasn't fixed it!). Other platforms/Linux distributions that have completed as I write this have not failed in the same way as per https://ci.nodejs.org/job/node-test-commit/35039/console

22:28:15 not ok 1169 parallel/test-http2-reset-flood
22:28:15   ---
22:28:15   duration_ms: 0.328
22:28:15   severity: fail
22:28:15   exitcode: 1
22:28:15   stack: |-
22:28:15     events.js:298
22:28:15           throw er; // Unhandled 'error' event
22:28:15           ^
22:28:15     
22:28:15     Error: This socket has been ended by the other party
22:28:15         at Socket.writeAfterFIN [as write] (net.js:451:14)
22:28:15         at Immediate.writeRequests (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64-gcc6/test/parallel/test-http2-reset-flood.js:72:12)
22:28:15         at processImmediate (internal/timers.js:456:21)
22:28:15     Emitted 'error' event on Socket instance at:
22:28:15         at emitErrorNT (net.js:1336:8)
22:28:15         at processTicksAndRejections (internal/process/task_queues.js:84:21) {
22:28:15       code: 'EPIPE'
22:28:15     }
22:28:15   ...

CI: https://ci.nodejs.org/job/node-test-pull-request/28555/

CI: https://ci.nodejs.org/job/node-test-pull-request/28559/

All comments addressed @BridgeAR if you want to take another look.

CI: https://ci.nodejs.org/job/node-test-pull-request/28559/

This passed although doesn't include my latest (minor) tweak to address review comments

I've rebased against v12.x to fixed conflicts.

CI: https://ci.nodejs.org/job/node-test-pull-request/28788/

rebased

CI: https://ci.nodejs.org/job/node-test-pull-request/30315/
Rerun bsd: https://ci.nodejs.org/job/node-test-commit-freebsd/32478/

BSD failure might be known flake

#29802
#32595

landed in d568efc

Thanks @MylesBorins - I hadn't got back to doing the rebase after the release went out as it looked rather non-trivial to redo with the modified history on this one, but should be a good one to get in.

@sxa555 it is landed and in!

FWIW I made a new branch off of staging and cherry-picked your initial commit (rather than rebasing). There was only a single conflict, so it was rather straight forward all things considered