GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark test-http2-reset-flood flaky on bsd by MylesBorins · Pull Request #32595 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins
test: mark test-http2-reset-flood flaky on bsd
8ac6e3c 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: nodejs#29802
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 1, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30321/ (:heavy_check_mark:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins mentioned this pull request Apr 1, 2020
[v12.x backport] test: refactor common.expectsError #31449
Closed
2 tasks done
richardlau
richardlau approved these changes Apr 1, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Apr 1, 2020
View reviewed changes
@MylesBorins

MylesBorins commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

Fast-track?
cjihrig and addaleax reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 1, 2020
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020
@MylesBorins
test: mark test-http2-reset-flood flaky on bsd
9d82c55 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins

MylesBorins commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

landed in 9d82c55
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins closed this Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020
@MylesBorins
test: mark test-http2-reset-flood flaky on bsd
e4f9360 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Apr 3, 2020
v12.16.2 proposal #32313
Merged
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@MylesBorins @BethGriggs
test: mark test-http2-reset-flood flaky on bsd
bf0b61f 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@MylesBorins @targos
test: mark test-http2-reset-flood flaky on bsd
28077a0 
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@sam-github sam-github mentioned this pull request Apr 13, 2020
test: mark test-http2-reset-flood flaky on all #32825
Closed
4 tasks
sam-github added a commit to sam-github/node that referenced this pull request Apr 13, 2020
@sam-github
test: mark test-http2-reset-flood flaky on all
9f95bea 
Refs: nodejs#29802
Refs: nodejs#32595
sam-github added a commit that referenced this pull request Apr 14, 2020
@sam-github
test: mark test-http2-reset-flood flaky on all
a12aedf 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
@sam-github @MylesBorins
test: mark test-http2-reset-flood flaky on all
4b5658b 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@sam-github @targos
test: mark test-http2-reset-flood flaky on all
41c22a9 
Refs: nodejs#29802
Refs: nodejs#32595

PR-URL: nodejs#32825
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @BridgeAR
test: mark test-http2-reset-flood flaky on all
98db564 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @targos
test: mark test-http2-reset-flood flaky on all
44ca479 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MylesBorins @nodejs-github-bot @cjihrig @richardlau @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.