GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add GC test for disabled AsyncLocalStorage by puzpuzpuz · Pull Request #31995 · nodejs/node

Conversation

@puzpuzpuz

@puzpuzpuz puzpuzpuz commented Feb 28, 2020

Copy link
Copy Markdown
Member

Adds a GC test for AsyncLocalStorage to verify behavior described in the docs.

cc @vdeturckheim @Qard @Flarna

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Feb 28, 2020
addaleax
addaleax approved these changes Feb 28, 2020
View reviewed changes
@addaleax

addaleax commented Feb 28, 2020

Copy link
Copy Markdown
Member

Fast-track? It adds a relatively straightforward new test.
gireeshpunathil, Qard, vdeturckheim, and mhdawson reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Feb 28, 2020
View reviewed changes
Qard
Qard approved these changes Feb 28, 2020
View reviewed changes
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29427/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vdeturckheim
vdeturckheim approved these changes Feb 28, 2020
View reviewed changes
Flarna
Flarna approved these changes Feb 28, 2020
View reviewed changes
@puzpuzpuz

puzpuzpuz commented Feb 28, 2020

Copy link
Copy Markdown
Member Author

Looks like tests are flaky. As far as I can see, failed tests are not related with this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29469/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

Another flaky CI run 😢. Could someone re-run it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29477/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29481/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@puzpuzpuz
test: add GC test for disabled AsyncLocalStorage
e4f1c18
@puzpuzpuz
puzpuzpuz force-pushed the async-storage-gcable-test branch from 8756024 to e4f1c18 Compare March 2, 2020 14:12
@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

I have rebased over the latest master. Maybe those flaky tests are fixed and it would help CI build to pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29484/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

Another flaky CI run here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 2, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29493/
puzpuzpuz reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

Looks like this one is ready to land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Mar 2, 2020
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson

mhdawson commented Mar 2, 2020

Copy link
Copy Markdown
Member

Landing now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson pushed a commit that referenced this pull request Mar 2, 2020
@puzpuzpuz @mhdawson
test: add GC test for disabled AsyncLocalStorage
96e70c4 
PR-URL: #31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Mar 2, 2020

Copy link
Copy Markdown
Member

Landed as 96e70c4
puzpuzpuz reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Mar 2, 2020
@puzpuzpuz
puzpuzpuz deleted the async-storage-gcable-test branch March 3, 2020 08:34
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
@puzpuzpuz @MylesBorins
test: add GC test for disabled AsyncLocalStorage
1539928 
PR-URL: #31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
v13.10.1 proposal #32099
Merged
@codebytere

codebytere commented Mar 16, 2020

Copy link
Copy Markdown
Member

Blocked on #26540.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere added the backport-blocked-v12.x label Mar 16, 2020
@puzpuzpuz puzpuzpuz mentioned this pull request Mar 17, 2020
[v12.x backport] async_hooks: add AsyncLocalStorage #32318
Closed
4 tasks done
@puzpuzpuz

puzpuzpuz commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

v12 backport: #32318
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added backported-to-v12.x and removed backport-blocked-v12.x labels Mar 17, 2020
puzpuzpuz added a commit to puzpuzpuz/node that referenced this pull request Apr 14, 2020
@puzpuzpuz
test: add GC test for disabled AsyncLocalStorage
ecc5935 
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@puzpuzpuz @targos
test: add GC test for disabled AsyncLocalStorage
c759d65 
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@puzpuzpuz @targos
test: add GC test for disabled AsyncLocalStorage
52a1154 
PR-URL: #31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@Flarna Flarna Flarna approved these changes
+2 more reviewers
@vdeturckheim vdeturckheim vdeturckheim approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@puzpuzpuz @addaleax @nodejs-github-bot @mhdawson @codebytere @Qard @jasnell @gireeshpunathil @vdeturckheim @Flarna @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.