GeezerVison is showing github.com — v13.10.1 proposal by MylesBorins · Pull Request #32099 · nodejs/node
Conversation
MylesBorins
commented
Mar 4, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
2020-03-04, Version 13.10.1 (Current), @MylesBorins
Notable Changes
In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change
had the unforseen consequence of breaking building from the tarballs we release as we were too
aggressively removing unneccessary files from the deps/zlib folder. This release includes
a patch that ensures that individuals will once again be able to build Node.js from source.
Commits
- [
723aa41d96] - build: fix zlib tarball generation (Shelley Vohr) #32094
- [
9c1ac50fc5] - build: fix building with ninja (Richard Lau) #32071
- [
478450d6b3] - build: add asan check in Github action (gengjiawen) #31902
- [
0fc45f80b5] - crypto: simplify exportKeyingMaterial (Tobias Nießen) #31922
- [
4dc59b91a7] - dgram: make UDPWrap more reusable (Anna Henningsen) #31871
- [
4ed720e940] - doc: visibility of Worker threads cli options (Harshitha KP) #31380
- [
2518213a1b] - doc: improve doc/markdown file organization coherence (ConorDavenport) #31792
- [
ba3f7ff94d] - doc: update stream.pipeline() signature (vsemozhetbyt) #31789
- [
3c8daa3aa0] - events: convert errorMonitor to a normal property (Gerhard Stoebich) #31848
- [
6b44df2415] - perf,src: add HistogramBase and internal/histogram.js (James M Snell) #31988
- [
6a9cea9ed2] - src: pass resource object along with InternalMakeCallback (Anna Henningsen) #32063
- [
70f046010c] - src: start the .text section with an asm symbol (Gabriel Schulhof) #31981
- [
755da035ce] - src: add node_crypto_common and refactor (James M Snell) #32016
- [
4d5318c164] - src: improve handling of internal field counting (James M Snell) #31960
- [
1539928ed9] - test: add GC test for disabled AsyncLocalStorage (Andrey Pechkurov) #31995
- [
be90817558] - test: remove common.port from test-tls-securepair-client (Rich Trott) #32024
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss and dnalborczyk reacted with thumbs up emoji
bricss reacted with heart emoji
bricss, jasnell, dnalborczyk, and patrolez reacted with rocket emoji
bricss reacted with eyes emoji
All reactions
-
👍
2 reactions
-
❤️
1 reaction
-
🚀
4 reactions
-
👀
1 reaction
Separating this out from the QUIC PR to allow it to be separately
reviewed. The QUIC implementation makes use of the hdr_histogram
for dynamic performance monitoring. This introduces a BaseObject
class that allows the internal histograms to be accessed on the
JavaScript side and adds a generic Histogram class that will be
used by both QUIC and perf_hooks (for the event loop delay
monitoring).
Signed-off-by: James M Snell <[email protected]>
PR-URL: #31988
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
OpenSSL s_server accepts port 0 as an indicator to use an open port
provided by the operating system. Use that instead of common.PORT in the
test.
Remove 500ms delay added in 8e46167.
Hopefully the race condition in OpenSSL s_server has been fixed and/or
the change to port 0 means that the server is listening by the time
the ACCEPT text is printed and the setTimeout() is no longer necessary.
PR-URL: #32024
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Two things in one on this commit:
(a) For the QUIC implementation, we need to separate out various bits
from node_crypto.cc to allow them to be reused. That's where this
commit starts.
(b) Quite a bit of the node_crypto.cc code was just messy in terms of
it's organization and lack of error handling and use of Local vs.
MaybeLocal. This cleans that up a bit and hopefully makes certain
parts a bit more manageable also.
Signed-off-by: James M Snell <[email protected]>
PR-URL: #32016
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
We create an object file in assembly which introduces the symbol
`__node_text_start` into the .text section and place the resulting
object file as the first file the linker encounters. We do this to
ensure that we can recognize the boundaries of the .text section when
attempting to establish the address range to map to large pages.
Additionally, we rename the section containing the remapping code from
`.lpstub` to `lpstub` so as to take advantage of the linker's feature
whereby it inserts the symbol `__start_lpstub` when the section's name
can be rendered as a valid C variable. We need this symbol in order to
avoid self-mapping the remapping code to large pages, because doing so
would cause the process to crash.
PR-URL: #31981
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
* Updated cpp style guide file name and location and fixed links to
this file.
* Updated collaborator guide file name and location and fixed links
to this file.
* Updated documentation style guide file name and location and updated
links referencing the file.
* Moved files to appropriate location and updated naming style for
some of them.
Fixes: #31741
PR-URL: #31792
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MylesBorins
added a commit
that referenced
this pull request
Mar 4, 2020
Notable changes:
In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.
PR-URL: #32099
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Notable changes:
In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.
PR-URL: #32099
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29559/
edit from @MylesBorins:
The only failure on this CI run was arm. After a handful of runs we were able to get a green run on both centos arm64 and ubuntu arm64, the two platforms regularly flaky while testing this release.
I believe the issue we are running into is network related, but will make myself available for a quick follow up release if we actually broke anything. Also worth mentioning I was able to reproduce the failures on 13.10.0, so we can't be that much worse off pushing 13.10.1 than we are doing nothing 😅
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
richardlau and bricss reacted with laugh emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
So... I've been banging my head against CI for a little bit and I am going to make the executive decision to move forward even though we are seeing odd issues with arm 💀
After doing all the digging I can do with the tools available to me I strongly believe the issue to be network based. Further we've managed to get a green run on each platform at least once. I've put a more in depth explanation above
|
mmarchini reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
MylesBorins
added a commit
that referenced
this pull request
Mar 5, 2020
Notable changes:
In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.
PR-URL: #32099
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|