GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v13.10.1 proposal by MylesBorins · Pull Request #32099 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Mar 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

2020-03-04, Version 13.10.1 (Current), @MylesBorins

Notable Changes

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change
had the unforseen consequence of breaking building from the tarballs we release as we were too
aggressively removing unneccessary files from the deps/zlib folder. This release includes
a patch that ensures that individuals will once again be able to build Node.js from source.

Commits

  • [723aa41d96] - build: fix zlib tarball generation (Shelley Vohr) #32094
  • [9c1ac50fc5] - build: fix building with ninja (Richard Lau) #32071
  • [478450d6b3] - build: add asan check in Github action (gengjiawen) #31902
  • [0fc45f80b5] - crypto: simplify exportKeyingMaterial (Tobias Nießen) #31922
  • [4dc59b91a7] - dgram: make UDPWrap more reusable (Anna Henningsen) #31871
  • [4ed720e940] - doc: visibility of Worker threads cli options (Harshitha KP) #31380
  • [2518213a1b] - doc: improve doc/markdown file organization coherence (ConorDavenport) #31792
  • [ba3f7ff94d] - doc: update stream.pipeline() signature (vsemozhetbyt) #31789
  • [3c8daa3aa0] - events: convert errorMonitor to a normal property (Gerhard Stoebich) #31848
  • [6b44df2415] - perf,src: add HistogramBase and internal/histogram.js (James M Snell) #31988
  • [6a9cea9ed2] - src: pass resource object along with InternalMakeCallback (Anna Henningsen) #32063
  • [70f046010c] - src: start the .text section with an asm symbol (Gabriel Schulhof) #31981
  • [755da035ce] - src: add node_crypto_common and refactor (James M Snell) #32016
  • [4d5318c164] - src: improve handling of internal field counting (James M Snell) #31960
  • [1539928ed9] - test: add GC test for disabled AsyncLocalStorage (Andrey Pechkurov) #31995
  • [be90817558] - test: remove common.port from test-tls-securepair-client (Rich Trott) #32024

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and dnalborczyk reacted with thumbs up emoji bricss reacted with heart emoji bricss, jasnell, dnalborczyk, and patrolez reacted with rocket emoji bricss reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction
  • 🚀 4 reactions
  • 👀 1 reaction
vsemozhetbyt and others added 15 commits March 4, 2020 16:28
@vsemozhetbyt @MylesBorins
doc: update stream.pipeline() signature
ba3f7ff
The  `...transforms` parameter is optional.

Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132
Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators

PR-URL: #31789
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@tniessen @MylesBorins
crypto: simplify exportKeyingMaterial
0fc45f8
PR-URL: #31922
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@jasnell @MylesBorins
src: improve handling of internal field counting
4d5318c
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #31960
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@jasnell @MylesBorins
perf,src: add HistogramBase and internal/histogram.js
6b44df2
Separating this out from the QUIC PR to allow it to be separately
reviewed. The QUIC implementation makes use of the hdr_histogram
for dynamic performance monitoring. This introduces a BaseObject
class that allows the internal histograms to be accessed on the
JavaScript side and adds a generic Histogram class that will be
used by both QUIC and perf_hooks (for the event loop delay
monitoring).

Signed-off-by: James M Snell <[email protected]>

PR-URL: #31988
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@Trott @MylesBorins
test: remove common.port from test-tls-securepair-client
be90817
OpenSSL s_server accepts port 0 as an indicator to use an open port
provided by the operating system. Use that instead of common.PORT in the
test.

Remove 500ms delay added in 8e46167.
Hopefully the race condition in OpenSSL s_server has been fixed and/or
the change to port 0 means that the server is listening by the time
the ACCEPT text is printed and the setTimeout() is no longer necessary.

PR-URL: #32024
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@Flarna @MylesBorins
events: convert errorMonitor to a normal property
3c8daa3
Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: #30932 (comment)

PR-URL: #31848
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@puzpuzpuz @MylesBorins
test: add GC test for disabled AsyncLocalStorage
1539928
PR-URL: #31995
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell @MylesBorins
src: add node_crypto_common and refactor
755da03
Two things in one on this commit:

(a) For the QUIC implementation, we need to separate out various bits
    from node_crypto.cc to allow them to be reused. That's where this
    commit starts.

(b) Quite a bit of the node_crypto.cc code was just messy in terms of
    it's organization and lack of error handling and use of Local vs.
    MaybeLocal. This cleans that up a bit and hopefully makes certain
    parts a bit more manageable also.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32016
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Gabriel Schulhof @MylesBorins
src: start the .text section with an asm symbol
70f0460
We create an object file in assembly which introduces the symbol
`__node_text_start` into the .text section and place the resulting
object file as the first file the linker encounters. We do this to
ensure that we can recognize the boundaries of the .text section when
attempting to establish the address range to map to large pages.

Additionally, we rename the section containing the remapping code from
`.lpstub` to `lpstub` so as to take advantage of the linker's feature
whereby it inserts the symbol `__start_lpstub` when the section's name
can be rendered as a valid C variable. We need this symbol in order to
avoid self-mapping the remapping code to large pages, because doing so
would cause the process to crash.

PR-URL: #31981
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
@gengjiawen @MylesBorins
build: add asan check in Github action
478450d
PR-URL: #31902
Reviewed-By: Ben Noordhuis <[email protected]>
@addaleax @MylesBorins
dgram: make UDPWrap more reusable
4dc59b9
Allow using the handle more directly for I/O in other parts of
the codebase.

Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#165
  Reviewed-By: James M Snell <[email protected]>
  Reviewed-By: Daniel Bevenius <[email protected]>
```

Signed-off-by: James M Snell <[email protected]>

PR-URL: #31871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@richardlau @MylesBorins
build: fix building with ninja
9c1ac50
The ninja build places objects in a different directory.

Co-authored-by: Gabriel Schulhof <[email protected]>
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32071
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@DavenportEmma @MylesBorins
doc: improve doc/markdown file organization coherence
2518213
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@HarshithaKP @MylesBorins
doc: visibility of Worker threads cli options
4ed720e
Fixes: #28518
PR-URL: #31380
Fixes: #28518
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere @MylesBorins
build: fix zlib tarball generation
723aa41
PR-URL: #32094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. v13.x labels Mar 4, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
v13.9.0 tarball seems to be missing deps/zlib/contrib #31858
Closed
@MylesBorins
MylesBorins force-pushed the v13.10.1-proposal branch from c2807db to 0a1c440 Compare March 4, 2020 22:13
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@addaleax addaleax mentioned this pull request Mar 4, 2020
src: pass resource object along with InternalMakeCallback #32063
Closed
3 tasks done
@addaleax

This comment has been minimized.

Sign in to view
@addaleax @MylesBorins
src: pass resource object along with InternalMakeCallback
6a9cea9
This was an oversight in 9fdb6e6.
Fixing this is necessary to make `executionAsyncResource()` work
as expected.

Refs: #30959
Fixes: #32060

PR-URL: #32063
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Mar 4, 2020
@MylesBorins
2020-03-04 Version 13.10.1 (Current)
801b9a7
Notable changes:

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.

PR-URL: #32099
@MylesBorins
MylesBorins force-pushed the v13.10.1-proposal branch from 0a1c440 to 801b9a7 Compare March 4, 2020 22:23
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2020 •
edited by MylesBorins
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29555/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2292/
rc.0: https://nodejs.org/download/rc/v13.10.1-rc.0/

Arm rebuilds:

  • https://ci.nodejs.org/job/node-test-commit-arm-fanned/13606/ ✅
  • https://ci.nodejs.org/job/node-test-commit-arm/29794/
  • https://ci.nodejs.org/job/node-test-commit-arm/29796/

edit :Keep getting connection resets on arm. Unsure if this is an infrastructure issue. Reran complete CI suite to see if maybe we'll have better luck

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs reviewed Mar 4, 2020
View reviewed changes
Comment thread CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs reviewed Mar 4, 2020
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V13.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
2020-03-04 Version 13.10.1 (Current)
59ab6bf
Notable changes:

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.

PR-URL: #32099
@MylesBorins
MylesBorins force-pushed the v13.10.1-proposal branch from 69e0da6 to 59ab6bf Compare March 4, 2020 23:48
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2020 •
edited by MylesBorins
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29559/

edit from @MylesBorins:

The only failure on this CI run was arm. After a handful of runs we were able to get a green run on both centos arm64 and ubuntu arm64, the two platforms regularly flaky while testing this release.

I believe the issue we are running into is network related, but will make myself available for a quick follow up release if we actually broke anything. Also worth mentioning I was able to reproduce the failures on 13.10.0, so we can't be that much worse off pushing 13.10.1 than we are doing nothing 😅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau

richardlau commented Mar 4, 2020

Copy link
Copy Markdown
Member

https://nodejs.org/download/rc/v13.10.1-rc.0/ appears to be missing the source tarball.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins

MylesBorins commented Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

@richardlau it is still building 😅

richardlau and bricss reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs approved these changes Mar 5, 2020
View reviewed changes
@MylesBorins

MylesBorins commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

So... I've been banging my head against CI for a little bit and I am going to make the executive decision to move forward even though we are seeing odd issues with arm 💀

After doing all the digging I can do with the tools available to me I strongly believe the issue to be network based. Further we've managed to get a green run on each platform at least once. I've put a more in depth explanation above

mmarchini reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
MylesBorins merged commit 59ab6bf into v13.x Mar 5, 2020
MylesBorins added a commit that referenced this pull request Mar 5, 2020
@MylesBorins
Working on v13.10.2
6122620
PR-URL: #32099
MylesBorins added a commit that referenced this pull request Mar 5, 2020
@MylesBorins
2020-03-04 Version 13.10.1 (Current)
67d45fb
Notable changes:

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.

PR-URL: #32099
@MylesBorins MylesBorins mentioned this pull request Mar 5, 2020
blog: v13.10.1 release post nodejs/nodejs.org#3006
Merged
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Mar 5, 2020
@MylesBorins
blog: v13.10.1 release post (#3006)
fa91158
Refs: nodejs/node#32099
@richardlau

This comment has been minimized.

Sign in to view
@richardlau

This comment has been minimized.

Sign in to view
@addaleax
addaleax deleted the v13.10.1-proposal branch March 5, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

15 participants

@MylesBorins @nodejs-github-bot @addaleax @richardlau @BethGriggs @vsemozhetbyt @tniessen @jasnell @Trott @Flarna @puzpuzpuz @gengjiawen @DavenportEmma @HarshithaKP @codebytere
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.