GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: move free socket error handling to agent by ronag · Pull Request #32003 · nodejs/node

Conversation

@ronag

@ronag ronag commented Feb 28, 2020

Copy link
Copy Markdown
Member

The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the http Issues and PRs related to the http subsystem. label Feb 28, 2020
@ronag
ronag force-pushed the http-client-freesocket-error branch from 99d8e3e to 1f13aa4 Compare February 28, 2020 11:37
@ronag
ronag requested review from bnoordhuis, lundibundi and mcollina and removed request for lundibundi February 28, 2020 11:45
ronag
ronag commented Feb 28, 2020
View reviewed changes
Comment thread lib/_http_agent.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag commented Feb 28, 2020
View reviewed changes
Comment thread lib/_http_client.js Outdated

@ronag ronag Feb 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled at some point in a separate PR. If an error is scheduled in the nextTick then it would become unhandled.

It's always been a problem as far as I can see.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag
ronag requested a review from lpinca February 28, 2020 12:28
bnoordhuis
bnoordhuis reviewed Feb 28, 2020
View reviewed changes
Comment thread lib/_http_agent.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/_http_client.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Feb 28, 2020
View reviewed changes
jasnell
jasnell reviewed Mar 2, 2020
View reviewed changes
Comment thread lib/_http_client.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 2, 2020
View reviewed changes
Comment thread lib/_http_client.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina reviewed Mar 2, 2020
View reviewed changes
Comment thread lib/_http_agent.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/_http_client.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 7, 2020
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 9, 2020
@addaleax

addaleax commented Mar 9, 2020

Copy link
Copy Markdown
Member

@ronag This needs a rebase :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Mar 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@ronag This needs a rebase :)

Damn! I keep causing conflicts :D.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the http-client-freesocket-error branch 2 times, most recently from bbe1217 to 2a2c211 Compare March 9, 2020 13:08
ronag
ronag commented Mar 9, 2020
View reviewed changes
Comment thread lib/_http_client.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag requested review from bnoordhuis, jasnell and mcollina March 9, 2020 14:17
@ronag

ronag commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

@mcollina @jasnell I've significantly simplified and instead added TODO's, PTAL.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina reviewed Mar 9, 2020
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a CITGM run.

Is this going to affect https://www.npmjs.com/package/http-proxy-agent?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BridgeAR

BridgeAR commented Mar 9, 2020

Copy link
Copy Markdown
Member

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2300/ (queued)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29673/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 10, 2020
@ronag

ronag commented Mar 10, 2020

Copy link
Copy Markdown
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2301/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Mar 10, 2020

Copy link
Copy Markdown
Member Author

CITGM looks good
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Mar 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Is this going to affect npmjs.com/package/http-proxy-agent?

@mcollina: As far as I can see, no. It just calls socket.destroy() directly in 'free'.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 11, 2020
@ronag
ronag requested review from BridgeAR and addaleax March 11, 2020 07:05
@ronag

ronag commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

@nodejs/http
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
mcollina
mcollina approved these changes Mar 29, 2020
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30218/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 30, 2020
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

@ronag Looks like this needs to be rebased again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
http: move free socket error handling to agent
1772f20 
The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.
@ronag
ronag force-pushed the http-client-freesocket-error branch from b51610b to 1772f20 Compare March 30, 2020 06:47
@ronag

ronag commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

rebased
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30234/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30235/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 2bf0228
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@ronag @addaleax
http: move free socket error handling to agent
2bf0228 
The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

PR-URL: #32003
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@ronag @addaleax
http: move free socket error handling to agent
ff3615d 
The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

PR-URL: #32003
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@ronag @targos
http: move free socket error handling to agent
225ddd5 
The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

PR-URL: #32003
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@addaleax addaleax addaleax approved these changes
@lundibundi lundibundi Awaiting requested review from lundibundi
@lpinca lpinca Awaiting requested review from lpinca
@jasnell jasnell Awaiting requested review from jasnell
@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis
@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ronag @addaleax @BridgeAR @nodejs-github-bot @mcollina @bnoordhuis @jasnell @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.