GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v13.13.0 release proposal by targos · Pull Request #32813 · nodejs/node

Conversation

targos commented Apr 13, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Notable Changes

New file system APIs

Added a new function, fs.readv (with sync and promisified versions). This
function takes an array of ArrayBufferView elements and will write the data
it reads sequentially to the buffers (Sk Sajidul Kadir) #32356.
A new overload is available for fs.readSync, which allows to optionally pass
any of the offset, length and position parameters (Lucas Holmquist) #32460.

Other changes

dns:
- Added the dns.ALL flag, that can be passed to dns.lookup() with dns.V4MAPPED
  to return resolved IPv6 addresses as well as IPv4 mapped IPv6 addresses (murgatroid99) #32183.
http:
- The default maximum HTTP header size was changed from 8KB to 16KB (rosaxny) #32520.
n-api:
- Calls to napi_call_threadsafe_function from the main thread can now return
  the napi_would_deadlock status in certain circumstances (Gabriel Schulhof) #32689.
util:
- Added a new maxStrLength option to util.inspect, to control the maximum
  length of printed strings. Its default value is Infinity (rosaxny) #32392.
worker:
- Added support for passing a transferList along with workerData to the
  Worker constructor (Juan José Arboleda) #32278.

New core collaborators

With this release, we welcome three new Node.js core collaborators:

himself65 #32734.
flarna (Gerhard Stoebich) #32620.
mildsunrise (Alba Mendez) #32525.

Commits

[a25ceeff72] - async_hooks: use hasHooks function internally (rickyes) #32656
[b63223114b] - async_hooks: move to lazy destroy hook registration in AsyncResource (Andrey Pechkurov) #32429
[78b90d9bc4] - benchmark: fix error on server close in AsyncLocalStorage benchmark (Andrey Pechkurov) #32503
[b556670d55] - benchmark: use let instead of var in zlib (Daniele Belardi) #31794
[d8316654fb] - benchmark: use let instead of var in worker (Daniele Belardi) #31794
[f1d3fb067b] - benchmark: use let instead of var in util (Daniele Belardi) #31794
[148df0a743] - benchmark: use let instead of var in url (Daniele Belardi) #31794
[108e91fb85] - benchmark: use let instead of var in tls (Daniele Belardi) #31794
[f1720145af] - benchmark: use let instead of var in timers (Daniele Belardi) #31794
[4ce6fc5f9b] - benchmark: use let instead of var in run.js (Daniele Belardi) #31794
[93b3997452] - benchmark: use let instead of var in dns (Daniele Belardi) #31794
[54c6219c0b] - benchmark: use let instead of var in common.js (Daniele Belardi) #31794
[b188b3c1ba] - benchmark: use const instead of var in async_hooks (Daniele Belardi) #31794
[05111c4377] - benchmark: add no-var rule in .eslintrc.yaml (Daniele Belardi) #31794
[34f05ced8d] - build: output dots instead of tap in GitHub actions (Michaël Zasso) #32714
[f9a2276548] - build: move doc versions JSON file out of out/doc (Richard Lau) #32728
[d7b526c446] - build: fix LINT_MD_NEWER assignment (Rich Trott) #32712
[809d42ccc1] - build: remove .txt files from .gitignore (Rich Trott) #32710
[a11e3ef912] - build: log detected compilers in --verbose mode (Richard Lau) #32715
[135f4b9a99] - build: use tabs for indentation in Makefile (Luigi Pinca) #32614
[655ff39a4c] - build: remove make lint on lint-py (himself65) #32599
[432e58fcf0] - build: disable -Wattributes warnings on aix (Ben Noordhuis) #32419
[eda165feb0] - build: drop Travis in favor of Actions (Matheus Marchini) #32450
[814d88a01a] - console: fixup error message (James M Snell) #32475
[2c32e59d8d] - crypto: clear openssl error stack after en/decrypt (Ben Noordhuis) #32248
[4874db72b3] - deps: fix zlib compilation for CPUs without SIMD features (Anna Henningsen) #32627
[8586838feb] - deps: update archs files for OpenSSL-1.1.1f (Hassaan Pasha) #32583
[3417cc5777] - deps: upgrade openssl sources to 1.1.1f (Hassaan Pasha) #32583
[f690fc93d6] - deps: update acorn to v7.1.1 (Ruben Bridgewater) #32310
[e0e73f6850] - dns: remove duplicate code (rickyes) #32664
[e14317a840] - (SEMVER-MINOR) dns: add dns.ALL hints flag constant (murgatroid99) #32183
[0a8e07599b] - doc: add link to code ide configs (Robert Nagy) #32767
[18b5e04e75] - doc: replace node-test-pull-request-lite-pipeline from onboarding (Juan José Arboleda) #32736
[66aafcf298] - doc: add useful v8 option section (Nimit) #32262
[9788b8438b] - doc: add himself65 to collaborators (himself65) #32734
[19deaa5ddf] - doc: clarify behavior of napi_get_typedarray_info (Michael Dawson) #32603
[f41660a5c2] - doc: remove optional parameter from markdown anchor link (Rich Trott) #32671
[6b32877f82] - doc: clarify listening event (Harshitha KP) #32581
[c1bb041202] - doc: update Ninja information in build guide (Adrian Estrada) #32629
[ba0ea79c82] - doc: correct version metadata for Readable.from (Dave Vandyke) #32639
[7ae8ce3320] - doc: make openssl commit messages be valid (Sam Roberts) #32602
[1e72605703] - doc: adjust paths in openssl maintenance guide (Hassaan Pasha) #32593
[5c70db48bd] - doc: clarify docs fs.watch exception may be emitted (Juan José Arboleda) #32513
[b567a63cc0] - doc: add unreachable code on events example (himself65) #32364
[0f1f572d28] - doc: clarify length param in buffer.write (Harshitha KP) #32119
[31b2cbb7e4] - doc: document that server.address() can return null (Thomas Watson Steen) #32519
[7f971b3fd9] - doc: return type of crypto.getFips() may change (Richard Lau) #32580
[cf4f188fd6] - doc: fix return type of crypto.getFips() (Richard Lau) #32580
[34074aa095] - doc: clarify requireManualDestroy option (Harshitha KP) #32514
[a1bb93ac7c] - doc: fix wordy sentence (Moni) #32567
[329635975b] - doc: add missing changes: entry for dns.ALL (Anna Henningsen) #32617
[1dee8c13a9] - doc: fix more links (Alba Mendez) #32586
[d513b55891] - doc: improve markdown link checker (Alba Mendez) #32586
[7d93a3fa7c] - doc: add flarna to collaborators (Gerhard Stoebich) #32620
[b6f71969a0] - doc: improve fs.read documentation (Hachimi Aa (Sfeir)) #29270
[f0a31e33a8] - doc: update releaser list in README.md (Myles Borins) #32577
[9ee2afa0f7] - doc: add ASAN build instructions (gengjiawen) #32436
[979fb155ff] - doc: update context-aware section of addon doc (Gabriel Schulhof) #28659
[b494053745] - doc: update AUTHORS list (Luigi Pinca) #32222
[6d4d299f4d] - doc: tests local links in markdown documents (Antoine du HAMEL) #32359
[002048ef9f] - doc: fix typo in http2 docs (Nitin Kumar) #32292
[02b0c9e469] - doc: fix typo in maintaining-zlib guide (Nitin Kumar) #32292
[6cdccc8f28] - doc: fix typo in maintaining-openssl guide (Nitin Kumar) #32292
[7d4ec42b3a] - doc: fix profile type of --heap-prof-name (Syohei YOSHIDA) #32404
[e7e3aeec34] - doc: use uppercase on windows path (himself65) #32294
[1b97d25a6c] - doc: rename cve_management_process.md to fit doc style guide (Ling Samuel) #32456
[1e27f66ce6] - doc: add missing changes: entry for mkdir (Anna Henningsen) #32490
[edee4ecade] - doc: add mildsunrise to collaborators (Alba Mendez) #32525
[7f0ed89892] - doc: add link to DNS definition (unknown) #32228
[394f8ca333] - doc,crypto: clarify oaepHash option's impact (Filip Skokan) #32340
[991aca329d] - (SEMVER-MINOR) fs: make parameters optional for readSync (Lucas Holmquist) #32460
[b8b8e82591] - fs: fix fs.read when passing null value (himself65) #32479
[30d55a3517] - (SEMVER-MINOR) fs: add fs.readv() (Sk Sajidul Kadir) #32356
[8770fd96a7] - fs: fixup error message for invalid options.recursive (James M Snell) #32472
[8597df48f7] - http: fix incorrect headersTimeout measurement (Alex R) #32329
[ff3615d5d9] - http: move free socket error handling to agent (Robert Nagy) #32003
[7c3c06224c] - http: don't emit 'readable' after 'close' (Robert Nagy) #32277
[bd9f4d2954] - http: increase default header size from 8KB to 16KB (unknown) #32520
[567b352062] - http: fixup options.method error message (James M Snell) #32471
[23e56ff21c] - lib: fix return type of setTimeout in net.Socket (龙腾道) #32722
[180e43711c] - lib: removes unnecessary params (Jesus Hernandez) #32694
[94251c463b] - lib: changed functional logic in cluster schedulers (Yash Ladha) #32505
[5740a70e5d] - lib: removed unused error code (Yash Ladha) #32481
[68608b2bdc] - lib: replace Array to ArrayIsArray by primordials (himself65) #32258
[537d2c1170] - module: expose exports conditions to loaders (Jan Krems) #31303
[bc7f819263] - module: path-only CJS exports extension searching (Guy Bedford) #32351
[3907de7d24] - (SEMVER-MINOR) n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) #32689
[dd74601f96] - net: fix crash if POLLHUP is received (Santiago Gimeno) #32590
[3c8bf9022a] - net: wait for shutdown to complete before closing (Robert Nagy) #32491
[1a01ac3425] - perf_hooks: allow omitted parameters in 'performance.measure' (himself65) #32651
[8e00f0d2a2] - repl: fixup error message (James M Snell) #32474
[9b84103273] - report: fix stderr matching for fatal error (gengjiawen) #32699
[c09552063b] - report: add missing locks for report_on_fatalerror accessors (Anna Henningsen) #32535
[611dbf8d7f] - src: removes unused v8::Integer and v8::Array namespace (Jesus Hernandez) #32779
[c8a007f91e] - src: remove unused v8::TryCatch namespace (Juan José Arboleda) #32729
[ea1785597c] - src: remove duplicated code (himself65) #32719
[1763649c51] - src: sync access for report and openssl options (Sam Roberts) #32618
[246b789771] - src: refactor to avoid goto in node_file.cc (Tobias Nießen) #32637
[d77998096b] - src: munmap(2) upon class instance destructor (Gabriel Schulhof) #32570
[1fb4f9d922] - src: fix warnings on SPrintF (himself65) #32558
[3b5c4fbc7c] - src: replace goto with lambda in options parser (Tobias Nießen) #32635
[42a28d0214] - src: fix extra includes of "env.h" and "env-inl.h" (Nick Kreeger) #32293
[fcfde57806] - src: avoid using elevated v8 namespaces in node_perf.h (James M Snell) #32468
[9600332c53] - src: avoid using elevated v8 namespaces in node_errors.h (James M Snell) #32468
[62db9a0678] - src: minor http2 refactorings (James M Snell) #32551
[8f766e8397] - src: rename http2 class and suppress compile warnings (James M Snell) #32551
[afc6a25f42] - src: use smart pointers for nghttp2 objects (James M Snell) #32551
[4df3ac2a63] - src: remove loop_init_failed_ from Worker class (Anna Henningsen) #32562
[0faaa7c84c] - src: clean up worker thread creation code (Anna Henningsen) #32562
[f284d599bb] - src: move JSONWriter into its own file (Anna Henningsen) #32552
[e066584d94] - src: align PerformanceState class name with conventions (Anna Henningsen) #32539
[04237eca55] - src: handle report options on fatalerror (Sam Roberts) #32497
[5080491ae4] - src: refactoring and cleanup of node_i18n (James M Snell) #32438
[e2b08f0ea8] - src: remove unnecessary 'Local.As' operation (himself65) #32286
[928a49004e] - src: add test/abort build tasks (Christian Niederer) #31740
[9c901a5ef0] - src: add aliased-buffer-overflow abort test (Christian Niederer) #31740
[1e76bc67dd] - src: check for overflow when extending AliasedBufferBase (Christian Niederer) #31740
[c71736efd8] - src: unify Linux and FreeBSD large pages implem (Gabriel Schulhof) #32534
[06bff18fa8] - src: replace handle dereference with ContainerOf (Harshitha KP) #32298
[b973b938a2] - src: enhance template function 'MakeUtf8String' (himself65) #32322
[fbf0493b05] - src: fix compiler warnings in node_report_module (Daniel Bevenius) #32498
[1de9718b54] - src: remove excess v8 namespace (himself65) #32191
[09cd7449e2] - src: simplify large pages mapping code (Gabriel Schulhof) #32396
[778dcc8f1a] - src: clean v8 namespaces in env.cc file (Juan José Arboleda) #32374
[aa282276ec] - src: check for empty maybe local (Xavier Stouder) #32339
[13377a0f0f] - src: cleanup DestroyParam when Environment exits (Anna Henningsen) #32421
[055c5686ad] - src,test: add regression test for nested Worker termination (Anna Henningsen) #32623
[1c47bba607] - stream: complete pipeline with stdio (Robert Nagy) #32373
[cad768eb86] - stream: change var to let/const in stream files (Saajan) #32214
[bdb2df7e34] - test: replace console.log/error with debuglog (Agustin Daguerre) #32695
[756a049a1a] - test: make sure that inspector tests finish (Anna Henningsen) #32673
[a7a70fa986] - test: save test file in temporary directory (Luigi Pinca) #32670
[6d479588cb] - test: fix check error name on error instance (himself65) #32508
[9df274ad03] - Revert "test: mark empty udp tests flaky on OS X" (Luigi Pinca) #32489
[6d122429c1] - test: remove unused variables on async hook test (Julian Duque) #32630
[8c68dd4a11] - test: check that --expose-internals is disallowed in NODE_OPTIONS (Juan José Arboleda) #32554
[4ffa138c81] - test: refactor test-worker (himself65) #32509
[17b2526162] - test: add Worker initialization failure test case (Harshitha KP) #31929
[ed89863c6d] - test: fix tool path in test-doctool-versions.js (Richard Lau) #32645
[17a3dcea90] - test: copy addons .gitignore to test/abort/ (Anna Henningsen) #32624
[e501ba2146] - test: refactor test-http2-buffersize (Rich Trott) #32540
[cede0cb841] - test: skip crypto test on arm buildbots (Ben Noordhuis) #32636
[e01d061669] - test: replace console.error() with debuglog calls (Rich Trott) #32588
[a7b6a10e2a] - test: fix python-version selection with actions (Myles Borins) #32609
[93ff4ffca9] - test: add a missing common.mustCall (Harshitha KP) #32305
[30505d7c10] - test: remove unnecessary console.log() calls (Juan José Arboleda) #32541
[8f0c1069b9] - test: replace console.log() with debuglog() (Juan José Arboleda) #32550
[408437d7c6] - test: validate util.format when the value is 'Infinity' (Andrés M. Gómez) #32573
[2e015e5b5e] - test: fix fs test-fs-utimes strictEqual arg order (Ben Noordhuis) #32420
[edf35db27e] - test: replace flag expose_internals to expose-internals (Juan José Arboleda) #32542
[079a32e31c] - test: use common.mustCall in test-worker-esm-exit (himself65) #32544
[cca269c3a0] - test: use template strings in parallel tests (Daniel Estiven Rico Posada) #32549
[0e4ce8f50a] - test: add known issues test for fs,crypto: AAD decryption of fs stream > 32768 bytes fails #31733 (Ben Noordhuis) #31734
[28077a01cc] - test: mark test-http2-reset-flood flaky on bsd (Myles Borins) #32595
[ca2662012e] - test: add test-worker-prof to the SLOW list for debug (Myles Borins) #32589
[8bcbb8d7dd] - test: refactor test-http-information-processing (Rich Trott) #32547
[1fc19b0fb0] - test: fix a typo on test-fs-read-optional-params (himself65) #32461
[986a60544a] - test: skip a wasi test on IBMi PASE (Xu Meng) #32459
[73fec7cd00] - test: harden the tick sampling logic (Harshitha KP) #32190
[1905b9ecce] - test: als variant of test-timers-clearImmediate (Harshitha KP) #32303
[72983d2e4f] - test: skip some binding tests on IBMi PASE (Xu Meng) #31967
[02eea7773a] - test: revise test-http-response-multi-content-length (Rich Trott) #32526
[f179a223d7] - test: remove a duplicated test (himself65) #32453
[fbb51b9c41] - test: check bundled binaries are signed on macOS (Richard Lau) #32522
[36c6d22113] - test: unflake async-hooks/test-statwatcher (Bartosz Sosnowski) #32484
[b1e6f297cf] - test: use Promise.all() in test-cluster-net-listen-ipv6only-false (Rich Trott) #32398
[11d7cf155a] - test: replace Map with Array in test-cluster-net-listen-ipv6only-false (Rich Trott) #32398
[2f8f619c7e] - test: revise test-http-client-default-headers-exist (Rich Trott) #32493
[567e671bd2] - tools: update Boxstarter script and document (himself65) #32299
[97a3e2f0e2] - tools: update ESLint to 7.0.0-alpha.3 (Colin Ihrig) #32533
[ffdd82ba3f] - tools: only fetch previous versions when necessary (Richard Lau) #32518
[4e5271acfb] - tracing: do not attempt to call into JS when disallowed (Anna Henningsen) #32548
[0087eb1b98] - (SEMVER-MINOR) util: add maxStrLength option to inspect function (unknown) #32392
[848d81cf23] - util: only inspect error properties that are not visible otherwise (Ruben Bridgewater) #32327
[6d86651076] - util: fix inspecting document.all (Gus Caplan) #31938
[4f98b7178d] - wasi: clean up options validation (Denys Otrishko) #31797
[2ee684a7b9] - win,build: set exit_code on configure failure (Bartlomiej Brzozowski) #32205
[8cb5e41807] - (SEMVER-MINOR) worker: support MessagePort to workers data (Juan José Arboleda) #32278
[4acd7f4390] - worker: do not emit 'exit' events during process.exit() (Anna Henningsen) #32546
[833d78afcf] - worker: runtime error on pthread creation (Harshitha KP) #32344

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins and bricss reacted with thumbs up emoji

bricss reacted with hooray emoji

bricss reacted with heart emoji

bricss and mcollina reacted with rocket emoji

All reactions

👍 2 reactions
🎉 1 reaction
❤️ 1 reaction
🚀 2 reactions

rosaxxny and others added 30 commits

March 30, 2020 19:17


          doc: add link to DNS definition

7f0ed89

PR-URL: #32228
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          repl: fixup error message

8e00f0d

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32474
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          http: fixup options.method error message

567b352

Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>


          build: drop Travis in favor of Actions

eda165f

GitHub Actions is running all tests already present on Travis, as well
as building on more platforms (OS X and Windows). With Travis we're also
getting timeouts more frequently than with Actions, which gives the
false impression tests are failing (making it harder to triage PRs ready
to merge).

To make our config simpler, CI.yml and pythonpackage.yml got merged. The
coverage is also increased by running tests on OS X.

Signed-off-by: Matheus Marchini <[email protected]>

PR-URL: #32450
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          src: cleanup DestroyParam when Environment exits

13377a0

Otherwise, this leaks memory if the weak callback is never called.

PR-URL: #32421
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: check for empty maybe local

aa28227

Using ToLocalChecked on MaybeLocal without verifying it's empty
can lead to unattempted crash.

PR-URL: #32339
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: clean v8 namespaces in env.cc file

778dcc8

PR-URL: #32374
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          doc: add mildsunrise to collaborators

edee4ec

PR-URL: #32525
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          test: revise test-http-client-default-headers-exist

2f8f619

* Remove assert.strictEqual where assert.ok suffices
* Replace countdown with Promise.all()

PR-URL: #32493
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          src: simplify large pages mapping code

09cd744

* Introduce `OnScopeLeave` handler for cleaning up mmap()ed range(s).
* Factor out failure scenario at the bottom of the function with
  `fail` label for use with `goto`.
* Do not allocate temporary range (`nmem`) on FreeBSD, because it is
  not used.

The intention is that the steps involved in re-mapping to large pages
become more clearly visible.

Signed-off-by: Gabriel Schulhof <[email protected]>
Co-authored-by: Ben Noordhuis <[email protected]>
PR-URL: #32396
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: David Carlier <[email protected]>


          test: replace Map with Array in test-cluster-net-listen-ipv6only-false

11d7cf1

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>


          test: use Promise.all() in test-cluster-net-listen-ipv6only-false

b1e6f29

Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>


          src: remove excess v8 namespace

1de9718

PR-URL: #32191
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          fs: fixup error message for invalid options.recursive

8770fd9

Use "options.recursive" instead of just "recursive"

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32472
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          console: fixup error message

814d88a

Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32475
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          src: fix compiler warnings in node_report_module

fbf0493

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: #32498
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          build: disable -Wattributes warnings on aix

432e58f

Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: #32419
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          doc: add missing changes: entry for mkdir

1e27f66

Refs: #31530

PR-URL: #32490
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          doc: rename cve_management_process.md to fit doc style guide

1b97d25

PR-URL: #32456
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: unflake async-hooks/test-statwatcher

36c6d22

On Windows 2016 under high load further change events can be emitted
after writing the 5 bytes is reported. Updating the mtime of the file
can be reported as a separate change. This will increase the "before"
count, but not the "w1HookCount" since we removed the listener.

This makes the test keep the listeners until the end of the test.

Fixes: #21425

PR-URL: #32484
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: check bundled binaries are signed on macOS

fbb51b9

For notarization on macOS all packaged binaries must be signed. Add a
regression test to check that known binaries from our dependencies
(at the time of this commit term-size via npm) are signed.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32522
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          test: remove a duplicated test

f179a22

PR-URL: #32453
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>


          http: increase default header size from 8KB to 16KB

bd9f4d2

Fixes: #27645

PR-URL: #32520
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>


          doc,crypto: clarify oaepHash option's impact

394f8ca

PR-URL: #32340
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          src: enhance template function 'MakeUtf8String'

b973b93

PR-URL: #32322
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>


          deps: update acorn to v7.1.1

f690fc9

Also clean up the plugins package.json files.

PR-URL: #32310
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>


          doc: use uppercase on windows path

e7e3aee

PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          doc: fix profile type of --heap-prof-name

7d4ec42

V8 CPU profile -> V8 heap profile

PR-URL: #32404
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: replace handle dereference with ContainerOf

06bff18

this was influenced by #32269

PR-URL: #32298
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: unify Linux and FreeBSD large pages implem

c71736e

dl_iterate_phdr(3) is also available for FreeBSD. This change adds the
same trimming code for the start and end of the .text section as on
Linux, making it work on FreeBSD, and removing the need for the
additional FreeBSD-specific check.

Manually tested on
  * https://www.osboxes.org/freebsd/#freebsd-12-1-vbox
  * https://www.osboxes.org/freebsd/#freebsd-11-vbox
  * test-digitalocean-freebsd11-x64-2

Signed-off-by: Gabriel Schulhof <[email protected]>
PR-URL: #32534
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>

JesuHrz and others added 2 commits

April 13, 2020 13:28


          src: removes unused v8::Integer and v8::Array namespace

611dbf8

PR-URL: #32779
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>


          doc: add link to code ide configs

0a8e075

Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

targos commented Apr 14, 2020

Copy link

Copy Markdown

Member Author

I wrote the notable changes.

/cc @nodejs/collaborators @nodejs/releasers

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 14, 2020 •

edited by targos

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30727/
CITGM: https://ci.nodejs.org/job/citgm-smoker/2348/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina approved these changes

Apr 14, 2020

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cjihrig approved these changes

Apr 14, 2020

View reviewed changes

puzpuzpuz commented Apr 14, 2020

Copy link

Copy Markdown

Member

@targos is it possible to include #31950 into 13.13.0? It's a semver-minor, so otherwise it'll have to wait for the next minor release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau approved these changes

Apr 14, 2020

View reviewed changes

targos commented Apr 14, 2020

Copy link

Copy Markdown

Member Author

@puzpuzpuz sorry, I don't have the time to add commits to this proposal. The next release that will include #31950 is not far. v14.0.0 will be out with it next week :)

puzpuzpuz reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          2020-04-14, Version 13.13.0 (Current)

Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813

targos force-pushed the v13.13.0-proposal branch from 4ca9571 to 8130521 Compare

April 14, 2020 16:11

puzpuzpuz commented Apr 14, 2020

Copy link

Copy Markdown

Member

@puzpuzpuz sorry, I don't have the time to add commits to this proposal. The next release that will include #31950 is not far. v14.0.0 will be out with it next week :)

@targos good to know. No problem then. 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codebytere approved these changes

Apr 14, 2020

View reviewed changes

gengjiawen approved these changes

Apr 14, 2020

View reviewed changes

mmarchini approved these changes

Apr 14, 2020

View reviewed changes

targos merged commit 8130521 into v13.x

Apr 14, 2020

targos added a commit that referenced this pull request

Apr 14, 2020


          Working on 13.13.1

947ddec

PR-URL: #32813

targos added a commit that referenced this pull request

Apr 14, 2020


          2020-04-14, Version 13.13.0 (Current)

cf4c332

Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813

targos deleted the v13.13.0-proposal branch

April 14, 2020 18:27

targos added a commit to nodejs/nodejs.org that referenced this pull request

Apr 14, 2020


          Blog: v13.13.0 release post

647fa1f

Refs: nodejs/node#32813

targos mentioned this pull request

Apr 14, 2020

Blog: v13.13.0 release post nodejs/nodejs.org#3105

Merged

targos added a commit to nodejs/nodejs.org that referenced this pull request

Apr 14, 2020


          Blog: v13.13.0 release post (#3105)

f1cfd86

Refs: nodejs/node#32813

Reviewers

mcollina

mcollina approved these changes

codebytere

codebytere approved these changes

cjihrig

cjihrig approved these changes

gengjiawen

gengjiawen approved these changes

richardlau

richardlau approved these changes

+1 more reviewer

mmarchini

mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

targos commented Apr 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Changes

New file system APIs

Other changes

New core collaborators

Commits

Uh oh!

targos commented Apr 14, 2020

Uh oh!

nodejs-github-bot commented Apr 14, 2020 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

puzpuzpuz commented Apr 14, 2020

Uh oh!

targos commented Apr 14, 2020

Uh oh!

puzpuzpuz commented Apr 14, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

targos commented Apr 13, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 14, 2020 •

edited by targos

Loading

Uh oh!

There was an error while loading. Please reload this page.