GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — win,build: set exit_code on configure failure by bartbrzo · Pull Request #32205 · nodejs/node

Conversation

@bartbrzo

@bartbrzo bartbrzo commented Mar 11, 2020

Copy link
Copy Markdown

Fixes: #31573

Changed vcbuild.bat to exit with an error in case of exception in the configure script.

In case of failure, the error was not propagated because errorlevel was overwritten with the result of del command.

This should land in all LTS branches.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Bartlomiej Brzozowski
win,build: set exit_code on configure failure
ab4729f
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. windows Issues and PRs related to the Windows platform. labels Mar 11, 2020
addaleax
addaleax approved these changes Mar 11, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Mar 11, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 11, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30095/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30100/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bzoz

bzoz commented Mar 27, 2020

Copy link
Copy Markdown
Contributor

The one failing test is:

18:03:38 not ok 556 parallel/test-tls-root-certificates
18:03:38   ---
18:03:38   duration_ms: 0.412
18:03:38   severity: fail
18:03:38   exitcode: 1
18:03:38   stack: |-
18:03:38     assert.js:384
18:03:38         throw err;
18:03:38         ^
18:03:38     
18:03:38     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
18:03:38     
18:03:38       assert(tls.rootCertificates.includes(extraCert))
18:03:38     
18:03:38         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-tls-root-certificates.js:49:3)
18:03:38         at Module._compile (internal/modules/cjs/loader.js:1202:30)
18:03:38         at Object.Module._extensions..js (internal/modules/cjs/loader.js:1222:10)
18:03:38         at Module.load (internal/modules/cjs/loader.js:1051:32)
18:03:38         at Function.Module._load (internal/modules/cjs/loader.js:947:14)
18:03:38         at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
18:03:38         at internal/main/run_main_module.js:17:47 {
18:03:38       generatedMessage: true,
18:03:38       code: 'ERR_ASSERTION',
18:03:38       actual: false,
18:03:38       expected: true,
18:03:38       operator: '=='
18:03:38     }
18:03:38     assert.js:102
18:03:38       throw new AssertionError(obj);
18:03:38       ^
18:03:38     
18:03:38     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
18:03:38     
18:03:38     1 !== 0
18:03:38     
18:03:38         at ChildProcess.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-tls-root-certificates.js:19:12)
18:03:38         at ChildProcess.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:362:15)
18:03:38         at ChildProcess.emit (events.js:315:20)
18:03:38         at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
18:03:38       generatedMessage: true,
18:03:38       code: 'ERR_ASSERTION',
18:03:38       actual: 1,
18:03:38       expected: 0,
18:03:38       operator: 'strictEqual'
18:03:38     }

This is unrelated and tracked in nodejs/build#2254
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30207/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30231/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30237/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 5e05f8a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
Bartlomiej Brzozowski @addaleax
win,build: set exit_code on configure failure
5e05f8a 
PR-URL: #32205
Fixes: #31573
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
Bartlomiej Brzozowski @addaleax
win,build: set exit_code on configure failure
2ee684a 
PR-URL: #32205
Fixes: #31573
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
Bartlomiej Brzozowski @targos
win,build: set exit_code on configure failure
10c525f 
PR-URL: #32205
Fixes: #31573
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive build result in vcbuild.bat

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@bartbrzo @nodejs-github-bot @bzoz @addaleax @jasnell @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.