GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: change var to let/const in lib stream js files. by Saajan · Pull Request #32214 · nodejs/node

Conversation

@Saajan

@Saajan Saajan commented Mar 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to Node.js streams. label Mar 11, 2020
ronag
ronag approved these changes Mar 11, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29763/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Saajan
Saajan force-pushed the master branch from e7c0f65 to 38bb845 Compare March 12, 2020 11:16
@Saajan Saajan changed the title "var" in lib stream js files changed to "let" and "const". lib:"var" in lib stream js files changed to "let" and "const". Mar 12, 2020
@trivikr

trivikr commented Mar 18, 2020

Copy link
Copy Markdown
Member

@Saajan This needs rebase as _stream_writable.js was updated in #32037

Can you please update PR title to git commit message guidelines?
It can be stream: change var to let/const for example
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Saajan Saajan changed the title lib:"var" in lib stream js files changed to "let" and "const". stream: change var to let/const in lib stream js files. Mar 18, 2020
@Saajan
"var" in lib stream js files changed to "let" and "const".
fdd62dc
@Saajan
Saajan force-pushed the master branch from 38bb845 to fdd62dc Compare March 18, 2020 20:31
@Saajan

Saajan commented Mar 18, 2020

Copy link
Copy Markdown
Contributor Author

@Saajan This needs rebase as _stream_writable.js was updated in #32037

Can you please update PR title to git commit message guidelines?
It can be stream: change var to let/const for example

Thank you for the suggestions. I have done the changes you asked.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 18, 2020
View reviewed changes
@Saajan
Saajan requested a review from ronag March 20, 2020 07:32
ronag
ronag approved these changes Mar 20, 2020
View reviewed changes
addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30206/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30230/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 4fc13b0 🎉
Saajan reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Saajan @addaleax
stream: change var to let/const in stream files
4fc13b0 
PR-URL: #32214
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Saajan @addaleax
stream: change var to let/const in stream files
cad768e 
PR-URL: #32214
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@ronag ronag ronag approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Saajan @nodejs-github-bot @trivikr @addaleax @jasnell @ronag @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.