GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: fix typos in docs by snitin315 · Pull Request #32292 · nodejs/node

Conversation

@snitin315

@snitin315 snitin315 commented Mar 16, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
shivaylamba
shivaylamba approved these changes Mar 16, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Mar 16, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 16, 2020
View reviewed changes
lpinca
lpinca reviewed Mar 16, 2020
View reviewed changes
Comment thread test/fixtures/wpt/resources/testdriver.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
addaleax
addaleax requested changes Mar 29, 2020
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if the changes to test/cctest/gtest and test/fixtures/wpt/resources could be undone/upstreamed.

I’ll mark this as request-changes so it doesn’t accidentally land until that has been addressed, but otherwise it looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
snitin315 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Trott
Trott approved these changes Mar 30, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @addaleax and others that some of these should be left alone and done upstream. Would even go further and suggest that the fixes can all be separate commits to easy backporting. But I'm OK with it as one commit too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
snitin315 added 3 commits March 30, 2020 11:18
@snitin315
docs(guides): fix typo in maintaining-openssl
575d650
@snitin315
docs(guides): fix typo in maintaining-zlib
49cc40b
@snitin315
docs(api): fix typo in http2
cdb034c
@snitin315
snitin315 force-pushed the master branch from 7d71c53 to cdb034c Compare March 30, 2020 05:49
@snitin315

snitin315 commented Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

@Trott @addaleax Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@snitin315
snitin315 requested review from Trott, addaleax, jasnell and trivikr March 30, 2020 05:51
Trott
Trott approved these changes Mar 30, 2020
View reviewed changes
@snitin315 snitin315 changed the title chore: fix typos chore: fix typos in docs Mar 30, 2020
addaleax
addaleax approved these changes Mar 30, 2020
View reviewed changes
@addaleax addaleax added the doc Issues and PRs related to Node.js documentation. label Mar 30, 2020
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 67d5c90...575b4e3, thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-openssl guide
be2f36a 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-zlib guide
988f5bf 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in http2 docs
575b4e3 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-openssl guide
6cdccc8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-zlib guide
02b0c9e 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in http2 docs
002048e 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@targos targos added the backport-blocked-v12.x label Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@snitin315 @targos
doc: fix typo in maintaining-zlib guide
372a8f2 
PR-URL: nodejs#32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added backported-to-v12.x and removed backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@snitin315 @targos
doc: fix typo in maintaining-openssl guide
6bde76d 
PR-URL: nodejs#32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@snitin315 @targos
doc: fix typo in maintaining-zlib guide
f13ecd8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@snitin315 @targos
doc: fix typo in maintaining-openssl guide
13342f8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@trivikr trivikr Awaiting requested review from trivikr
@jasnell jasnell Awaiting requested review from jasnell
+2 more reviewers
@mmarchini mmarchini mmarchini left review comments
@shivaylamba shivaylamba shivaylamba approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@snitin315 @addaleax @jasnell @Trott @lpinca @cjihrig @mmarchini @trivikr @shivaylamba @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.