GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use uppercase on windows path by himself65 · Pull Request #32294 · nodejs/node

Conversation

@himself65

@himself65 himself65 commented Mar 16, 2020

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@himself65
doc: use uppercase on windows path
16c2451
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 16, 2020
bzoz
bzoz approved these changes Mar 16, 2020
View reviewed changes

@bzoz bzoz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like we are using C: everywhere else in those docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65 and ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
jasnell
jasnell approved these changes Mar 16, 2020
View reviewed changes
lpinca
lpinca approved these changes Mar 16, 2020
View reviewed changes
@himself65 himself65 mentioned this pull request Mar 17, 2020
esm: add gotcha to documentation #32237
Closed
2 tasks done
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
ExE-Boss
ExE-Boss approved these changes Mar 18, 2020
View reviewed changes

@ExE-Boss ExE-Boss left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do note that: “https://docs.microsoft.com/windows/desktop/FileIO/naming-a-file#fully-qualified-vs-relative-paths” has moved to: “https://docs.microsoft.com/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths”.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@himself65

himself65 commented Mar 18, 2020

Copy link
Copy Markdown
Member Author

Do note that: “https://docs.microsoft.com/windows/desktop/FileIO/naming-a-file#fully-qualified-vs-relative-paths” has moved to: “https://docs.microsoft.com/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths”.

This not the responsibility of this PR. I think
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 18, 2020

Copy link
Copy Markdown
Member

This not the responsibility of this PR. I think

While true, it wouldn't hurt to go ahead and update here.
ExE-Boss reacted with thumbs up emoji himself65 reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
@addaleax

addaleax commented Mar 29, 2020

Copy link
Copy Markdown
Member

Landed in cc8066e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 29, 2020
@himself65 @addaleax
doc: use uppercase on windows path
cc8066e 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
doc: use uppercase on windows path
e7e3aee 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
doc: use uppercase on windows path
59a8dbe 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@ExE-Boss ExE-Boss ExE-Boss approved these changes
@bzoz bzoz bzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@himself65 @jasnell @addaleax @lpinca @ExE-Boss @trivikr @bzoz @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.