GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add unreachable code on events example by himself65 · Pull Request #32364 · nodejs/node

Conversation

@himself65

@himself65 himself65 commented Mar 19, 2020

Copy link
Copy Markdown
Member

It would be helpful if add a noticeable code for the user

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. labels Mar 19, 2020
@himself65

himself65 commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

related: #32360
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65
himself65 force-pushed the 20200319-events branch from 304b3f4 to 91c4d9e Compare March 19, 2020 14:26
mscdex
mscdex reviewed Mar 19, 2020
View reviewed changes
Comment thread doc/api/events.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@himself65
doc: add unreachable code on events example
d7111a3
@himself65
himself65 force-pushed the 20200319-events branch from 91c4d9e to d7111a3 Compare March 30, 2020 00:31
addaleax
addaleax approved these changes Apr 5, 2020
View reviewed changes
@addaleax

addaleax commented Apr 5, 2020

Copy link
Copy Markdown
Member

Landed in cee396e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Apr 5, 2020
@himself65 @addaleax
doc: add unreachable code on events example
cee396e 
PR-URL: #32364
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax addaleax closed this Apr 5, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@himself65 @BethGriggs
doc: add unreachable code on events example
f23b878 
PR-URL: #32364
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@himself65 @targos
doc: add unreachable code on events example
b567a63 
PR-URL: #32364
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
doc: add unreachable code on events example
c3d91eb 
PR-URL: #32364
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@himself65 @addaleax @mscdex @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.