GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve test-cluster-net-listen-ipv6only-* tests by Trott · Pull Request #32381 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Replace Map with Array
  • Add additional checks that code/test work as expected (Failed on Windows so I took it out.)
  • Use Promise.all() in place of countdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 20, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Trott force-pushed the seq-cluster branch from f9d0b62 to aef4f9c Compare March 20, 2020 04:40
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Trott force-pushed the seq-cluster branch from aef4f9c to 4db3bf4 Compare March 20, 2020 05:04
@nodejs-github-bot

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR approved these changes Mar 20, 2020
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 20, 2020
jasnell
jasnell reviewed Mar 21, 2020
View reviewed changes
Comment thread test/sequential/test-cluster-net-listen-ipv6only-none.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 21, 2020
View reviewed changes
Comment thread test/sequential/test-cluster-net-listen-ipv6only-rr.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 21, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2020 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29961/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 21, 2020
@Trott Trott mentioned this pull request Mar 21, 2020
test: improve test-cluster-net-listen-ipv6only-false #32398
Merged
2 tasks done
addaleax
addaleax approved these changes Mar 21, 2020
View reviewed changes
Trott added 2 commits March 21, 2020 21:51
@Trott
test: replace Map with Array in cluster-net-listen tests
7d4dedb 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
test: replace countdown with Promise.all() in cluster-net-listen tests
ecfb7b0 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott

Trott commented Mar 22, 2020

Copy link
Copy Markdown
Member Author

Landed in 1d49558...ecfb7b0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the seq-cluster branch from dc893d6 to ecfb7b0 Compare March 22, 2020 04:52
@Trott
Trott merged commit ecfb7b0 into nodejs:master Mar 22, 2020
@Trott
Trott deleted the seq-cluster branch March 22, 2020 04:53
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
347f707 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
e2ee68e 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
v13.12.0 proposal #32376
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
bdcc11f 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
2e28783 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace Map with Array in cluster-net-listen tests
1b79174 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace countdown with Promise.all() in cluster-net-listen tests
97e352d 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@Han5991 Han5991 mentioned this pull request Jun 27, 2026
test-net-listen-ipv6only is flaky due to IPv4 port collision #64172
Closed
@Han5991 Han5991 mentioned this pull request Jun 27, 2026
test: deflake test-net-listen-ipv6only #64173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@addaleax addaleax addaleax approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nodejs-github-bot @jasnell @addaleax @BridgeAR @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.