GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve test-cluster-net-listen-ipv6only-false by Trott · Pull Request #32398 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 21, 2020

Copy link
Copy Markdown
Member

Missed this one in #32381. Use Array instead of Map, use Promise.all() instead of countdown.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the par-cluster branch from b42a5cd to 9743326 Compare March 21, 2020 03:16
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 21, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2020 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29963/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 21, 2020
View reviewed changes
Comment thread test/parallel/test-cluster-net-listen-ipv6only-false.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 23, 2020
Trott added 2 commits March 27, 2020 23:16
@Trott
test: replace Map with Array in test-cluster-net-listen-ipv6only-false
a1686e0 
Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32398
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
test: use Promise.all() in test-cluster-net-listen-ipv6only-false
2565442 
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32398
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Trott force-pushed the par-cluster branch from 9743326 to 2565442 Compare March 28, 2020 06:17
@Trott

Trott commented Mar 28, 2020

Copy link
Copy Markdown
Member Author

Landed in fa3fd78...2565442
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 2565442 into nodejs:master Mar 28, 2020
@Trott
Trott deleted the par-cluster branch March 28, 2020 06:18
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Trott @addaleax
test: replace Map with Array in test-cluster-net-listen-ipv6only-false
11d7cf1 
Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Trott @addaleax
test: use Promise.all() in test-cluster-net-listen-ipv6only-false
b1e6f29 
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace Map with Array in test-cluster-net-listen-ipv6only-false
60db56d 
Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: use Promise.all() in test-cluster-net-listen-ipv6only-false
5cae1b7 
Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32398
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
This was referenced Jun 27, 2026
test-net-listen-ipv6only is flaky due to IPv4 port collision #64172
Closed
test: deflake test-net-listen-ipv6only #64173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Trott @nodejs-github-bot @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.