GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: refactoring and cleanup of node_i18n by jasnell · Pull Request #32438 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 23, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Starting some cleanup/refactoring of node_i18n

  • Refactor Converter and ConverterObject definitions
    • Move definitions to node_i18n.h
    • Introduce a new utility functions for better encapsulation
    • Adhere closer to c++ style guide
    • Simplify some state tracking
    • Use std::unique_ptr for cleanup
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 23, 2020
@jasnell
jasnell requested review from addaleax and joyeecheung March 23, 2020 18:50
@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29995/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Mar 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can you add some high-level description in the OP or the commit message? I can see that there are some helper class added and class definition separated but not sure if they are meant to be copied verbatim or is there something else intended
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 24, 2020

Copy link
Copy Markdown
Member Author

@joyeecheung:

Can you add some high-level description in the OP or the commit message

Done :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell force-pushed the refactor-i18n branch from 1ca32c6 to f9cd4f4 Compare March 27, 2020 23:17
@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30142/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30172/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
Comment thread src/node_i18n.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/node_i18n.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30179/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
@jasnell
src: refactoring and cleanup of node_i18n
fea904a 
Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the refactor-i18n branch from ed1c43b to fea904a Compare March 29, 2020 20:29
joyeecheung
joyeecheung approved these changes Mar 30, 2020
View reviewed changes
Comment thread src/node_i18n.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Mar 30, 2020
@jasnell
src: refactoring and cleanup of node_i18n
accc984 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@jasnell

jasnell commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

Landed in accc984
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 30, 2020
MylesBorins pushed a commit that referenced this pull request Mar 31, 2020
@jasnell @MylesBorins
src: refactoring and cleanup of node_i18n
5080491 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: refactoring and cleanup of node_i18n
4f9ff92 
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: refactoring and cleanup of node_i18n
e035194 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @nodejs-github-bot @joyeecheung @addaleax @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.