GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip a wasi test on IBMi PASE by dmabupt · Pull Request #32459 · nodejs/node

Conversation

@dmabupt

@dmabupt dmabupt commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.

This is the same change as V8 --> https://github.com/nodejs/node/blob/master/deps/v8/src/base/platform/time.cc#L73

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 24, 2020
@cjihrig

cjihrig commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

This won't do what you think it does. You need to skip the test on IBMi from here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dmabupt

dmabupt commented Mar 24, 2020

Copy link
Copy Markdown
Contributor Author

This won't do what you think it does. You need to skip the test on IBMi from here.

Ah... I thought that would skip all the 4 tests. So the c code will not be compiled to wasm automatically?

Since this line also failed, I may investigate a little more and edit the test-wasi.js directly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

So the c code will not be compiled to wasm automatically?

No, because the CI and users would need to have the WASI SDK installed to compile from .c to .wasm. But, beyond that, .wasm files should be platform independent I think.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dmabupt
test: skip a wasi test on IBMi PASE
a9357fe 
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.
richardlau
richardlau approved these changes Mar 24, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Mar 24, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30187/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 4898c1d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@dmabupt @addaleax
test: skip a wasi test on IBMi PASE
4898c1d 
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.

PR-URL: #32459
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@dmabupt @addaleax
test: skip a wasi test on IBMi PASE
986a605 
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.

PR-URL: #32459
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@dmabupt
dmabupt deleted the ibmi_wasi_clock_getres branch April 14, 2020 00:08
targos pushed a commit that referenced this pull request Apr 22, 2020
@dmabupt @targos
test: skip a wasi test on IBMi PASE
b6e739a 
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.

PR-URL: #32459
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@dmabupt @cjihrig @nodejs-github-bot @addaleax @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.