GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: avoid using elevated v8 namespaces in headers by jasnell · Pull Request #32468 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 24, 2020

Copy link
Copy Markdown
Member

Just had a handful of using v8:... elevations in a couple of header files. This goes ahead and removes those.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 24, 2020
@jasnell
jasnell force-pushed the cleanup-elevated-namespaces branch from 172efbb to 54f866b Compare March 24, 2020 21:02
jasnell added 2 commits March 24, 2020 14:02
@jasnell
src: avoid using elevated v8 namespaces in node_errors.h
7b4ab34 
Signed-off-by: James M Snell <[email protected]>
@jasnell
src: avoid using elevated v8 namespaces in node_perf.h
055c318 
Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the cleanup-elevated-namespaces branch from 54f866b to 055c318 Compare March 24, 2020 21:02
addaleax
addaleax approved these changes Mar 24, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30033/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30035/ (:yellow_heart:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 25, 2020
@addaleax addaleax added the review wanted PRs that need review. label Mar 27, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@jasnell @addaleax
src: avoid using elevated v8 namespaces in node_errors.h
04c9a98 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@jasnell @addaleax
src: avoid using elevated v8 namespaces in node_perf.h
05da0bb 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member

Landed in 23a3408...05da0bb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@jasnell @BethGriggs
src: avoid using elevated v8 namespaces in node_errors.h
bb29e5b 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@jasnell @BethGriggs
src: avoid using elevated v8 namespaces in node_perf.h
5f7d881 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_errors.h
9600332 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_perf.h
fcfde57 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-blocked-v12.x review wanted PRs that need review. labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_errors.h
af6378a 
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32468
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_perf.h
4259bbb 
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32468
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_errors.h
6175a22 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: avoid using elevated v8 namespaces in node_perf.h
7432d0a 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32468
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jasnell @nodejs-github-bot @addaleax @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.