GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: fixup options.method error message by jasnell · Pull Request #32471 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 24, 2020

Copy link
Copy Markdown
Member

Use options.method instead of just method in ERR_INVALID_ARG_TYPE

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the http Issues and PRs related to the http subsystem. label Mar 24, 2020
@jasnell
jasnell force-pushed the fixup-error-message-http-client branch from 068e55d to 1e861a9 Compare March 24, 2020 21:35
@jasnell
http: fixup options.method error message
59bf960 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the fixup-error-message-http-client branch from 1e861a9 to 59bf960 Compare March 24, 2020 21:43
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30034/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evanlucas
evanlucas approved these changes Mar 25, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30054/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 25, 2020
trivikr
trivikr approved these changes Mar 27, 2020
View reviewed changes
@addaleax

addaleax commented Mar 27, 2020

Copy link
Copy Markdown
Member

Landed in ca19d55
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Mar 27, 2020
@jasnell @addaleax
http: fixup options.method error message
ca19d55 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Mar 27, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@jasnell @addaleax
http: fixup options.method error message
567b352 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@jasnell @targos
http: fixup options.method error message
52a52d2 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trivikr trivikr trivikr approved these changes
+1 more reviewer
@evanlucas evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @nodejs-github-bot @addaleax @evanlucas @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.