GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — repl: fixup error message by jasnell · Pull Request #32474 · nodejs/node

Conversation

jasnell commented Mar 24, 2020

Copy link

Copy Markdown

Member

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and himself65 reacted with thumbs up emoji

All reactions

👍 2 reactions


          repl: fixup error message

b59249c

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Signed-off-by: James M Snell <[email protected]>

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label

Mar 24, 2020

nodejs-github-bot commented Mar 24, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30037/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

antsmartian approved these changes

Mar 25, 2020

View reviewed changes

himself65 reviewed

Mar 25, 2020

View reviewed changes

himself65 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw many error messages on codes, for example

node/lib/internal/fs/utils.js

Lines 624 to 625 in afe3530

	validateInt32(options.retryDelay, 'retryDelay', 0);
	validateUint32(options.maxRetries, 'maxRetries');

node/lib/internal/http2/core.js

Line 2856 in 66310c2

validateUint32(options.maxSessionInvalidFrames, 'maxSessionInvalidFrames');

should we fix them at one time?

BTW, is there any solution prevents more error messages for the future?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jasnell commented Mar 25, 2020

Copy link

Copy Markdown

Member Author

Let's just tackle them incrementally. If nothing else it makes a good first contribution for new comers. They aren't critical changes so no need to do them all at once.

himself65 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 25, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30053/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 25, 2020

addaleax approved these changes

Mar 27, 2020

View reviewed changes

addaleax pushed a commit that referenced this pull request

Mar 27, 2020


          repl: fixup error message

a057871

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32474
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

addaleax commented Mar 27, 2020

Copy link

Copy Markdown

Member

Landed in a057871

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax closed this

Mar 27, 2020

addaleax pushed a commit that referenced this pull request

Mar 30, 2020


          repl: fixup error message

8e00f0d

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32474
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

targos mentioned this pull request

Apr 13, 2020

v13.13.0 release proposal #32813

Merged

targos pushed a commit that referenced this pull request

Apr 22, 2020


          repl: fixup error message

7c0c4e9

Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32474
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

targos mentioned this pull request

Apr 22, 2020

v12.16.3 release proposal #33009

Merged

Reviewers

himself65

himself65 left review comments

addaleax

addaleax approved these changes

+1 more reviewer

antsmartian

antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

repl

Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.